Re: [gentoo-dev] [PATCH 6/6] virtualx.eclass: Do not disable sandbox

2022-07-27 Thread Sam James


> On 27 Jul 2022, at 08:17, Michał Górny  wrote:
> 
> The code responsible for disabling sandbox dates back to 2002 and does
> not include any explanation.  Let's try if we still need it.
> 
> Signed-off-by: Michał Górny 
> ---

I'd tag https://bugs.gentoo.org/107479.

> eclass/virtualx.eclass | 7 ---
> 1 file changed, 7 deletions(-)



signature.asc
Description: Message signed with OpenPGP


[gentoo-dev] [PATCH 6/6] virtualx.eclass: Do not disable sandbox

2022-07-27 Thread Michał Górny
The code responsible for disabling sandbox dates back to 2002 and does
not include any explanation.  Let's try if we still need it.

Signed-off-by: Michał Górny 
---
 eclass/virtualx.eclass | 7 ---
 1 file changed, 7 deletions(-)

diff --git a/eclass/virtualx.eclass b/eclass/virtualx.eclass
index c0af095e89a5..e04834d39bd1 100644
--- a/eclass/virtualx.eclass
+++ b/eclass/virtualx.eclass
@@ -107,7 +107,6 @@ virtx() {
 
local i=0
local retval=0
-   local OLD_SANDBOX_ON="${SANDBOX_ON}"
local xvfbargs=( -screen 0 1280x1024x24 +extension RANDR )
 
debug-print "${FUNCNAME}: running Xvfb hack"
@@ -115,9 +114,6 @@ virtx() {
 
einfo "Starting Xvfb ..."
 
-   # We really do not want SANDBOX enabled here
-   export SANDBOX_ON="0"
-
debug-print "${FUNCNAME}: Xvfb -displayfd 1 ${xvfbargs[*]}"
local logfile=${T}/Xvfb.log
local pidfile=${T}/Xvfb.pid
@@ -134,9 +130,6 @@ virtx() {
die "Xvfb failed to start"
fi
 
-   # Now enable SANDBOX again if needed.
-   export SANDBOX_ON="${OLD_SANDBOX_ON}"
-
# Do not break on error, but setup $retval, as we need to kill Xvfb
einfo "Xvfb started on DISPLAY=${DISPLAY}"
debug-print "${FUNCNAME}: $@"
-- 
2.35.1