Re: [gentoo-dev] RFC: toolchain.eclass prefix support

2017-01-07 Thread Mike Gilbert
On Sat, Jan 7, 2017 at 10:07 AM, Benda Xu wrote: > Hi, > > Please help me review the patch attached. Please send patches for review with the content as the email body. See git format-patch and git send-email. > This patch has 5 main kinds of modifications to the eclass, > >

Re: [gentoo-dev] RFC: toolchain.eclass prefix support

2017-01-07 Thread David Seifert
On Sun, 2017-01-08 at 00:25 +0900, Benda Xu wrote: > James Le Cuirot writes: > > > Why? All the ebuilds using this eclass that I can find are at least > > EAPI 4. > > Okay!  I will remove this. > > Benda https://qa-reports.gentoo.org/output/eapi-per-eclass/toolchain.eclass/S

Re: [gentoo-dev] RFC: toolchain.eclass prefix support

2017-01-07 Thread Benda Xu
James Le Cuirot writes: > Why? All the ebuilds using this eclass that I can find are at least > EAPI 4. Okay! I will remove this. Benda signature.asc Description: PGP signature

Re: [gentoo-dev] RFC: toolchain.eclass prefix support

2017-01-07 Thread James Le Cuirot
On Sun, 08 Jan 2017 00:07:05 +0900 Benda Xu wrote: > * Define ED and EROOT for EAPI 0, 1 and 2. Why? All the ebuilds using this eclass that I can find are at least EAPI 4. -- James Le Cuirot (chewi) Gentoo Linux Developer pgpalLkoo9wHk.pgp Description: OpenPGP digital

[gentoo-dev] RFC: toolchain.eclass prefix support

2017-01-07 Thread Benda Xu
Hi, Please help me review the patch attached. This patch has 5 main kinds of modifications to the eclass, * Define ED and EROOT for EAPI 0, 1 and 2. * Add ${EPREFIX} to ${PREFIX} and quote the variables. * Strip ${EPREFIX} if used with a ebuild helper. * call fix_libtool_files.sh by