Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: bugfix for get-flag()

2016-06-05 Thread rindeal
New version in available at https://github.com/gentoo/gentoo/pull/1425. Check it out, it's cool.

Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: bugfix for get-flag()

2016-05-19 Thread Mike Frysinger
On 16 May 2016 14:17, rindeal wrote: > So this is what it looks like now: still missing tests. see eclass/tests/flag-o-matic.sh. > - local f var findflag="$1" > - > - # this code looks a little flaky but seems to work for > - # everything we want ... > - # for example, if

Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: bugfix for get-flag()

2016-05-16 Thread rindeal
> [Looks like your mailer is broken. All the tabs in your patch have > been mangled and appear as spaces.] > >> + # reverse loop >> + set -- ${!var} >> + local i=${#} >> + while [[ ${i} > 0 ]] ; do >> + local arg="${!i}" > > Using the positional parameters looks

Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: bugfix for get-flag()

2016-05-15 Thread Ulrich Mueller
> On Sun, 15 May 2016, rindeal wrote: [Looks like your mailer is broken. All the tabs in your patch have been mangled and appear as spaces.] > + # reverse loop > + set -- ${!var} > + local i=${#} > + while [[ ${i} > 0 ]] ; do > + local arg="${!i}" Using

Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: bugfix for get-flag()

2016-05-15 Thread rindeal
> On Sun, 15 May 2016 21:35:41 +0200 > rindeal wrote: > >> > Dnia 15 maja 2016 15:31:29 CEST, Jan Chren >> > napisał(a): >> >>+ local f="${!i}" >> >>+ if [ "${f#-${findflag#-}}" != "${f}" ] ; then >> > >> >

Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: bugfix for get-flag()

2016-05-15 Thread Michał Górny
On Sun, 15 May 2016 21:35:41 +0200 rindeal wrote: > > Dnia 15 maja 2016 15:31:29 CEST, Jan Chren > > napisał(a): > >>+ local f="${!i}" > >>+ if [ "${f#-${findflag#-}}" != "${f}" ] ; then > > > > I know

Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: bugfix for get-flag()

2016-05-15 Thread rindeal
> Dnia 15 maja 2016 15:31:29 CEST, Jan Chren napisał(a): >>- fix case: >> - `CFLAGS='-O1 -O2'` >> - `get-flag '-O*'` >> - before `-O1` >> - now `-O2` >>- fix case: >> - `CFLAGS='-W1,-O1'` >> - `get-flag '-O*'` >> - before `-W1,O1` >> - now return 1 >> >>`get-flag

Re: [gentoo-dev] [PATCH] flag-o-matic.eclass: bugfix for get-flag()

2016-05-15 Thread Michał Górny
Dnia 15 maja 2016 15:31:29 CEST, Jan Chren napisał(a): >- fix case: > - `CFLAGS='-O1 -O2'` > - `get-flag '-O*'` > - before `-O1` > - now `-O2` >- fix case: > - `CFLAGS='-W1,-O1'` > - `get-flag '-O*'` > - before `-W1,O1` > - now return 1 > >`get-flag march` == "i686"

[gentoo-dev] [PATCH] flag-o-matic.eclass: bugfix for get-flag()

2016-05-15 Thread Jan Chren
- fix case: - `CFLAGS='-O1 -O2'` - `get-flag '-O*'` - before `-O1` - now `-O2` - fix case: - `CFLAGS='-W1,-O1'` - `get-flag '-O*'` - before `-W1,O1` - now return 1 `get-flag march` == "i686" syntax still works. --- eclass/flag-o-matic.eclass | 13 + 1 file changed, 9