Re: [gentoo-dev] [PATCH] sys-libs/db: Remove --default-symver usage.
On Fri, Sep 27, 2019 at 12:49 PM Brian Evans wrote: > On 9/27/2019 3:31 PM, Manoj Gupta wrote: > > sys-libs/db-18.1.32 can builds without "--default-symver" > > linker flag. This fixes the build issue when using LLD linker > > which does not support this flag. > > > > Given that sys-libs/db is the only Gentoo package using > > "--default-symver" linker, it is probably not a terrible idea to > > drop use of "--default-symver" flag. > > > > But won't this change how *other* packages can be confused with multiple > slots of sys-libs/db installed at the same time? > > Thanks, I am not sure how multiple slotting will work after this change. Maybe, it'd be better to make use of a version script suggested at https://bugs.llvm.org/show_bug.cgi?id=43452. But I am not familiar with this package enough to create a version script for each installed shared library. Thanks, Manoj Brian > >
Re: [gentoo-dev] [PATCH] sys-libs/db: Remove --default-symver usage.
On 9/27/2019 3:31 PM, Manoj Gupta wrote: > sys-libs/db-18.1.32 can builds without "--default-symver" > linker flag. This fixes the build issue when using LLD linker > which does not support this flag. > > Given that sys-libs/db is the only Gentoo package using > "--default-symver" linker, it is probably not a terrible idea to > drop use of "--default-symver" flag. > But won't this change how *other* packages can be confused with multiple slots of sys-libs/db installed at the same time? Brian signature.asc Description: OpenPGP digital signature
[gentoo-dev] [PATCH] sys-libs/db: Remove --default-symver usage.
sys-libs/db-18.1.32 can builds without "--default-symver" linker flag. This fixes the build issue when using LLD linker which does not support this flag. Given that sys-libs/db is the only Gentoo package using "--default-symver" linker, it is probably not a terrible idea to drop use of "--default-symver" flag. Signed-off-by: Manoj Gupta --- sys-libs/db/{db-18.1.32.ebuild => db-18.1.32-r1.ebuild} | 6 -- 1 file changed, 6 deletions(-) rename sys-libs/db/{db-18.1.32.ebuild => db-18.1.32-r1.ebuild} (97%) diff --git a/sys-libs/db/db-18.1.32.ebuild b/sys-libs/db/db-18.1.32-r1.ebuild similarity index 97% rename from sys-libs/db/db-18.1.32.ebuild rename to sys-libs/db/db-18.1.32-r1.ebuild index be515fd043e..c23babeb9d9 100644 --- a/sys-libs/db/db-18.1.32.ebuild +++ b/sys-libs/db/db-18.1.32-r1.ebuild @@ -146,12 +146,6 @@ multilib_src_configure() { is-flagq -O[s123] || append-flags -O2 fi - # Add linker versions to the symbols. Easier to do, and safer than header file - # mumbo jumbo. - if use userland_GNU ; then - append-ldflags -Wl,--default-symver - fi - # use `set` here since the java opts will contain whitespace if multilib_is_native_abi && use java ; then myconf+=( -- 2.23.0.444.g18eeb5a265-goog