Re: [gentoo-dev] [PATCH] xdg.eclass: break dependency loop with glib and utility packages
On Wed, Nov 25, 2015 at 9:19 AM, Gilles Dartiguelonguewrote: > Hello all, > > making gnome2.eclass depend on xdg.eclass has the unfortunate > consequence of having xdg utility package in the dependency loop of > glib which uses gnome2.eclass for various features (such as gsettings > schema compilation). > > Since there is no other need that I know of to make these dependencies > optional for xdg.eclass, I am proposing to have them skipped for glib > only. > > This issue currently breaks stage generation. This change seems reasonable. Off topic: For future patch submissions, I would suggest using git-send-email; reviewing patches as attachments is annoying.
[gentoo-dev] [PATCH] xdg.eclass: break dependency loop with glib and utility packages
Hello all, making gnome2.eclass depend on xdg.eclass has the unfortunate consequence of having xdg utility package in the dependency loop of glib which uses gnome2.eclass for various features (such as gsettings schema compilation). Since there is no other need that I know of to make these dependencies optional for xdg.eclass, I am proposing to have them skipped for glib only. This issue currently breaks stage generation. -- Gilles DartiguelongueGentoo From 905366a8a5a048a968df485223d47dfe1e50778b Mon Sep 17 00:00:00 2001 From: Gilles Dartiguelongue Date: Wed, 25 Nov 2015 13:15:51 +0100 Subject: [PATCH] xdg.eclass: break dependency loop due to XDG tools using glib --- eclass/xdg.eclass | 3 +++ 1 file changed, 3 insertions(+) diff --git a/eclass/xdg.eclass b/eclass/xdg.eclass index 2ad0ada..9f10932 100644 --- a/eclass/xdg.eclass +++ b/eclass/xdg.eclass @@ -21,10 +21,13 @@ case "${EAPI:-0}" in *) die "EAPI=${EAPI} is not supported" ;; esac +# Avoid dependency loop as both depend on glib-2 +if [[ ${CATEGORY}/${P} != dev-libs/glib-2.* ]] ; then DEPEND=" dev-util/desktop-file-utils x11-misc/shared-mime-info " +fi # @FUNCTION: xdg_src_prepare # @DESCRIPTION: -- 2.6.3