Re: [gentoo-dev] [PATCH 01/14] cdrom.eclass: Detect case-insensitively and handle special characters

2017-04-19 Thread James Le Cuirot
On Wed, 19 Apr 2017 05:14:34 +0200 Michał Górny wrote: > >> > @@ -243,4 +240,27 @@ _cdrom_locate_file_on_cd() { > >> > done > >> > } > >> > > >> > +# @FUNCTION: _cdrom_glob_match > >> > +# @USAGE: > >> > +# @INTERNAL > >> > +# @DESCRIPTION: > >> > +# Locates the given path ($2) with

Re: [gentoo-dev] [PATCH 01/14] cdrom.eclass: Detect case-insensitively and handle special characters

2017-04-18 Thread Michał Górny
Dnia 18 kwietnia 2017 23:31:31 CEST, James Le Cuirot napisał(a): >On Tue, 18 Apr 2017 08:08:44 +0200 >Michał Górny wrote: > >> On pon, 2017-04-17 at 22:53 +0100, James Le Cuirot wrote: >> > diff --git a/eclass/cdrom.eclass b/eclass/cdrom.eclass >> > index 41488d2446c2..de72f15563db 100644 >> > -

Re: [gentoo-dev] [PATCH 01/14] cdrom.eclass: Detect case-insensitively and handle special characters

2017-04-18 Thread James Le Cuirot
On Tue, 18 Apr 2017 08:08:44 +0200 Michał Górny wrote: > On pon, 2017-04-17 at 22:53 +0100, James Le Cuirot wrote: > > diff --git a/eclass/cdrom.eclass b/eclass/cdrom.eclass > > index 41488d2446c2..de72f15563db 100644 > > --- a/eclass/cdrom.eclass > > +++ b/eclass/cdrom.eclass > > @@ -79,12 +79,1

Re: [gentoo-dev] [PATCH 01/14] cdrom.eclass: Detect case-insensitively and handle special characters

2017-04-17 Thread Michał Górny
On pon, 2017-04-17 at 22:53 +0100, James Le Cuirot wrote: > This eclass previously used "find -iname" but it only checked the file > case-insensitively and not the directories. There is "find -ipath" but > this does not intelligently skip non-matching paths, making it > slow. Globbing is used here

[gentoo-dev] [PATCH 01/14] cdrom.eclass: Detect case-insensitively and handle special characters

2017-04-17 Thread James Le Cuirot
This eclass previously used "find -iname" but it only checked the file case-insensitively and not the directories. There is "find -ipath" but this does not intelligently skip non-matching paths, making it slow. Globbing is used here instead. The : character has always been used to delimit paths gi