Re: [gentoo-dev] [PATCH 03/16] gnome2-utils.eclass: remove redundant @USAGE lines

2019-10-09 Thread Mart Raudsepp
Ühel kenal päeval, K, 09.10.2019 kell 22:12, kirjutas Gilles
Dartiguelongue:
> Looks good.

I'm waiting on a patch or patchset for EAPI-7 fixes to appear to
gentoo-dev for review, and then to merge all of that in the same push
(together with a trivial third change waiting in bugzilla). That
patchset has yet to appear here iirc, but was a topic of discussion
earlier today and I believe it should appear soon by author. Once we
are happy, I can merge them all at once.


Mart

> Le vendredi 06 septembre 2019 à 13:40 -0500, bkoh...@gentoo.org a
> écrit :
> > From: Ben Kohler 
> > 
> > Signed-off-by: Ben Kohler 
> > ---
> >  eclass/gnome2-utils.eclass | 5 -
> >  1 file changed, 5 deletions(-)
> > 
> > diff --git a/eclass/gnome2-utils.eclass b/eclass/gnome2-
> > utils.eclass
> > index 06683a7467f..c9765f6fd91 100644
> > --- a/eclass/gnome2-utils.eclass
> > +++ b/eclass/gnome2-utils.eclass
> > @@ -297,7 +297,6 @@ gnome2_schemas_savelist() {
> >  }
> >  
> >  # @FUNCTION: gnome2_schemas_update
> > -# @USAGE: gnome2_schemas_update
> >  # @DESCRIPTION:
> >  # Updates GSettings schemas.
> >  # This function should be called from pkg_postinst and pkg_postrm.
> > @@ -328,7 +327,6 @@ gnome2_gdk_pixbuf_savelist() {
> >  }
> >  
> >  # @FUNCTION: gnome2_gdk_pixbuf_update
> > -# @USAGE: gnome2_gdk_pixbuf_update
> >  # @DESCRIPTION:
> >  # Updates gdk-pixbuf loader cache if
> > GNOME2_ECLASS_GDK_PIXBUF_LOADERS has some.
> >  # This function should be called from pkg_postinst and pkg_postrm.
> > @@ -360,7 +358,6 @@ gnome2_gdk_pixbuf_update() {
> >  }
> >  
> >  # @FUNCTION: gnome2_query_immodules_gtk2
> > -# @USAGE: gnome2_query_immodules_gtk2
> >  # @DESCRIPTION:
> >  # Updates gtk2 immodules/gdk-pixbuf loaders listing.
> >  gnome2_query_immodules_gtk2() {
> > @@ -374,7 +371,6 @@ gnome2_query_immodules_gtk2() {
> >  }
> >  
> >  # @FUNCTION: gnome2_query_immodules_gtk3
> > -# @USAGE: gnome2_query_immodules_gtk3
> >  # @DESCRIPTION:
> >  # Updates gtk3 immodules/gdk-pixbuf loaders listing.
> >  gnome2_query_immodules_gtk3() {
> > @@ -388,7 +384,6 @@ gnome2_query_immodules_gtk3() {
> >  }
> >  
> >  # @FUNCTION: gnome2_giomodule_cache_update
> > -# @USAGE: gnome2_giomodule_cache_update
> >  # @DESCRIPTION:
> >  # Updates glib's gio modules cache.
> >  # This function should be called from pkg_postinst and pkg_postrm.


signature.asc
Description: This is a digitally signed message part


Re: [gentoo-dev] [PATCH 03/16] gnome2-utils.eclass: remove redundant @USAGE lines

2019-10-09 Thread Gilles Dartiguelongue
Looks good.

Le vendredi 06 septembre 2019 à 13:40 -0500, bkoh...@gentoo.org a
écrit :
> From: Ben Kohler 
> 
> Signed-off-by: Ben Kohler 
> ---
>  eclass/gnome2-utils.eclass | 5 -
>  1 file changed, 5 deletions(-)
> 
> diff --git a/eclass/gnome2-utils.eclass b/eclass/gnome2-utils.eclass
> index 06683a7467f..c9765f6fd91 100644
> --- a/eclass/gnome2-utils.eclass
> +++ b/eclass/gnome2-utils.eclass
> @@ -297,7 +297,6 @@ gnome2_schemas_savelist() {
>  }
>  
>  # @FUNCTION: gnome2_schemas_update
> -# @USAGE: gnome2_schemas_update
>  # @DESCRIPTION:
>  # Updates GSettings schemas.
>  # This function should be called from pkg_postinst and pkg_postrm.
> @@ -328,7 +327,6 @@ gnome2_gdk_pixbuf_savelist() {
>  }
>  
>  # @FUNCTION: gnome2_gdk_pixbuf_update
> -# @USAGE: gnome2_gdk_pixbuf_update
>  # @DESCRIPTION:
>  # Updates gdk-pixbuf loader cache if
> GNOME2_ECLASS_GDK_PIXBUF_LOADERS has some.
>  # This function should be called from pkg_postinst and pkg_postrm.
> @@ -360,7 +358,6 @@ gnome2_gdk_pixbuf_update() {
>  }
>  
>  # @FUNCTION: gnome2_query_immodules_gtk2
> -# @USAGE: gnome2_query_immodules_gtk2
>  # @DESCRIPTION:
>  # Updates gtk2 immodules/gdk-pixbuf loaders listing.
>  gnome2_query_immodules_gtk2() {
> @@ -374,7 +371,6 @@ gnome2_query_immodules_gtk2() {
>  }
>  
>  # @FUNCTION: gnome2_query_immodules_gtk3
> -# @USAGE: gnome2_query_immodules_gtk3
>  # @DESCRIPTION:
>  # Updates gtk3 immodules/gdk-pixbuf loaders listing.
>  gnome2_query_immodules_gtk3() {
> @@ -388,7 +384,6 @@ gnome2_query_immodules_gtk3() {
>  }
>  
>  # @FUNCTION: gnome2_giomodule_cache_update
> -# @USAGE: gnome2_giomodule_cache_update
>  # @DESCRIPTION:
>  # Updates glib's gio modules cache.
>  # This function should be called from pkg_postinst and pkg_postrm.
-- 
Gilles Dartiguelongue 
Gentoo




[gentoo-dev] [PATCH 03/16] gnome2-utils.eclass: remove redundant @USAGE lines

2019-09-06 Thread bkohler
From: Ben Kohler 

Signed-off-by: Ben Kohler 
---
 eclass/gnome2-utils.eclass | 5 -
 1 file changed, 5 deletions(-)

diff --git a/eclass/gnome2-utils.eclass b/eclass/gnome2-utils.eclass
index 06683a7467f..c9765f6fd91 100644
--- a/eclass/gnome2-utils.eclass
+++ b/eclass/gnome2-utils.eclass
@@ -297,7 +297,6 @@ gnome2_schemas_savelist() {
 }
 
 # @FUNCTION: gnome2_schemas_update
-# @USAGE: gnome2_schemas_update
 # @DESCRIPTION:
 # Updates GSettings schemas.
 # This function should be called from pkg_postinst and pkg_postrm.
@@ -328,7 +327,6 @@ gnome2_gdk_pixbuf_savelist() {
 }
 
 # @FUNCTION: gnome2_gdk_pixbuf_update
-# @USAGE: gnome2_gdk_pixbuf_update
 # @DESCRIPTION:
 # Updates gdk-pixbuf loader cache if GNOME2_ECLASS_GDK_PIXBUF_LOADERS has some.
 # This function should be called from pkg_postinst and pkg_postrm.
@@ -360,7 +358,6 @@ gnome2_gdk_pixbuf_update() {
 }
 
 # @FUNCTION: gnome2_query_immodules_gtk2
-# @USAGE: gnome2_query_immodules_gtk2
 # @DESCRIPTION:
 # Updates gtk2 immodules/gdk-pixbuf loaders listing.
 gnome2_query_immodules_gtk2() {
@@ -374,7 +371,6 @@ gnome2_query_immodules_gtk2() {
 }
 
 # @FUNCTION: gnome2_query_immodules_gtk3
-# @USAGE: gnome2_query_immodules_gtk3
 # @DESCRIPTION:
 # Updates gtk3 immodules/gdk-pixbuf loaders listing.
 gnome2_query_immodules_gtk3() {
@@ -388,7 +384,6 @@ gnome2_query_immodules_gtk3() {
 }
 
 # @FUNCTION: gnome2_giomodule_cache_update
-# @USAGE: gnome2_giomodule_cache_update
 # @DESCRIPTION:
 # Updates glib's gio modules cache.
 # This function should be called from pkg_postinst and pkg_postrm.
-- 
2.23.0