Re: [gentoo-dev] [PATCH 06/15] perl-module.eclass: Introduce MODULE_NAME and MODULE_P while still keeping existing weirdness compatible

[Michał Górny]

Dnia 11 grudnia 2015 22:03:02 CET, dilfri...@gentoo.org napisał(a):
>From: Andreas K. Hüttel 
>
>---
> eclass/perl-module.eclass | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>diff --git a/eclass/perl-module.eclass b/eclass/perl-module.eclass
>index 9d87b17..6a5f2ff 100644
>--- a/eclass/perl-module.eclass
>+++ b/eclass/perl-module.eclass
>@@ -106,13 +106,15 @@ if [[ -n ${MY_PN} || -n ${MY_PV} || -n
>${MODULE_VERSION} ]] ; then
>   : ${MY_P:=${MY_PN:-${PN}}-${MY_PV:-${MODULE_VERSION:-${PV
>   S=${MY_S:-${WORKDIR}/${MY_P}}
> fi
>+MODULE_NAME=${MY_PN:-${PN}}
>+MODULE_P=${MY_P:-${P}}
> 
> [[ -z "${SRC_URI}" && -z "${MODULE_A}" ]] && \
>-  MODULE_A="${MY_P:-${P}}.${MODULE_A_EXT:-tar.gz}"
>+  MODULE_A="${MODULE_P}.${MODULE_A_EXT:-tar.gz}"
> [[ -z "${SRC_URI}" && -n "${MODULE_AUTHOR}" ]] && \
>   
> SRC_URI="mirror://cpan/authors/id/${MODULE_AUTHOR:0:1}/${MODULE_AUTHOR:0:2}/${MODULE_AUTHOR}/${MODULE_SECTION:+${MODULE_SECTION}/}${MODULE_A}"
> [[ -z "${HOMEPAGE}" ]] && \
>-  HOMEPAGE="http://search.cpan.org/dist/${MY_PN:-${PN}}/;
>+  HOMEPAGE="http://search.cpan.org/dist/${MODULE_NAME}/;
> 
> SRC_PREP="no"
> SRC_TEST="skip"

Here, the commit message summary line is way too long.


-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.

[gentoo-dev] [PATCH 06/15] perl-module.eclass: Introduce MODULE_NAME and MODULE_P while still keeping existing weirdness compatible

[dilfridge]

From: Andreas K. Hüttel 

---
 eclass/perl-module.eclass | 6 --
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/eclass/perl-module.eclass b/eclass/perl-module.eclass
index 9d87b17..6a5f2ff 100644
--- a/eclass/perl-module.eclass
+++ b/eclass/perl-module.eclass
@@ -106,13 +106,15 @@ if [[ -n ${MY_PN} || -n ${MY_PV} || -n ${MODULE_VERSION} 
]] ; then
: ${MY_P:=${MY_PN:-${PN}}-${MY_PV:-${MODULE_VERSION:-${PV
S=${MY_S:-${WORKDIR}/${MY_P}}
 fi
+MODULE_NAME=${MY_PN:-${PN}}
+MODULE_P=${MY_P:-${P}}
 
 [[ -z "${SRC_URI}" && -z "${MODULE_A}" ]] && \
-   MODULE_A="${MY_P:-${P}}.${MODULE_A_EXT:-tar.gz}"
+   MODULE_A="${MODULE_P}.${MODULE_A_EXT:-tar.gz}"
 [[ -z "${SRC_URI}" && -n "${MODULE_AUTHOR}" ]] && \

SRC_URI="mirror://cpan/authors/id/${MODULE_AUTHOR:0:1}/${MODULE_AUTHOR:0:2}/${MODULE_AUTHOR}/${MODULE_SECTION:+${MODULE_SECTION}/}${MODULE_A}"
 [[ -z "${HOMEPAGE}" ]] && \
-   HOMEPAGE="http://search.cpan.org/dist/${MY_PN:-${PN}}/;
+   HOMEPAGE="http://search.cpan.org/dist/${MODULE_NAME}/;
 
 SRC_PREP="no"
 SRC_TEST="skip"
-- 
2.6.3