Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On 9/18/19 3:33 PM, Alec Warner wrote: > > I think the problem I have with this conversation is that I am > discussing things that are technically possible (e.g. we can in fact > propagate security fixes to all go packages, same as dynamically linked > packages) with things we do not think we will

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On 9/18/19 5:28 PM, William Hubbs wrote: >> >> I don't really understand why you're adding it to *this* eclass. Isn't >> it true for all Go packages? So I suppose golang-* eclasses are >> affected as well. > > You are correct, they are affected. No one, including myself, caught > that during the

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On Wed, Sep 18, 2019 at 10:29:12PM +0200, Michał Górny wrote: > On Wed, 2019-09-18 at 15:26 -0500, William Hubbs wrote: > > Signed-off-by: William Hubbs > > --- > > eclass/go-module.eclass | 161 > > 1 file changed, 161 insertions(+) > > create mode 10064

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On Wed, Sep 18, 2019 at 12:28:29PM -0700, Zac Medico wrote: > On 9/18/19 11:04 AM, Alec Warner wrote: > > > > > > On Wed, Sep 18, 2019 at 10:50 AM Michael Orlitzky > > wrote: > > > > On 9/16/19 10:17 AM, William Hubbs wrote: > > > + > > > +# @FUNCTION: go-mod

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On Wed, 2019-09-18 at 15:26 -0500, William Hubbs wrote: > Signed-off-by: William Hubbs > --- > eclass/go-module.eclass | 161 > 1 file changed, 161 insertions(+) > create mode 100644 eclass/go-module.eclass > > diff --git a/eclass/go-module.eclass b/ecla

[gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

Signed-off-by: William Hubbs --- eclass/go-module.eclass | 161 1 file changed, 161 insertions(+) create mode 100644 eclass/go-module.eclass diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass new file mode 100644 index 000..6f609e9454

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On Wed, Sep 18, 2019 at 12:15 PM Michael Orlitzky wrote: > On 9/18/19 2:04 PM, Alec Warner wrote: > > > > I'm actually pretty fine with this wording, upstream has said not to > > dynamically link in these use cases. > > > > Respectfully, the fact that you're OK with it doesn't make it not BS. It

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On 9/18/19 11:04 AM, Alec Warner wrote: > > > On Wed, Sep 18, 2019 at 10:50 AM Michael Orlitzky > wrote: > > On 9/16/19 10:17 AM, William Hubbs wrote: > > + > > +# @FUNCTION: go-module_pkg_postinst > > +# @DESCRIPTION: > > +# Display a warning about s

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On 9/18/19 2:04 PM, Alec Warner wrote: > > I'm actually pretty fine with this wording, upstream has said not to > dynamically link in these use cases. >   Respectfully, the fact that you're OK with it doesn't make it not BS. It reads like "there's no way we can fix this!" when really it means "we

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On Wed, Sep 18, 2019 at 10:50 AM Michael Orlitzky wrote: > On 9/16/19 10:17 AM, William Hubbs wrote: > > + > > +# @FUNCTION: go-module_pkg_postinst > > +# @DESCRIPTION: > > +# Display a warning about security updates for Go programs. > > +go-module_pkg_postinst() { > > + ewarn "${PN} is writt

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On 9/16/19 10:17 AM, William Hubbs wrote: > + > +# @FUNCTION: go-module_pkg_postinst > +# @DESCRIPTION: > +# Display a warning about security updates for Go programs. > +go-module_pkg_postinst() { > + ewarn "${PN} is written in the Go programming language." > + ewarn "Since this language is

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On 9/17/19 7:10 AM, William Hubbs wrote: > On Tue, Sep 17, 2019 at 07:36:07AM +0200, Michał Górny wrote: >> On Mon, 2019-09-16 at 17:00 -0500, William Hubbs wrote: >>> On Mon, Sep 16, 2019 at 11:50:12AM -0700, Zac Medico wrote: On 9/16/19 11:35 AM, William Hubbs wrote: > On Mon, Sep 16, 20

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On Tue, Sep 17, 2019 at 07:36:07AM +0200, Michał Górny wrote: > On Mon, 2019-09-16 at 17:00 -0500, William Hubbs wrote: > > On Mon, Sep 16, 2019 at 11:50:12AM -0700, Zac Medico wrote: > > > On 9/16/19 11:35 AM, William Hubbs wrote: > > > > On Mon, Sep 16, 2019 at 11:01:38AM -0700, Zac Medico wrote:

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On Mon, 2019-09-16 at 17:00 -0500, William Hubbs wrote: > On Mon, Sep 16, 2019 at 11:50:12AM -0700, Zac Medico wrote: > > On 9/16/19 11:35 AM, William Hubbs wrote: > > > On Mon, Sep 16, 2019 at 11:01:38AM -0700, Zac Medico wrote: > > > > For packages that I maintain, I'd prefer to continue using EG

[gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

Signed-off-by: William Hubbs --- eclass/go-module.eclass | 105 1 file changed, 105 insertions(+) create mode 100644 eclass/go-module.eclass diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass new file mode 100644 index 000..810e66e1c5

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On Mon, Sep 16, 2019 at 11:50:12AM -0700, Zac Medico wrote: > On 9/16/19 11:35 AM, William Hubbs wrote: > > On Mon, Sep 16, 2019 at 11:01:38AM -0700, Zac Medico wrote: > >> For packages that I maintain, I'd prefer to continue using EGO_VENDOR to > >> even with packages using go.mod. I hope that thi

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On 9/16/19 11:26 AM, William Hubbs wrote: > On Mon, Sep 16, 2019 at 10:48:14AM -0700, Zac Medico wrote: >> On 9/16/19 7:17 AM, William Hubbs wrote: >>> +BDEPEND=">=dev-lang/go-1.12" >>> + >>> +# The following go flags should be used for all go builds. >>> +# -mod=vendor stopps downloading of depend

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On Mon, 2019-09-16 at 13:46 -0500, William Hubbs wrote: > On Mon, Sep 16, 2019 at 08:05:50PM +0200, Michał Górny wrote: > > On Mon, 2019-09-16 at 09:17 -0500, William Hubbs wrote: > > > Signed-off-by: William Hubbs > > > --- > > > eclass/go-module.eclass | 117

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On 9/16/19 11:35 AM, William Hubbs wrote: > On Mon, Sep 16, 2019 at 11:01:38AM -0700, Zac Medico wrote: >> For packages that I maintain, I'd prefer to continue using EGO_VENDOR to >> even with packages using go.mod. I hope that this go-module.class will >> not preclude this sort of usage. For examp

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On Mon, Sep 16, 2019 at 08:05:50PM +0200, Michał Górny wrote: > On Mon, 2019-09-16 at 09:17 -0500, William Hubbs wrote: > > Signed-off-by: William Hubbs > > --- > > eclass/go-module.eclass | 117 > > 1 file changed, 117 insertions(+) > > create mode 10064

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On Mon, Sep 16, 2019 at 11:01:38AM -0700, Zac Medico wrote: > On 9/16/19 7:17 AM, William Hubbs wrote: > > +# You will know the software you are packaging uses modules because > > +# it will have files named go.sum and go.mod in its top-level source > > +# directory. If it does not have these files

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On Mon, Sep 16, 2019 at 10:48:14AM -0700, Zac Medico wrote: > On 9/16/19 7:17 AM, William Hubbs wrote: > > +BDEPEND=">=dev-lang/go-1.12" > > + > > +# The following go flags should be used for all go builds. > > +# -mod=vendor stopps downloading of dependencies from the internet. > > +# -v prints th

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On Mon, 2019-09-16 at 09:17 -0500, William Hubbs wrote: > Signed-off-by: William Hubbs > --- > eclass/go-module.eclass | 117 > 1 file changed, 117 insertions(+) > create mode 100644 eclass/go-module.eclass > > diff --git a/eclass/go-module.eclass b/ecla

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On 9/16/19 7:17 AM, William Hubbs wrote: > +# You will know the software you are packaging uses modules because > +# it will have files named go.sum and go.mod in its top-level source > +# directory. If it does not have these files, use the golang-* eclasses. > +# > +# If the software you are packa

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

On 9/16/19 7:17 AM, William Hubbs wrote: > +BDEPEND=">=dev-lang/go-1.12" > + > +# The following go flags should be used for all go builds. > +# -mod=vendor stopps downloading of dependencies from the internet. > +# -v prints the names of packages as they are compiled > +# -x prints commands as they

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

All, here is my thought about the src_prepare function in the eclass. It is commented right now, but I want to uncomment it and not force ${P} into the path in the vendor tarball if no one objects; I think it is easier to do that because it would allow me to detect when upstream vendors and the ma

[gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

Signed-off-by: William Hubbs --- eclass/go-module.eclass | 117 1 file changed, 117 insertions(+) create mode 100644 eclass/go-module.eclass diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass new file mode 100644 index 000..7e16ec4e95

Re: [gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

I know about the typos on the eqawarns, they need to be a block if, so I'll take care of that before I commit. Wililam signature.asc Description: Digital signature

[gentoo-dev] [PATCH 1/1] go-module.eclass: introduce new eclass to handle go modules

Signed-off-by: William Hubbs --- eclass/go-module.eclass | 100 1 file changed, 100 insertions(+) create mode 100644 eclass/go-module.eclass diff --git a/eclass/go-module.eclass b/eclass/go-module.eclass new file mode 100644 index 000..501e334b23