[gentoo-dev] [PATCH multilib-build] Tee the build logs to ABI-specific files.

2013-02-21 Thread Michał Górny 
This makes reading them a bit easier, especially with phases run
in parallel.
---
 gx86/eclass/multilib-build.eclass | 7 ---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/gx86/eclass/multilib-build.eclass 
b/gx86/eclass/multilib-build.eclass
index feac748..93c4335 100644
--- a/gx86/eclass/multilib-build.eclass
+++ b/gx86/eclass/multilib-build.eclass
@@ -100,7 +100,8 @@ multilib_foreach_abi() {
local ABI
for ABI in $(multilib_get_enabled_abis); do
multilib_toolchain_setup ${ABI}
-   BUILD_DIR=${initial_dir%%/}-${ABI} ${@}
+   local BUILD_DIR=${initial_dir%%/}-${ABI}
+   ${@} | tee -a ${T}/build-${ABI}.log
done
 }
 
@@ -127,8 +128,8 @@ multilib_parallel_foreach_abi() {
multijob_child_init
 
multilib_toolchain_setup ${ABI}
-   BUILD_DIR=${initial_dir%%/}-${ABI}
-   ${@}
+   local BUILD_DIR=${initial_dir%%/}-${ABI}
+   ${@} 21 | tee -a ${T}/build-${ABI}.log
) 
 
multijob_post_fork
-- 
1.8.1.2

Re: [gentoo-dev] [PATCH multilib-build] Tee the build logs to ABI-specific files.

2013-02-21 Thread Matt Turner 
On Thu, Feb 21, 2013 at 3:27 AM, Michał Górny mgo...@gentoo.org wrote:
 This makes reading them a bit easier, especially with phases run
 in parallel.
 ---
  gx86/eclass/multilib-build.eclass | 7 ---
  1 file changed, 4 insertions(+), 3 deletions(-)

 diff --git a/gx86/eclass/multilib-build.eclass 
 b/gx86/eclass/multilib-build.eclass
 index feac748..93c4335 100644
 --- a/gx86/eclass/multilib-build.eclass
 +++ b/gx86/eclass/multilib-build.eclass
 @@ -100,7 +100,8 @@ multilib_foreach_abi() {
 local ABI
 for ABI in $(multilib_get_enabled_abis); do
 multilib_toolchain_setup ${ABI}
 -   BUILD_DIR=${initial_dir%%/}-${ABI} ${@}
 +   local BUILD_DIR=${initial_dir%%/}-${ABI}
 +   ${@} | tee -a ${T}/build-${ABI}.log
 done
  }

 @@ -127,8 +128,8 @@ multilib_parallel_foreach_abi() {
 multijob_child_init

 multilib_toolchain_setup ${ABI}
 -   BUILD_DIR=${initial_dir%%/}-${ABI}
 -   ${@}
 +   local BUILD_DIR=${initial_dir%%/}-${ABI}
 +   ${@} 21 | tee -a ${T}/build-${ABI}.log
 ) 

 multijob_post_fork
 --
 1.8.1.2



Definitely seems like a good idea.

Re: [gentoo-dev] [PATCH multilib-build] Tee the build logs to ABI-specific files.

2013-02-21 Thread Zac Medico 
On 02/21/2013 03:27 AM, Michał Górny wrote:
 This makes reading them a bit easier, especially with phases run
 in parallel.
 ---
  gx86/eclass/multilib-build.eclass | 7 ---
  1 file changed, 4 insertions(+), 3 deletions(-)
 
 diff --git a/gx86/eclass/multilib-build.eclass 
 b/gx86/eclass/multilib-build.eclass
 index feac748..93c4335 100644
 --- a/gx86/eclass/multilib-build.eclass
 +++ b/gx86/eclass/multilib-build.eclass
 @@ -100,7 +100,8 @@ multilib_foreach_abi() {
   local ABI
   for ABI in $(multilib_get_enabled_abis); do
   multilib_toolchain_setup ${ABI}
 - BUILD_DIR=${initial_dir%%/}-${ABI} ${@}
 + local BUILD_DIR=${initial_dir%%/}-${ABI}
 + ${@} | tee -a ${T}/build-${ABI}.log
   done
  }
  
 @@ -127,8 +128,8 @@ multilib_parallel_foreach_abi() {
   multijob_child_init
  
   multilib_toolchain_setup ${ABI}
 - BUILD_DIR=${initial_dir%%/}-${ABI}
 - ${@}
 + local BUILD_DIR=${initial_dir%%/}-${ABI}
 + ${@} 21 | tee -a ${T}/build-${ABI}.log
   ) 
  
   multijob_post_fork
 

Maybe use EBUILD_DEATH_HOOKS to display the locations of the logs?
-- 
Thanks,
Zac

Re: [gentoo-dev] [PATCH multilib-build] Tee the build logs to ABI-specific files.

2013-02-21 Thread Michał Górny 
On Thu, 21 Feb 2013 08:55:45 -0800
Zac Medico zmed...@gentoo.org wrote:

 On 02/21/2013 03:27 AM, Michał Górny wrote:
  This makes reading them a bit easier, especially with phases run
  in parallel.
  ---
   gx86/eclass/multilib-build.eclass | 7 ---
   1 file changed, 4 insertions(+), 3 deletions(-)
  
  diff --git a/gx86/eclass/multilib-build.eclass 
  b/gx86/eclass/multilib-build.eclass
  index feac748..93c4335 100644
  --- a/gx86/eclass/multilib-build.eclass
  +++ b/gx86/eclass/multilib-build.eclass
  @@ -100,7 +100,8 @@ multilib_foreach_abi() {
  local ABI
  for ABI in $(multilib_get_enabled_abis); do
  multilib_toolchain_setup ${ABI}
  -   BUILD_DIR=${initial_dir%%/}-${ABI} ${@}
  +   local BUILD_DIR=${initial_dir%%/}-${ABI}
  +   ${@} | tee -a ${T}/build-${ABI}.log
  done
   }
   
  @@ -127,8 +128,8 @@ multilib_parallel_foreach_abi() {
  multijob_child_init
   
  multilib_toolchain_setup ${ABI}
  -   BUILD_DIR=${initial_dir%%/}-${ABI}
  -   ${@}
  +   local BUILD_DIR=${initial_dir%%/}-${ABI}
  +   ${@} 21 | tee -a ${T}/build-${ABI}.log
  ) 
   
  multijob_post_fork
  
 
 Maybe use EBUILD_DEATH_HOOKS to display the locations of the logs?

Is this documented somewhere?

-- 
Best regards,
Michał Górny


signature.asc
Description: PGP signature

Re: [gentoo-dev] [PATCH multilib-build] Tee the build logs to ABI-specific files.

2013-02-21 Thread Zac Medico 
On 02/21/2013 09:03 AM, Michał Górny wrote:
 On Thu, 21 Feb 2013 08:55:45 -0800
 Zac Medico zmed...@gentoo.org wrote:
 Maybe use EBUILD_DEATH_HOOKS to display the locations of the logs?
 
 Is this documented somewhere?

No, it doesn't seem to be documented in PMS, though some eclasses have
been using it for a very long time. See java-utils-2, multiprocessing,
and toolchain eclasses. It's also used in the sys-apps/sandbox and
www-client/chromium ebuilds.

Portage documents the related register_die_hook function in `man 5 ebuild`.
-- 
Thanks,
Zac