Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies
On Thu, 2020-01-02 at 22:08 +0100, Michał Górny wrote: > On Thu, 2020-01-02 at 21:15 +0100, Ulrich Mueller wrote: > > > Hadn't we established that ruby_samelib() is dead code, no longer > > used > > since 2010? > > > > You did. However, it isn't marked as private API and I'm not the > eclass > maintainer to take care of removing public API. I have no clue if > Ruby > project doesn't have some secret overlays using it. I'm not aware of any usage, but I also was not aware that this is no longer used. I'll make a note to check this out and propose a deprecation/removal plan. Hans signature.asc Description: This is a digitally signed message part
Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies
On Thu, 2020-01-02 at 16:57 +0100, Michał Górny wrote: > Using 2-style USE dependencies on packages not having the flag > in question is forbidden by PMS. Looks good to me, thanks for proposing a fix for this. Hans signature.asc Description: This is a digitally signed message part
Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies
On Fri, 3 Jan 2020 22:34:19 +
Michael 'veremitz' Everitt wrote:
> On 03/01/20 10:36, David Seifert wrote:
> > On Thu, 2020-01-02 at 21:54 +, Michael 'veremitz' Everitt wrote:
> >> On 02/01/20 21:08, Michał Górny wrote:
> >>> On Thu, 2020-01-02 at 21:15 +0100, Ulrich Mueller wrote:
> > On Thu, 02 Jan 2020, Michał Górny wrote:
> > --- a/eclass/ruby-ng.eclass
> > +++ b/eclass/ruby-ng.eclass
> > @@ -137,7 +137,7 @@ ruby_samelib() {
> > local res=
> > for _ruby_implementation in $(_ruby_get_all_impls); do
> > has -${_ruby_implementation} $@ || \
> > - res="${res}ruby_targets_${_ruby_impleme
> > ntation}?,"
> > + res="${res}ruby_targets_${_ruby_impleme
> > ntation}(-)?,"
> > done
> >
> > echo "[${res%,}]"
> Hadn't we established that ruby_samelib() is dead code, no longer
> used
> since 2010?
>
> >>> You did. However, it isn't marked as private API and I'm not the
> >>> eclass
> >>> maintainer to take care of removing public API. I have no clue if
> >>> Ruby
> >>> project doesn't have some secret overlays using it.
> >>>
> >> You can't use QA super-powerz ?! BDFL + sub-BDFL ?!
> >> *
> >>
> >> * Thought the tags probably worth making explicit
> >>
> > Can you please stop polluting the -dev mailing list with this senseless
> > chatter?
> >
> >
> Perhaps I should remind you that this is a public mailing list (or hasn't
> successfully been censored Yet) and not a private communication channel for
> developers (see -core for this). But I don't need to tell you this
This may be a public list and I don't always expect threads to stay
precisely on-topic but the posts should still have some value. This was
just frivolous. You won't know this but I have defended your presence
on this list multiple times in the past. Please respect that.
--
James Le Cuirot (chewi)
Gentoo Linux Developer
pgpxN8QOz1six.pgp
Description: OpenPGP digital signature
Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies
On 03/01/2020 23:34, Michael 'veremitz' Everitt wrote:
On 03/01/20 10:36, David Seifert wrote:
On Thu, 2020-01-02 at 21:54 +, Michael 'veremitz' Everitt wrote:
On 02/01/20 21:08, Michał Górny wrote:
On Thu, 2020-01-02 at 21:15 +0100, Ulrich Mueller wrote:
On Thu, 02 Jan 2020, Michał Górny wrote:
--- a/eclass/ruby-ng.eclass
+++ b/eclass/ruby-ng.eclass
@@ -137,7 +137,7 @@ ruby_samelib() {
local res=
for _ruby_implementation in $(_ruby_get_all_impls); do
has -${_ruby_implementation} $@ || \
- res="${res}ruby_targets_${_ruby_impleme
ntation}?,"
+ res="${res}ruby_targets_${_ruby_impleme
ntation}(-)?,"
done
echo "[${res%,}]"
Hadn't we established that ruby_samelib() is dead code, no longer
used
since 2010?
You did. However, it isn't marked as private API and I'm not the
eclass
maintainer to take care of removing public API. I have no clue if
Ruby
project doesn't have some secret overlays using it.
You can't use QA super-powerz ?! BDFL + sub-BDFL ?!
*
* Thought the tags probably worth making explicit
Can you please stop polluting the -dev mailing list with this senseless
chatter?
Perhaps I should remind you that this is a public mailing list (or hasn't
successfully been censored Yet) and not a private communication channel for
developers (see -core for this). But I don't need to tell you this
Hi, at least a person is displeased with your attempt at humor, could
you please stop doing this? It does not add anything to the conversation
and it is unpleasant.
lu
PS: This counts as friendly warning.
Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies
On 03/01/20 10:36, David Seifert wrote:
> On Thu, 2020-01-02 at 21:54 +, Michael 'veremitz' Everitt wrote:
>> On 02/01/20 21:08, Michał Górny wrote:
>>> On Thu, 2020-01-02 at 21:15 +0100, Ulrich Mueller wrote:
> On Thu, 02 Jan 2020, Michał Górny wrote:
> --- a/eclass/ruby-ng.eclass
> +++ b/eclass/ruby-ng.eclass
> @@ -137,7 +137,7 @@ ruby_samelib() {
> local res=
> for _ruby_implementation in $(_ruby_get_all_impls); do
> has -${_ruby_implementation} $@ || \
> - res="${res}ruby_targets_${_ruby_impleme
> ntation}?,"
> + res="${res}ruby_targets_${_ruby_impleme
> ntation}(-)?,"
> done
>
> echo "[${res%,}]"
Hadn't we established that ruby_samelib() is dead code, no longer
used
since 2010?
>>> You did. However, it isn't marked as private API and I'm not the
>>> eclass
>>> maintainer to take care of removing public API. I have no clue if
>>> Ruby
>>> project doesn't have some secret overlays using it.
>>>
>> You can't use QA super-powerz ?! BDFL + sub-BDFL ?!
>> *
>>
>> * Thought the tags probably worth making explicit
>>
> Can you please stop polluting the -dev mailing list with this senseless
> chatter?
>
>
Perhaps I should remind you that this is a public mailing list (or hasn't
successfully been censored Yet) and not a private communication channel for
developers (see -core for this). But I don't need to tell you this
signature.asc
Description: OpenPGP digital signature
Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies
On Thu, 2020-01-02 at 21:54 +, Michael 'veremitz' Everitt wrote:
> On 02/01/20 21:08, Michał Górny wrote:
> > On Thu, 2020-01-02 at 21:15 +0100, Ulrich Mueller wrote:
> > > > > > > > On Thu, 02 Jan 2020, Michał Górny wrote:
> > > > --- a/eclass/ruby-ng.eclass
> > > > +++ b/eclass/ruby-ng.eclass
> > > > @@ -137,7 +137,7 @@ ruby_samelib() {
> > > > local res=
> > > > for _ruby_implementation in $(_ruby_get_all_impls); do
> > > > has -${_ruby_implementation} $@ || \
> > > > - res="${res}ruby_targets_${_ruby_impleme
> > > > ntation}?,"
> > > > + res="${res}ruby_targets_${_ruby_impleme
> > > > ntation}(-)?,"
> > > > done
> > > >
> > > > echo "[${res%,}]"
> > > Hadn't we established that ruby_samelib() is dead code, no longer
> > > used
> > > since 2010?
> > >
> > You did. However, it isn't marked as private API and I'm not the
> > eclass
> > maintainer to take care of removing public API. I have no clue if
> > Ruby
> > project doesn't have some secret overlays using it.
> >
> You can't use QA super-powerz ?! BDFL + sub-BDFL ?!
> *
>
> * Thought the tags probably worth making explicit
>
Can you please stop polluting the -dev mailing list with this senseless
chatter?
Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies
On 02/01/20 21:08, Michał Górny wrote:
> On Thu, 2020-01-02 at 21:15 +0100, Ulrich Mueller wrote:
>>> On Thu, 02 Jan 2020, Michał Górny wrote:
>>> --- a/eclass/ruby-ng.eclass
>>> +++ b/eclass/ruby-ng.eclass
>>> @@ -137,7 +137,7 @@ ruby_samelib() {
>>> local res=
>>> for _ruby_implementation in $(_ruby_get_all_impls); do
>>> has -${_ruby_implementation} $@ || \
>>> - res="${res}ruby_targets_${_ruby_implementation}?,"
>>> + res="${res}ruby_targets_${_ruby_implementation}(-)?,"
>>> done
>>>
>>> echo "[${res%,}]"
>> Hadn't we established that ruby_samelib() is dead code, no longer used
>> since 2010?
>>
> You did. However, it isn't marked as private API and I'm not the eclass
> maintainer to take care of removing public API. I have no clue if Ruby
> project doesn't have some secret overlays using it.
>
You can't use QA super-powerz ?! BDFL + sub-BDFL ?! *
* Thought the tags probably worth making explicit
signature.asc
Description: OpenPGP digital signature
Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies
On Thu, 2020-01-02 at 21:15 +0100, Ulrich Mueller wrote:
> > > > > > On Thu, 02 Jan 2020, Michał Górny wrote:
> > --- a/eclass/ruby-ng.eclass
> > +++ b/eclass/ruby-ng.eclass
> > @@ -137,7 +137,7 @@ ruby_samelib() {
> > local res=
> > for _ruby_implementation in $(_ruby_get_all_impls); do
> > has -${_ruby_implementation} $@ || \
> > - res="${res}ruby_targets_${_ruby_implementation}?,"
> > + res="${res}ruby_targets_${_ruby_implementation}(-)?,"
> > done
> >
> > echo "[${res%,}]"
>
> Hadn't we established that ruby_samelib() is dead code, no longer used
> since 2010?
>
You did. However, it isn't marked as private API and I'm not the eclass
maintainer to take care of removing public API. I have no clue if Ruby
project doesn't have some secret overlays using it.
--
Best regards,
Michał Górny
signature.asc
Description: This is a digitally signed message part
Re: [gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies
> On Thu, 02 Jan 2020, Michał Górny wrote:
> --- a/eclass/ruby-ng.eclass
> +++ b/eclass/ruby-ng.eclass
> @@ -137,7 +137,7 @@ ruby_samelib() {
> local res=
> for _ruby_implementation in $(_ruby_get_all_impls); do
> has -${_ruby_implementation} $@ || \
> - res="${res}ruby_targets_${_ruby_implementation}?,"
> + res="${res}ruby_targets_${_ruby_implementation}(-)?,"
> done
>
> echo "[${res%,}]"
Hadn't we established that ruby_samelib() is dead code, no longer used
since 2010?
Ulrich
signature.asc
Description: PGP signature
[gentoo-dev] [PATCH v2] ruby-ng.eclass: Include (-) in RUBY_TARGETS USE-dependencies
Using 2-style USE dependencies on packages not having the flag
in question is forbidden by PMS.
Signed-off-by: Michał Górny
---
eclass/ruby-ng.eclass | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/eclass/ruby-ng.eclass b/eclass/ruby-ng.eclass
index db701d81f4fc..85f464d9f30d 100644
--- a/eclass/ruby-ng.eclass
+++ b/eclass/ruby-ng.eclass
@@ -137,7 +137,7 @@ ruby_samelib() {
local res=
for _ruby_implementation in $(_ruby_get_all_impls); do
has -${_ruby_implementation} $@ || \
- res="${res}ruby_targets_${_ruby_implementation}?,"
+ res="${res}ruby_targets_${_ruby_implementation}(-)?,"
done
echo "[${res%,}]"
@@ -151,9 +151,9 @@ _ruby_atoms_samelib_generic() {
"||" | "(" | ")" | *"?")
echo "${token}" ;;
*])
- echo "${token%[*}[RUBYTARGET,${token/*[}" ;;
+ echo "${token%[*}[RUBYTARGET(-),${token/*[}" ;;
*)
- echo "${token}[RUBYTARGET]" ;;
+ echo "${token}[RUBYTARGET(-)]" ;;
esac
done
echo ")"
--
2.24.1
