Re: [gentoo-dev] [PATCH v2 4/4] dev-vcs/cli: new package

2020-02-18 Thread Robin H. Johnson 
On Wed, Feb 19, 2020 at 12:18:24AM -0600, William Hubbs wrote:
> > +RDEPEND+=">=dev-vcs/git-1.7.3"
> > +BDEPEND+=">=dev-lang/go-1.13"
> > +GOPATH="${WORKDIR}"
> You don't need += here 
I've taken to += as a cleaner variant than xDEPEND="${xDEPEND} cat/pn"
when the eclass MAY be setting some dependencies already.

> or any value of GOPATH.
GOPATH is required in fact!

Without it being set, it inherits GOPATH from my scope when I run emerge
or ebuild, and since the portage user doesn't have permission to write
in that path, the Golang mod tooling fails during src_unpack for the
tidy/get calls. If those are skipped, then it fails during the build.
The vendor mode didn't have this issue, because it handles differently.

I do note that this is despite what the Golang docs say about
GO111MODULE envvar being set should cause GOPATH to be ignored.

The other two packages, go-tour and kube-bench explicitly set GOPATH in
their builds, so didn't run into this.

-- 
Robin Hugh Johnson
Gentoo Linux: Dev, Infra Lead, Foundation Treasurer
E-Mail   : robb...@gentoo.org
GnuPG FP : 11ACBA4F 4778E3F6 E4EDF38E B27B944E 34884E85
GnuPG FP : 7D0B3CEB E9B85B1F 825BCECF EE05E6F6 A48F6136


signature.asc
Description: PGP signature

Re: [gentoo-dev] [PATCH v2 4/4] dev-vcs/cli: new package

2020-02-18 Thread William Hubbs 
On Mon, Feb 17, 2020 at 01:22:32AM -0800, Robin H. Johnson wrote:
> Package-Manager: Portage-2.3.84, Repoman-2.3.18
> Signed-off-by: Robin H. Johnson 
> ---
>  dev-vcs/cli/Manifest | 137 +++
>  dev-vcs/cli/cli-0.5.5.ebuild | 177 +++
>  dev-vcs/cli/metadata.xml |  11 +++
>  3 files changed, 325 insertions(+)
>  create mode 100644 dev-vcs/cli/Manifest
>  create mode 100644 dev-vcs/cli/cli-0.5.5.ebuild
>  create mode 100644 dev-vcs/cli/metadata.xml

*snip manifest*

> diff --git dev-vcs/cli/cli-0.5.5.ebuild dev-vcs/cli/cli-0.5.5.ebuild
> new file mode 100644
> index ..3892d656a46e
> --- /dev/null
> +++ dev-vcs/cli/cli-0.5.5.ebuild
> @@ -0,0 +1,177 @@
> +# Copyright 1999-2020 Gentoo Authors
> +# Distributed under the terms of the GNU General Public License v2
> +
> +EAPI=7
> +inherit bash-completion-r1 go-module
> +
> +EGO_SUM=(
> + "github.com/akavel/rsrc v0.8.0/go.mod 
> h1:uLoCtb9J+EyAqh+26kdrTgmzRBFPGOolLWKpdxkKq+c="
> + "github.com/AlecAivazis/survey/v2 v2.0.4/go.mod 
> h1:WYBhg6f0y/fNYUuesWQc0PKbJcEliGcYHB9sNT3Bg74="
> + "github.com/AlecAivazis/survey/v2 v2.0.4 
> h1:qzXnJSzXEvmUllWqMBWpZndvT2YfoAUzAMvZUax3L2M= license:MIT"
> + "github.com/alecthomas/assert v0.0.0-20170929043011-405dbfeb8e38/go.mod 
> h1:r7bzyVFMNntcxPZXK3/+KdruV1H5KSlyVY0gc+NgInI="
> + "github.com/alecthomas/assert v0.0.0-20170929043011-405dbfeb8e38 
> h1:smF2tmSOzy2Mm+0dGI2AIUHY+w0BUc+4tn40djz7+6U="
> + "github.com/alecthomas/chroma v0.6.8/go.mod 
> h1:o9ohftueRi7H5be3+Q2cQCNa/YnLBFUNx40ZJfGVFKA="
> + "github.com/alecthomas/chroma v0.6.8 
> h1:TW4JJaIdbAbMyUtGEd6BukFlOKYvVQz3vVhLBEUNwMU= license:MIT"
> + "github.com/alecthomas/colour v0.0.0-20160524082231-60882d9e2721/go.mod 
> h1:QO9JBoKquHd+jz9nshCh40fOfO+JzsoXy8qTHF68zU0="
> + "github.com/alecthomas/colour v0.0.0-20160524082231-60882d9e2721 
> h1:JHZL0hZKJ1VENNfmXvHbgYlbUOvpzYzvy2aZU5gXVeo="
> + "github.com/alecthomas/kong-hcl 
> v0.1.8-0.20190615233001-b21fea9723c8/go.mod 
> h1:MRgZdU3vrFd05IQ89AxUZ0aYdF39BYoNFa324SodPCA="
> + "github.com/alecthomas/kong 
> v0.1.17-0.20190424132513-439c674f7ae0/go.mod 
> h1:+inYUSluD+p4L8KdviBSgzcqEjUQOfC5fQDRFuc36lI="
> + "github.com/alecthomas/kong v0.2.1-0.20190708041108-0548c6b1afae/go.mod 
> h1:+inYUSluD+p4L8KdviBSgzcqEjUQOfC5fQDRFuc36lI="
> + "github.com/alecthomas/repr v0.0.0-20180818092828-117648cd9897/go.mod 
> h1:xTS7Pm1pD1mvyM075QCDSRqH6qRLXylzS24ZTpRiSzQ="
> + "github.com/alecthomas/repr v0.0.0-20180818092828-117648cd9897 
> h1:p9Sln00KOTlrYkxI1zYWl1QLnEqAqEARBEYa8FQnQcY="
> + "github.com/armon/consul-api v0.0.0-20180202201655-eb2c6b5be1b6/go.mod 
> h1:grANhF5doyWs3UAsr3K4I6qtAmlQcZDesFNEHPZAzj8="
> + "github.com/aybabtme/rgbterm v0.0.0-20170906152045-cc83f3b3ce59/go.mod 
> h1:q/89r3U2H7sSsE2t6Kca0lfwTK8JdoNGS/yzM/4iH5I= license:BSD-2,MIT"
> + "github.com/aybabtme/rgbterm v0.0.0-20170906152045-cc83f3b3ce59 
> h1:WWB576BN5zNSZc/M9d/10pqEx5VHNhaQ/yOVAkmj5Yo="
> + "github.com/BurntSushi/toml v0.3.1/go.mod 
> h1:xHWCNGjB5oqiDr8zfno3MHue2Ht5sIBksp03qcyfWMU="
> + "github.com/BurntSushi/toml v0.3.1 
> h1:WXkYYl6Yr3qBf1K79EBnL4mak0OimBfB0XUf9Vl28OQ="
> + "github.com/coreos/etcd v3.3.10+incompatible/go.mod 
> h1:uF7uidLiAD3TWHmW31ZFd/JWoc32PjwdhPthX9715RE="
> + "github.com/coreos/go-etcd v2.0.0+incompatible/go.mod 
> h1:Jez6KQU2B/sWsbdaef3ED8NzMklzPG4d5KIOhIy30Tk="
> + "github.com/coreos/go-semver v0.2.0/go.mod 
> h1:nnelYz7RCh+5ahJtPPxZlU+153eP4D4r3EedlOD2RNk="
> + "github.com/cpuguy83/go-md2man v1.0.10/go.mod 
> h1:SmD6nW6nTyfqj6ABTjUi3V3JVMnlJmwcJI5acqYI6dE="
> + "github.com/cpuguy83/go-md2man v1.0.10 
> h1:BSKMNlYxDvnunlTymqtgONjNnaRV1sTpcovwwjF22jk="
> + "github.com/daaku/go.zipexe v1.0.0/go.mod 
> h1:z8IiR6TsVLEYKwXAoE/I+8ys/sDkgTzSL0CLnGVd57E="
> + "github.com/danwakefield/fnmatch 
> v0.0.0-20160403171240-cbb64ac3d964/go.mod 
> h1:Xd9hchkHSWYkEqJwUGisez3G1QY8Ryz0sdWrLPMGjLk="
> + "github.com/danwakefield/fnmatch v0.0.0-20160403171240-cbb64ac3d964 
> h1:y5HC9v93H5EPKqaS1UYVg1uYah5Xf51mBfIoWehClUQ= license:BSD-2"
> + "github.com/davecgh/go-spew v1.1.0/go.mod 
> h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38="
> + "github.com/davecgh/go-spew v1.1.1/go.mod 
> h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38="
> + "github.com/davecgh/go-spew v1.1.1 
> h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c="
> + "github.com/dlclark/regexp2 v1.1.6/go.mod 
> h1:2pZnwuY/m+8K6iRw6wQdMtk+rH5tNGR1i55kozfMjCc="
> + "github.com/dlclark/regexp2 v1.1.6 
> h1:CqB4MjHw0MFCDj+PHHjiESmHX+N7t0tJzKvC6M97BRg= license:MIT"
> + "github.com/fsnotify/fsnotify v1.4.7/go.mod 
> h1:jwhsz4b93w/PPRr/qN1Yymfu8t87LnFCMoQvtojpjFo="
> + "github.com/GeertJohan/go.incremental v1.0.0/go.mod 
> h1:6fAjUhbVuX1KcMD3c8TEgVUqmo4seqhv0i0kdATSkM0="
> + "github.com/GeertJohan/go.rice v1.0.0/go.mod 
> h1:eH6gbSOAUv07dQuZVnBmoDP8mgsM1rtixis4Tib9if0="
> +

[gentoo-dev] [PATCH v2 4/4] dev-vcs/cli: new package

2020-02-17 Thread Robin H. Johnson 
Package-Manager: Portage-2.3.84, Repoman-2.3.18
Signed-off-by: Robin H. Johnson 
---
 dev-vcs/cli/Manifest | 137 +++
 dev-vcs/cli/cli-0.5.5.ebuild | 177 +++
 dev-vcs/cli/metadata.xml |  11 +++
 3 files changed, 325 insertions(+)
 create mode 100644 dev-vcs/cli/Manifest
 create mode 100644 dev-vcs/cli/cli-0.5.5.ebuild
 create mode 100644 dev-vcs/cli/metadata.xml

diff --git dev-vcs/cli/Manifest dev-vcs/cli/Manifest
new file mode 100644
index ..0ba851dcc439
--- /dev/null
+++ dev-vcs/cli/Manifest
@@ -0,0 +1,137 @@
+DIST cli-0.5.5.tar.gz 176434 BLAKE2B 
f08941c3b2a3ad9b8350b365eded3a51b337635b6a3cd18114cbe160ebc8636fd77ddbaf20b6b414011833d4387e8aa7c02803de5239bf0a5ef5d0a878052274
 SHA512 
c72c4a0db05fe08c7f132081bbb568b4653553cc65e90f3b686079623857b9307ec8f293e82860bae7a706bd496049543ab181a244618954f4435285b42bbaa9
+DIST github.com%2F!alec!aivazis%2Fsurvey%2Fv2%2F@v%2Fv2.0.4.mod 696 BLAKE2B 
09e376f63fd124401f3010db85b9b1cf25a0753cefef78e45db8d1c807b8154e2da473c25970d0bfafd8c813703f2695e7f7e47c05f87874d679ec6ec52bccee
 SHA512 
cb4258d68b43e7cf0e2389aba8dfd76e9c22803d54a8aaec05e70929af6146c4d4c1d9a0910b110e4e696577a29799496d519123813c65f2d7b1d50928bbf9bf
+DIST github.com%2F!alec!aivazis%2Fsurvey%2Fv2%2F@v%2Fv2.0.4.zip 86906 BLAKE2B 
13882476ffdb8765e73e154080e26aaa826beb3302984d40167a2a61d184e82cd03d59ee5e02cc020f742b27e7d37bfd8d36849442f68bf00b375966fb3cfe54
 SHA512 
a8fb1fab163666ea572de25a72223611fc7efd9bf62c368a2c9bf7313fc0a136d34220ad0f55af9c0d8a3c6388165fe4b59dbab32df66bbc1418c0096cfb8e96
+DIST github.com%2F!burnt!sushi%2Ftoml%2F@v%2Fv0.3.1.mod 34 BLAKE2B 
ce54a247aef91043830bdf0603c8452ba38eceb1495af6e7a74c9119234a0dc5cd080cb25258c28f5e270acf91189a5ed33e361cbf17de2be5e37dadbda1d90d
 SHA512 
320941bc3b7fb8bc595e6135cbc513a7583d129f0cd92508055291e141191066303cf75148e25198c21f6c6c539a790ea3210f3ecf5de6a2a03b70c753091146
+DIST github.com%2F!burnt!sushi%2Ftoml%2F@v%2Fv0.3.1.zip 56132 BLAKE2B 
5edcfe991d7fc40094d637bae8d8d6f1f897ab3d3786ade2bb80287738103264520681ced8d30d2037253206c32d3f867f4d024a571cb9aad030ebc451e198eb
 SHA512 
43ed64ae515738487e9b75a2290d0b2bc25e83c021a9f29b21487c37adbf34e74e1e7d3d5ec0dfe678c8396356f95c3993a5f5610d1791ff62056cd182a4272f
+DIST github.com%2F!geert!johan%2Fgo.incremental%2F@v%2Fv1.0.0.mod 53 BLAKE2B 
ed6781e3006723a251f94bf5f96aba2964e7926617255ddedfb932ba74fd3265fe28ec906b90f7f1956509f521dc2c29701fcc7301513eb1a1764d33e50c2c8b
 SHA512 
e46209635777bfc42c4399ff0eef13320a9b5d7a23dbe26f79da44a462b14941a949d812c586c023e3b4e617e741612ada3db8da7ae4e70ab242b8ffc123e880
+DIST github.com%2F!geert!johan%2Fgo.rice%2F@v%2Fv1.0.0.mod 349 BLAKE2B 
c25e546d66f5bb4679a66949169f3a4568602a7b6f8ac1386bfa7993704d79821c07d4f0931cc2779fb862b73465ed41d0f050f59149bc39dfa1602ea706f207
 SHA512 
51a8db67904d3f632dfad620e223c7b59efe42d8254bd4e0ef49ef1a40759e1dbe4558f87209059841b80e0ccda5130cabef7c869a399eff3786d4b4d8d3a747
+DIST 
github.com%2F!netflix%2Fgo-expect%2F@v%2Fv0.0.0-20180615182759-c93bf25de8e8.mod 
36 BLAKE2B 
94171fec75b4e45d40bf820417400401971e3f18eb68588d15466e709097607b89ba18c8d8b6d2d658e4f718ab0662cc605c76c955464d9e6d45609945f5
 SHA512 
a1e0fa80fdf59962a05f1f6b1232c17f301010ada93a8628a89ea187de325c75f7d85359306c613371552671ffef2e513938e2d2ff57731dd2b226a54f87049d
+DIST 
github.com%2F!netflix%2Fgo-expect%2F@v%2Fv0.0.0-20180615182759-c93bf25de8e8.zip 
15018 BLAKE2B 
d088594870f9c9fd66237fa8647ba6274aea5a88d8bb09d887b1371b48fb12ee392e58f170d35ace95f07dd1faaeb63a53097efe01568a7f1f122a741ff97b9e
 SHA512 
3af54d66425f653f591bd08950305c2aed00ab570321c159e67469f88d47d39d2bba267513645f3a6823fca05fd86a4cbc38fcfeee674a32d2419be6d073747b
+DIST github.com%2Fakavel%2Frsrc%2F@v%2Fv0.8.0.mod 39 BLAKE2B 
040b84d78188cff54576ac29dc39bcb557c56bcbcdbf6767a3321163859ae29dddca6e8b3294490238eaca9da7281e6b48ebcc6045a38c5f31795d0a831103f1
 SHA512 
4d33264b51c07e85a857699f5dc7b1b8a45cf1a330d8bc333525cd22513c4aaa9ddb44530e2f3e47192b21c72ddbffe465c31672a4bb441b863d90020a631a4e
+DIST 
github.com%2Falecthomas%2Fassert%2F@v%2Fv0.0.0-20170929043011-405dbfeb8e38.mod 
36 BLAKE2B 
d0745757255951a92d471fdb1eeaae2e118d367caf0fcea00a405536d7e30609f22276e7a453aac1ca38063635df798a0843f279c178d394a7cbef9c9f9b3c27
 SHA512 
87ff97fea3e25aa903503e56fe5afc337918f7253dd7175833adb144a7296451a7d4ebd76df504737a5b4c5237b1102920728d21a587957d5d25db5d38e1217b
+DIST 
github.com%2Falecthomas%2Fassert%2F@v%2Fv0.0.0-20170929043011-405dbfeb8e38.zip 
73310 BLAKE2B 
b0aaa346be477c14bd504f98219659c8a82ba08afdd94f1a5ffbb44cfcb6cc9b014c1ee35aec6071d4733134931e6d2a569940e9f1f06a5e69b00f56d82579e9
 SHA512 
adf9a3b8bda92edd028f497ca10648900a7aac4dae9372469b511afc74e79f8b990e448f375ab2a8df651a491bab5413196c06db531adc10358865f74de6f26b
+DIST github.com%2Falecthomas%2Fchroma%2F@v%2Fv0.6.8.mod 1007 BLAKE2B 
d4dbb49627120ce1fe3e78e5b04c5f69fad25c2c1b98ee2fd313f6252537c3506541cfd1abdee7648f01b85eebe238fcef65a12c46ffdfacc9624e22f5bde687
 SHA512