Re: [gentoo-dev] [PATCH v4] mount-boot.eclass: Check if /boot is sane, but don't try to mount it.

2019-12-10 Thread Ulrich Mueller
> On Sat, 07 Dec 2019, Ulrich Müller wrote: > The eclass failed to remount a read-only mounted /boot, because package > collision sanity checks in recent Portage versions prevented it from > reaching pkg_preinst() at all. Furthermore, with the "mount-sandbox" > feature enabled, the mount won't

Re: [gentoo-dev] [PATCH v4] mount-boot.eclass: Check if /boot is sane, but don't try to mount it.

2019-12-09 Thread Jaco Kroon
Hi, >> What about just checking "${EROOT}/boot" instead? > For what, existence? There may well be a "boot" directory present under > EROOT. (And we could check ${EROOT}/etc/fstab, but I don't think we > should open that can of worms. There's no reliable way to guess the > user's exact configuratio

Re: [gentoo-dev] [PATCH v4] mount-boot.eclass: Check if /boot is sane, but don't try to mount it.

2019-12-09 Thread Ulrich Mueller
> On Mon, 09 Dec 2019, Jaco Kroon wrote: > Acked-by: Jaco Kroon OK, I can add this. >> +    if [[ ${EROOT:-/} != / ]] ; then >>          return 0 >>      fi > I don't use spaces in path names ... but what happens here if ROOT or > EPREFIX (and by implication EROOT) contains a space? No pr

Re: [gentoo-dev] [PATCH v4] mount-boot.eclass: Check if /boot is sane, but don't try to mount it.

2019-12-09 Thread Jaco Kroon
Hi Ulrich, I'm happy with this "as is", but there may be a few improvements still. By the way:  This improves the situation for mounted ro /boot by moving the check from preinst to pretend. For noauto /boot (I believe the default and recommended) this fixes things. This is the reason I decided

Re: [gentoo-dev] [PATCH v4] mount-boot.eclass: Check if /boot is sane, but don't try to mount it.

2019-12-07 Thread Ulrich Mueller
> On Sat, 07 Dec 2019, Thomas Deutschmann wrote: > just wondering if you have seen https://bugs.gentoo.org/532264#c24. > If this is still valid, is your change really needed? I have. IIUC it is a special case for one ebuild and cannot be generalised. Ulrich signature.asc Description: PGP s

Re: [gentoo-dev] [PATCH v4] mount-boot.eclass: Check if /boot is sane, but don't try to mount it.

2019-12-07 Thread Thomas Deutschmann
Hi, just wondering if you have seen https://bugs.gentoo.org/532264#c24. If this is still valid, is your change really needed? -- Regards, Thomas Deutschmann / Gentoo Linux Developer C4DD 695F A713 8F24 2AA1 5638 5849 7EE5 1D5D 74A5 signature.asc Description: OpenPGP digital signature

[gentoo-dev] [PATCH v4] mount-boot.eclass: Check if /boot is sane, but don't try to mount it.

2019-12-07 Thread Ulrich Müller
The eclass failed to remount a read-only mounted /boot, because package collision sanity checks in recent Portage versions prevented it from reaching pkg_preinst() at all. Furthermore, with the "mount-sandbox" feature enabled, the mount won't be propagated past pkg_preinst() and installed files wou