Re: [gentoo-dev] [PATCHES] python-r1 suite: minor fixes

2017-06-06 Thread Michał Górny
On sob, 2017-05-20 at 10:56 +0200, Michał Górny wrote:
> Hi,
> 
> Here's a quick set of minor patches to python-r1 suite. It mostly
> includes some fixes to issues I've noticed while working on something
> bigger ;-).
> 
> The first patch merely fixes missing 'local' for a variable. The second
> adds REQUIRED_USE to the python_setup() use example in python-r1.
> The third converts distutils-r1 common impl support to use the new
> pattern matching function (which is an omission from the original set
> of patches).
> 
> The fourth patch is most interesting of all -- it makes the pattern
> matching work well with mismatched PYTHON_COMPAT/EPYTHON-style impls.
> This makes the API more lax, and avoids requiring users to be aware
> of technically implied impl style restrictions, i.e. having to write:
> 
>   REQUIRED_USE="doc? ( || ( $(python_gen_useflags 'python2_*') ) )"
> 
>   src_compile() {
> use doc && python_setup 'python2.*'
>   }
> 
> Note that flags used PYTHON_COMPAT form (with '_') while setup functions
> used EPYTHON form (with '.'). Now both are equally happy with both
> forms.
> 

Merged them a while back.

-- 
Best regards,
Michał Górny


signature.asc
Description: This is a digitally signed message part


[gentoo-dev] [PATCHES] python-r1 suite: minor fixes

2017-05-20 Thread Michał Górny
Hi,

Here's a quick set of minor patches to python-r1 suite. It mostly
includes some fixes to issues I've noticed while working on something
bigger ;-).

The first patch merely fixes missing 'local' for a variable. The second
adds REQUIRED_USE to the python_setup() use example in python-r1.
The third converts distutils-r1 common impl support to use the new
pattern matching function (which is an omission from the original set
of patches).

The fourth patch is most interesting of all -- it makes the pattern
matching work well with mismatched PYTHON_COMPAT/EPYTHON-style impls.
This makes the API more lax, and avoids requiring users to be aware
of technically implied impl style restrictions, i.e. having to write:

  REQUIRED_USE="doc? ( || ( $(python_gen_useflags 'python2_*') ) )"

  src_compile() {
use doc && python_setup 'python2.*'
  }

Note that flags used PYTHON_COMPAT form (with '_') while setup functions
used EPYTHON form (with '.'). Now both are equally happy with both
forms.

--
Best regards,
Michał Górny