Re: [gentoo-dev] [RFC] Establishing Gentoo patch policy to keep our patches consistent and clean

2013-04-09 Thread Donnie Berkholz
On 23:41 Sat 06 Apr , Michał Górny wrote: Optionally, after the last paragraph you can add a few lines with tags in form of 'Tag: value'. AFAICS git itself uses only 'Signed-off-by' but you can find more tags in various 'submitting patches' docs. 'Signed-off-by' lists the one

Re: [gentoo-dev] [RFC] Establishing Gentoo patch policy to keep our patches consistent and clean

2013-04-07 Thread Kacper Kowalik
On 06.04.2013 20:08, Michał Górny wrote: Hello, As far as I'm aware, we don't really have much of a patch maintenance policy in Gentoo. There a few loose rules like «don't put awfully big files into FILESDIR» or the common sense «use unified diff», but no complete and clear policy.

[gentoo-dev] [RFC] Establishing Gentoo patch policy to keep our patches consistent and clean

2013-04-06 Thread Michał Górny
Hello, As far as I'm aware, we don't really have much of a patch maintenance policy in Gentoo. There a few loose rules like «don't put awfully big files into FILESDIR» or the common sense «use unified diff», but no complete and clear policy. Especially considering the late discussion related to

Re: [gentoo-dev] [RFC] Establishing Gentoo patch policy to keep our patches consistent and clean

2013-04-06 Thread Tony Chainsaw Vroon
On Sat, 2013-04-06 at 20:08 +0200, Michał Górny wrote: What are your thoughts? Sensible document. Can we have it on the agenda for the council meeting please. It looks suitable for a yes/no vote, and I expect some guidance from the wider developer community in how they respond on the list.

Re: [gentoo-dev] [RFC] Establishing Gentoo patch policy to keep our patches consistent and clean

2013-04-06 Thread Markos Chandras
On 6 April 2013 19:08, Michał Górny mgo...@gentoo.org wrote: Hello, ... What are your thoughts? Maybe it is time to setup a patch tracking system like Debian[1]? Sometimes it is really hard to understand what patches are applied by an ebuild (especially when all the build process is handled

Re: [gentoo-dev] [RFC] Establishing Gentoo patch policy to keep our patches consistent and clean

2013-04-06 Thread Alexandre Rostovtsev
On Sat, 2013-04-06 at 20:08 +0200, Michał Górny wrote: 2. Patches have to apply to the top directory of the source tree with 'patch -p1'. If patches are applied to sub-directories, necessary '-p' argument shall be passed to 'epatch' explicitly. Developers are encouraged to create patches which

Re: [gentoo-dev] [RFC] Establishing Gentoo patch policy to keep our patches consistent and clean

2013-04-06 Thread Michał Górny
On Sat, 06 Apr 2013 14:35:47 -0400 Alexandre Rostovtsev tetrom...@gentoo.org wrote: On Sat, 2013-04-06 at 20:08 +0200, Michał Górny wrote: 2. Patches have to apply to the top directory of the source tree with 'patch -p1'. If patches are applied to sub-directories, necessary '-p' argument

Re: [gentoo-dev] [RFC] Establishing Gentoo patch policy to keep our patches consistent and clean

2013-04-06 Thread Michael Mol
On Apr 6, 2013 2:36 PM, Alexandre Rostovtsev tetrom...@gentoo.org wrote: On Sat, 2013-04-06 at 20:08 +0200, Michał Górny wrote: 2. Patches have to apply to the top directory of the source tree with 'patch -p1'. If patches are applied to sub-directories, necessary '-p' argument shall be

Re: [gentoo-dev] [RFC] Establishing Gentoo patch policy to keep our patches consistent and clean

2013-04-06 Thread Paweł Hajdan, Jr.
On 4/6/13 11:08 AM, Michał Górny wrote: 1. Patches have to be either in unified or context diff format. Unified diff is preferred. Are there any other formats than unified and context diff? If not, it'd be like another for indoor or outdoor use only or home or office use - i.e. no need to

Re: [gentoo-dev] [RFC] Establishing Gentoo patch policy to keep our patches consistent and clean

2013-04-06 Thread Alex Xu
On 06/04/13 03:02 PM, Paweł Hajdan, Jr. wrote: Are there any other formats than unified and context diff? If not, it'd be like another for indoor or outdoor use only or home or office use - i.e. no need to explicitly list all possible options. From the man page: -c, -C NUM, --context[=NUM]

Re: [gentoo-dev] [RFC] Establishing Gentoo patch policy to keep our patches consistent and clean

2013-04-06 Thread Michał Górny
On Sat, 06 Apr 2013 12:02:28 -0700 Paweł Hajdan, Jr. phajdan...@gentoo.org wrote: On 4/6/13 11:08 AM, Michał Górny wrote: 5. The patch name shall shortly summarize the changes done by it. Common sense again. :) And I agree that patches should do that, the question is just whether we put

Re: [gentoo-dev] [RFC] Establishing Gentoo patch policy to keep our patches consistent and clean

2013-04-06 Thread Paweł Hajdan, Jr.
On 4/6/13 12:41 PM, Michał Górny wrote: 6. Patch files shall start with a brief description of what the patch does. Developers are encouraged to use git-style tags like 'Fixes:' to point to the relevant bug URIs. That could be helpful - could this be made more precise though? Is there any

Re: [gentoo-dev] [RFC] Establishing Gentoo patch policy to keep our patches consistent and clean

2013-04-06 Thread Robin H. Johnson
On Sat, Apr 06, 2013 at 08:08:43PM +0200, Michał Górny wrote: The above-listed policy will apply to the patches kept in the gx86 tree (in FILESDIRs) and patch archives created by Gentoo developers. They will not apply to the patch archives created upstream. What about patches created by

Re: [gentoo-dev] [RFC] Establishing Gentoo patch policy to keep our patches consistent and clean

2013-04-06 Thread Michał Górny
On Sat, 06 Apr 2013 13:00:35 -0700 Paweł Hajdan, Jr. phajdan...@gentoo.org wrote: On 4/6/13 12:41 PM, Michał Górny wrote: I would honestly just go for the git style. It's the first thing that really succeeded in standardizing patches. Inventing something new is not really necessary, I