Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

2008-03-18 Thread Rémi Cardona
Petteri Räty a écrit : http://archives.gentoo.org/gentoo-dev/msg_a57bf5f459324975bae8843fe7cdf469.xml Sorry I didn't respond to you Petteri, but this is clearly missing packages. For sure, it's missing gnome-games which inherits both the gnome2 and the games eclasses. So I made the

Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

2008-03-18 Thread Rémi Cardona
Bo Ørsted Andresen a écrit : On Tuesday 18 March 2008 00:42:02 Gilles Dartiguelongue wrote: Now, basically, if the portage metadata or QA people could tell me a way to figure *all* the ebuilds that inherit gnome2 *and* have a pkg_preinst() function somewhere (either in the ebuild or in an

Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

2008-03-18 Thread Dawid Węgliński
Tuesday, 18 of March 2008 07:43:35 Rémi Cardona wrote: Bo Ørsted Andresen a écrit : On Tuesday 18 March 2008 00:42:02 Gilles Dartiguelongue wrote: Now, basically, if the portage metadata or QA people could tell me a way to figure *all* the ebuilds that inherit gnome2 *and* have a

Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

2008-03-18 Thread Petteri Räty
Rémi Cardona kirjoitti: Petteri Räty a écrit : http://archives.gentoo.org/gentoo-dev/msg_a57bf5f459324975bae8843fe7cdf469.xml Sorry I didn't respond to you Petteri, but this is clearly missing packages. For sure, it's missing gnome-games which inherits both the gnome2 and the games

Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

2008-03-17 Thread Rémi Cardona
Hi again, I've just come up with a plan for the new eclass based on previous feedback. Basically, I want to commit this patch [1] ASAP. If I commit this right now here's what's going to happen : - ebuilds that use the gnome2 eclass and other eclasses that don't export pkg_preinst() will be

Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

2008-03-17 Thread Nirbheek Chauhan
On Mon, Mar 17, 2008 at 10:02 PM, Rémi Cardona [EMAIL PROTECTED] wrote: [snip] [1] The Patch (tm) --- gnome2.eclass 10 Feb 2008 14:47:14 - 1.83 +++ gnome2.eclass 17 Mar 2008 16:30:31 - @@ -106,6 +106,9 @@ rm -fr ${D}/usr/share/applications/mimeinfo.cache

Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

2008-03-17 Thread Rémi Cardona
Nirbheek Chauhan a écrit : Shouldn't this function be gnome2_pkg_preinst() { : } ? Because bash chokes on empty functions.. I was actually planning on using a bogus debug-print statement :) but thanks for letting me know. Rémi -- gentoo-dev@lists.gentoo.org mailing list

Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

2008-03-17 Thread Gilles Dartiguelongue
Le lundi 17 mars 2008 à 17:32 +0100, Rémi Cardona a écrit : [snip] Now, basically, if the portage metadata or QA people could tell me a way to figure *all* the ebuilds that inherit gnome2 *and* have a pkg_preinst() function somewhere (either in the ebuild or in an eclass somewhere) I'd

Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

2008-03-17 Thread Petteri Räty
Rémi Cardona kirjoitti: Now, basically, if the portage metadata or QA people could tell me a way to figure *all* the ebuilds that inherit gnome2 *and* have a pkg_preinst() function somewhere (either in the ebuild or in an eclass somewhere) I'd really appreciate it, as I really don't want to

Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

2008-03-17 Thread Bo Ørsted Andresen
On Tuesday 18 March 2008 00:42:02 Gilles Dartiguelongue wrote: Now, basically, if the portage metadata or QA people could tell me a way to figure *all* the ebuilds that inherit gnome2 *and* have a pkg_preinst() function somewhere (either in the ebuild or in an eclass somewhere) I'd really

[gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

2008-03-14 Thread Rémi Cardona
Hi folks, During the past few weeks, I've been working on fixing and improving the Gnome2 eclasses wrt bug #155993. We plan on pushing these eclasses to portage before the Great Gnome 2.22 Unmask so that users can start benefiting from the improvements during the upgrade to 2.22. URL :

Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

2008-03-14 Thread Denis Dupeyron
On Fri, Mar 14, 2008 at 8:14 AM, Rémi Cardona [EMAIL PROTECTED] wrote: - the gnome2 eclass now has a pkg_preinst, if you do multiple inherits, make sure that gnome2_pkg_preinst is called too. The _games_eclass_ is one of those. [...] *Please* review these eclasses because with a simple

Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

2008-03-14 Thread Rémi Cardona
Denis Dupeyron a écrit : On Fri, Mar 14, 2008 at 8:14 AM, Rémi Cardona [EMAIL PROTECTED] wrote: - the gnome2 eclass now has a pkg_preinst, if you do multiple inherits, make sure that gnome2_pkg_preinst is called too. The _games_eclass_ is one of those. [...] *Please* review these

Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

2008-03-14 Thread Denis Dupeyron
On Fri, Mar 14, 2008 at 11:21 AM, Rémi Cardona [EMAIL PROTECTED] wrote: If you remove from that list vlc, pidgin and celestia which are false positives, that leaves us: Why are they false positives? They include the gnome2 eclass and other stuff, I guess they'll be affected too.

Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

2008-03-14 Thread David Leverton
On Friday 14 March 2008 07:14:23 Rémi Cardona wrote: - the gnome2 eclass now has a pkg_preinst, if you do multiple inherits, make sure that gnome2_pkg_preinst is called too. The _games_eclass_ is one of those. Maybe worth adding a dummy to the current version of the eclass so that ebuilds

Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

2008-03-14 Thread Petteri Räty
David Leverton kirjoitti: On Friday 14 March 2008 07:14:23 Rémi Cardona wrote: - the gnome2 eclass now has a pkg_preinst, if you do multiple inherits, make sure that gnome2_pkg_preinst is called too. The _games_eclass_ is one of those. Maybe worth adding a dummy to the current version of

Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

2008-03-14 Thread Petteri Räty
Rémi Cardona kirjoitti: This is where I kindly request the help of fellow Gentoo devs and PM developers : - the gnome2 eclass now has a pkg_preinst, if you do multiple inherits, make sure that gnome2_pkg_preinst is called too. The _games_eclass_ is one of those. I only found two ebuilds

Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

2008-03-14 Thread David Leverton
On Friday 14 March 2008 12:14:39 Petteri Räty wrote: David Leverton kirjoitti: Maybe worth adding a dummy to the current version of the eclass so that ebuilds can be updated now, instead of suddenly all at once as soon as the new eclass is committed? And break a bunch of ebuilds to stable

Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

2008-03-14 Thread Rémi Cardona
David Leverton a écrit : On Friday 14 March 2008 07:14:23 Rémi Cardona wrote: - the gnome2 eclass now has a pkg_preinst, if you do multiple inherits, make sure that gnome2_pkg_preinst is called too. The _games_eclass_ is one of those. Maybe worth adding a dummy to the current version of the

Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

2008-03-14 Thread Petteri Räty
David Leverton kirjoitti: On Friday 14 March 2008 12:14:39 Petteri Räty wrote: David Leverton kirjoitti: Maybe worth adding a dummy to the current version of the eclass so that ebuilds can be updated now, instead of suddenly all at once as soon as the new eclass is committed? And break a

Re: [gentoo-dev] [RFC] Major changes to the Gnome2 Eclasses

2008-03-14 Thread David Leverton
On Friday 14 March 2008 12:20:15 Rémi Cardona wrote: David Leverton a écrit : Maybe worth adding a dummy to the current version of the eclass so that ebuilds can be updated now, instead of suddenly all at once as soon as the new eclass is committed? Good idea, I'll see what I can do