Re: [gentoo-dev] [WTH] bash-completion useflag
On Thu, 1 Sep 2011 00:16:29 +0200 Ulrich Mueller wrote: > > On Wed, 31 Aug 2011, Mike Frysinger wrote: > > > installing the files unconditionally does fall into the > > logrotate/xinetd category, so it should get punted. but people > > should not end up with the depends installed all the time. > > The eclass currently has RDEPEND=app-admin/eselect and > PDEPEND=app-shells/bash-completion. I believe that the former is > not necessary, because eselect will already be pulled in by the > bash-completion package. > > And users who want bash completion can just install > app-shells/bash-completion, so maybe PDEPEND could be removed too? Or maybe it should be added somehow to the bash ebuild? Maybe a conditional there. -- Best regards, Michał Górny signature.asc Description: PGP signature
Re: [gentoo-dev] [WTH] bash-completion useflag
On Wednesday, August 31, 2011 18:16:29 Ulrich Mueller wrote: > > On Wed, 31 Aug 2011, Mike Frysinger wrote: > > installing the files unconditionally does fall into the > > logrotate/xinetd category, so it should get punted. but people > > should not end up with the depends installed all the time. > > And users who want bash completion can just install > app-shells/bash-completion, so maybe PDEPEND could be removed too? i think that'd be the equivalent to the current "users add bash-completion to their USE in make.conf", so i'd say yes that'd also solve Michał's logging complaint by putting generic instructions into the bash-completion ebuild postinst ? -mike signature.asc Description: This is a digitally signed message part.
Re: [gentoo-dev] [WTH] bash-completion useflag
> On Wed, 31 Aug 2011, Mike Frysinger wrote: > installing the files unconditionally does fall into the > logrotate/xinetd category, so it should get punted. but people > should not end up with the depends installed all the time. The eclass currently has RDEPEND=app-admin/eselect and PDEPEND=app-shells/bash-completion. I believe that the former is not necessary, because eselect will already be pulled in by the bash-completion package. And users who want bash completion can just install app-shells/bash-completion, so maybe PDEPEND could be removed too? Ulrich
Re: [gentoo-dev] [WTH] bash-completion useflag
On Wed, 31 Aug 2011 22:14:08 +0200 Tomáš Chvátal wrote: > Hi, > what is the purpose of this fancy useflag, it controlls install of at > best one or more small sh scripts. > As we do not bother with the logrotate useflag this thing should fall > into the same category. > > It is mostly added by the eclass for the feature. Which I for example > didn't notice and forced > newuse update for all poor souls using libreoffice... Ok, from a quick tree grep: there are lots of packages which will probably need to be changed. Before we will start fixing them, we need to decide how we should exactly do it. If we're going not to use bash-completion flag by default, we should probably remove pkg_postinst() from there as well. Honestly, I don't see a reason for each package to list how to enable bash-completion. If we do that, we will finally end up outputting complete instructions on every installed file. -- Best regards, Michał Górny signature.asc Description: PGP signature
Re: [gentoo-dev] [WTH] bash-completion useflag
On Wednesday, August 31, 2011 16:22:28 Michał Górny wrote: > On Wed, 31 Aug 2011 22:14:08 +0200 Tomáš Chvátal wrote: > > what is the purpose of this fancy useflag, it controlls install of at > > best one or more small sh scripts. > > As we do not bother with the logrotate useflag this thing should fall > > into the same category. > > > > It is mostly added by the eclass for the feature. Which I for example > > didn't notice and forced > > newuse update for all poor souls using libreoffice... > > I already suggested removing it at least twice. > > One issue is that a few packages use it for PDEPs. But I guess making > the eclass non-conditional by default would be a good start. installing the files unconditionally does fall into the logrotate/xinetd category, so it should get punted. but people should not end up with the depends installed all the time. -mike signature.asc Description: This is a digitally signed message part.
Re: [gentoo-dev] [WTH] bash-completion useflag
On Wed, 31 Aug 2011 22:14:08 +0200 Tomáš Chvátal wrote: > what is the purpose of this fancy useflag, it controlls install of at > best one or more small sh scripts. > As we do not bother with the logrotate useflag this thing should fall > into the same category. > > It is mostly added by the eclass for the feature. Which I for example > didn't notice and forced > newuse update for all poor souls using libreoffice... I already suggested removing it at least twice. One issue is that a few packages use it for PDEPs. But I guess making the eclass non-conditional by default would be a good start. -- Best regards, Michał Górny signature.asc Description: PGP signature
[gentoo-dev] [WTH] bash-completion useflag
Hi, what is the purpose of this fancy useflag, it controlls install of at best one or more small sh scripts. As we do not bother with the logrotate useflag this thing should fall into the same category. It is mostly added by the eclass for the feature. Which I for example didn't notice and forced newuse update for all poor souls using libreoffice... Cheers Tom signature.asc Description: OpenPGP digital signature
