[gentoo-dev] Re: Making dobin, doexe, doins, doman, dodoc die by default
This came up in Bug 138792 [dobin etc. should automatically die on failure] It needs more discussion on the mailing lists. Some excerpts from the bug: The proposal from Paul Bredbury: Hi, I propose that the following ebuild commands themselves *die* on failure, because the vast majority of the time the emerge might as well be considered a failure if such commands fail. dobin, dosbin, doexe So what do you think? Since it does not seem to be too popular, to let dobin, etc. die, i would suggest writing a big fat red QA: command 'dobin xyz' failed on the screen, so that even the last user notices that. Perhaps also writing those QA-warnings to emerge.log? Is that aready done at the moment? If not, i would suggest that - and actually i would rather like that dobin, etc. die on error. Well, but some people here claim, that the ebuilds are not tested that much, before they go into portage. Well, that's another decision: what should gentoo's quality be like? signature.asc Description: OpenPGP digital signature
Re: [gentoo-dev] Re: Making dobin, doexe, doins, doman, dodoc die by default
On Tue, 2006-07-18 at 20:49 +0200, Sven Köhler wrote: Well, but some people here claim, that the ebuilds are not tested that much, before they go into portage. Well, that's another decision: what should gentoo's quality be like? Actually, it was more a discussion of older ebuilds. If I put an ebuild into the tree today, using one of the eclasses that uses lots of do* stuff and relies on it not being an error condition today, then the change is made at a later date, how am I going to know that my ebuild suddenly broke? As you can guess, the answer is when you get a bug report which definitely isn't the optimal answer. I'm refraining from the quality discussion simply because we're pretty well aware that we have two pretty distant camps within Gentoo these days and I'd prefer not start another of the stable vs. ricer threads while I'm busy working on release stuff... :P -- Chris Gianelloni Release Engineering - Strategic Lead x86 Architecture Team Games - Developer Gentoo Linux signature.asc Description: This is a digitally signed message part
[gentoo-dev] Re: Making dobin, doexe, doins, doman, dodoc die by default
Aron Griffis wrote:
Stefan Schweizer wrote: [Wed Jul 12 2006, 01:37:44PM EDT]
This came up in Bug 138792 [dobin etc. should automatically die on
failure]
Since do* would become functions in this case, you'll have to fix the
few ebuilds that use them on the RHS of xargs.
grep -r --include \*.ebuild -E 'xargs do(bin|exe|ins|man|doc)' .
./local/layman/hanno-xgl/media-libs/mesa/mesa-6.5.1_pre20060620.ebuild: find
${S}/lib* -name '*_dri.so' | xargs doexe
./local/layman/hanno-xgl/media-libs/mesa/mesa-6.5.1_pre20060627.ebuild: find
${S}/lib* -name '*_dri.so' | xargs doexe
./media-libs/mesa/mesa-6.5-r3.ebuild: find ${S}/lib* -name '*_dri.so' |
xargs doexe
./media-libs/mesa/mesa-6.4.2-r2.ebuild: find ${S}/lib* -name '*_dri.so' |
xargs doexe
./app-emulation/vmware-gsx-console/vmware-gsx-console-3.2.0.14497.ebuild:
find man -name \*.\?.gz | xargs doman
Assuming the list is relatively short, it should be acceptable to
convert these to something like:
doman $(find man -name '*.?.gz')
I just pinged MattM about vmware-gsx-console, and the x11 guys about mesa
and some minutes ago fixed timidity-eawpatches and speedtouch.
Thanks :)
- Stefan
--
gentoo-dev@gentoo.org mailing list
