Re: [gentoo-dev] Adding ABI_MIPS USE_EXPAND

2013-07-31 Thread Jeroen Roovers
On Tue, 30 Jul 2013 09:04:56 -0700
Matt Turner matts...@gentoo.org wrote:

 I committed it last night before your email.

# Keep it sorted. Please do not add anything without prior
discussion # on
gentoo-dev.
n32
n64
o32

This is not a valid format for a .desc file. You should use:

flag - description


 jer



Re: [gentoo-dev] Adding ABI_MIPS USE_EXPAND

2013-07-31 Thread Matt Turner
On Wed, Jul 31, 2013 at 5:12 AM, Jeroen Roovers j...@gentoo.org wrote:
 On Tue, 30 Jul 2013 09:04:56 -0700
 Matt Turner matts...@gentoo.org wrote:

 I committed it last night before your email.

 # Keep it sorted. Please do not add anything without prior
 discussion # on
 gentoo-dev.
 n32
 n64
 o32

 This is not a valid format for a .desc file. You should use:

 flag - description

Indeed, you are right. I'll add descriptions.

Thanks for noticing.
Matt



Re: [gentoo-dev] Adding ABI_MIPS USE_EXPAND

2013-07-30 Thread Michał Górny
Dnia 2013-07-29, o godz. 17:21:15
Matt Turner matts...@gentoo.org napisał(a):

 Any objections to me adding an ABI_MIPS USE_EXPAND variable so that I
 can take advantage of the multilib work on mips?

But please sent the patches for a quick review first.

-- 
Best regards,
Michał Górny


signature.asc
Description: PGP signature


Re: [gentoo-dev] Adding ABI_MIPS USE_EXPAND

2013-07-30 Thread Matt Turner
On Tue, Jul 30, 2013 at 12:44 AM, Michał Górny mgo...@gentoo.org wrote:
 Dnia 2013-07-29, o godz. 17:21:15
 Matt Turner matts...@gentoo.org napisał(a):

 Any objections to me adding an ABI_MIPS USE_EXPAND variable so that I
 can take advantage of the multilib work on mips?

 But please sent the patches for a quick review first.

Sorry, I committed it last night before your email.

Here's the diff of the eclass:
http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/multilib-build.eclass?r1=1.16r2=1.17

I did ask you twice on IRC over the last few days and never received a response.



Re: [gentoo-dev] Adding ABI_MIPS USE_EXPAND

2013-07-30 Thread Michał Górny
Dnia 2013-07-30, o godz. 09:04:56
Matt Turner matts...@gentoo.org napisał(a):

 On Tue, Jul 30, 2013 at 12:44 AM, Michał Górny mgo...@gentoo.org wrote:
  Dnia 2013-07-29, o godz. 17:21:15
  Matt Turner matts...@gentoo.org napisał(a):
 
  Any objections to me adding an ABI_MIPS USE_EXPAND variable so that I
  can take advantage of the multilib work on mips?
 
  But please sent the patches for a quick review first.
 
 Sorry, I committed it last night before your email.
 
 Here's the diff of the eclass:
 http://sources.gentoo.org/cgi-bin/viewvc.cgi/gentoo-x86/eclass/multilib-build.eclass?r1=1.16r2=1.17

LGTM.

 I did ask you twice on IRC over the last few days and never received a 
 response.

Sorry, must've missed your messages.

-- 
Best regards,
Michał Górny


signature.asc
Description: PGP signature


[gentoo-dev] Adding ABI_MIPS USE_EXPAND

2013-07-29 Thread Matt Turner
Hi,

Any objections to me adding an ABI_MIPS USE_EXPAND variable so that I
can take advantage of the multilib work on mips?

Thanks,
Matt



Re: [gentoo-dev] Adding ABI_MIPS USE_EXPAND

2013-07-29 Thread Alexis Ballier
On Mon, 29 Jul 2013 17:21:15 -0700
Matt Turner matts...@gentoo.org wrote:

 Hi,
 
 Any objections to me adding an ABI_MIPS USE_EXPAND variable so that I
 can take advantage of the multilib work on mips?

go ahead -- note that some packages have broken multilib deps though

please add descriptions to abi_mips.desc so that noobs like me can have
a clue on what are the mips abis :)

Alexis.



Re: [gentoo-dev] Adding ABI_MIPS USE_EXPAND

2013-07-29 Thread Alexis Ballier
On Mon, 29 Jul 2013 20:40:31 -0400
Alexis Ballier aball...@gentoo.org wrote:

 On Mon, 29 Jul 2013 17:21:15 -0700
 Matt Turner matts...@gentoo.org wrote:
 
  Hi,
  
  Any objections to me adding an ABI_MIPS USE_EXPAND variable so that
  I can take advantage of the multilib work on mips?
 
 go ahead -- note that some packages have broken multilib deps though

ah, and it wont work if you dont add support to multilib-build.eclass
also.



Re: [gentoo-dev] Adding ABI_MIPS USE_EXPAND

2013-07-29 Thread Matt Turner
On Mon, Jul 29, 2013 at 5:41 PM, Alexis Ballier aball...@gentoo.org wrote:
 go ahead -- note that some packages have broken multilib deps though

Thanks!

 ah, and it wont work if you dont add support to multilib-build.eclass
 also.

Of course :)