Re: [gentoo-dev] Making user patches globally available

2012-04-18 Thread Jeroen Roovers
On Sun, 15 Apr 2012 01:35:40 -0700 Zac Medico zmed...@gentoo.org wrote: Funtoo has support for FEATURES=localpatch, which does the epatch_user thing before src_prepare. I think it should really go after src_prepare, in order to apply patches after those that src_prepare may apply (avoiding

Re: [gentoo-dev] Making user patches globally available

2012-04-18 Thread Mike Frysinger
On Wednesday 18 April 2012 12:59:13 Jeroen Roovers wrote: On Sun, 15 Apr 2012 01:35:40 -0700 Zac Medico wrote: Funtoo has support for FEATURES=localpatch, which does the epatch_user thing before src_prepare. I think it should really go after src_prepare, in order to apply patches after

Re: [gentoo-dev] Making user patches globally available

2012-04-16 Thread Michał Górny
On Sun, 15 Apr 2012 17:19:18 -0500 William Hubbs willi...@gentoo.org wrote: On Sun, Apr 15, 2012 at 03:55:58PM +0200, Michał Górny wrote: What if some patches are applied conditionally? imo patches that are applied conditionally should be rewritten so they can always be applied.

Re: [gentoo-dev] Making user patches globally available

2012-04-15 Thread Zac Medico
On 04/15/2012 01:16 AM, Ryan Hill wrote: Right now we have support in some packages for user patches - those being patches dropped into /etc/portage/patches/pkgname/ - which are automatically applied. Because this feature is implemented by epatch_user() in eutils.eclass, it is only available

Re: [gentoo-dev] Making user patches globally available

2012-04-15 Thread Patrick Lauer
On 04/15/12 16:16, Ryan Hill wrote: Right now we have support in some packages for user patches - those being patches dropped into /etc/portage/patches/pkgname/ - which are automatically applied. Because this feature is implemented by epatch_user() in eutils.eclass, it is only available for

[gentoo-dev] Making user patches globally available

2012-04-15 Thread Ryan Hill
Right now we have support in some packages for user patches - those being patches dropped into /etc/portage/patches/pkgname/ - which are automatically applied. Because this feature is implemented by epatch_user() in eutils.eclass, it is only available for ebuilds that inherit eutils and

Re: [gentoo-dev] Making user patches globally available

2012-04-15 Thread Sergei Trofimovich
On Sun, 15 Apr 2012 16:53:04 +0800 Patrick Lauer patr...@gentoo.org wrote: On 04/15/12 16:16, Ryan Hill wrote: Right now we have support in some packages for user patches - those being patches dropped into /etc/portage/patches/pkgname/ - which are automatically applied. Because this

Re: [gentoo-dev] Making user patches globally available

2012-04-15 Thread Andreas K. Huettel
Right now we have support in some packages for user patches - those being patches dropped into /etc/portage/patches/pkgname/ - which are automatically applied. Because this feature is implemented by epatch_user() in eutils.eclass, it is only available for ebuilds that inherit eutils and

Re: [gentoo-dev] Making user patches globally available

2012-04-15 Thread Michał Górny
On Sun, 15 Apr 2012 13:00:10 +0200 Andreas K. Huettel dilfri...@gentoo.org wrote: Right now we have support in some packages for user patches - those being patches dropped into /etc/portage/patches/pkgname/ - which are automatically applied. Because this feature is implemented by

Re: [gentoo-dev] Making user patches globally available

2012-04-15 Thread Michał Górny
On Sun, 15 Apr 2012 02:16:41 -0600 Ryan Hill dirtye...@gentoo.org wrote: Right now we have support in some packages for user patches - those being patches dropped into /etc/portage/patches/pkgname/ - which are automatically applied. Because this feature is implemented by epatch_user() in

Re: [gentoo-dev] Making user patches globally available

2012-04-15 Thread Mike Frysinger
On Sunday 15 April 2012 04:16:41 Ryan Hill wrote: Is there any reason why this couldn't just be done in the package manager, making user patches available for all ebuilds without code changes? i originally added it to eutils eclass and only called it in some ebuilds because people were against

Re: [gentoo-dev] Making user patches globally available

2012-04-15 Thread William Hubbs
On Sun, Apr 15, 2012 at 03:55:58PM +0200, Michał Górny wrote: What if some patches are applied conditionally? imo patches that are applied conditionally should be rewritten so they can always be applied. patches that are applied conditionally probably won't get into upsream most of the time.