Re: [gentoo-dev] New eclass: gkrellm-plugin

2007-03-09 Thread Mike Kelly
On Thu, 8 Mar 2007 12:34:59 -0600 Jim Ramsay [EMAIL PROTECTED] wrote: Petteri Räty wrote: Jim Ramsay wrote: ECLASS=gkrellm-plugin INHERITED=$INHERITED $ECLASS No need to set INHERITED yourself any more either. Ciaran already pointed out ECLASS. Indeed, thanks for that! They

[gentoo-dev] New eclass: gkrellm-plugin

2007-03-08 Thread Jim Ramsay
I'm tired of maintaining essentially the same code in 20-odd ebuilds, so I am wanting to condense the common bits into a single eclass. Most of you probably don't care, but it may be of interest to those few who maintain gkrellm plugin ebuilds. I have attached my first draft of the eclass. As

Re: [gentoo-dev] New eclass: gkrellm-plugin

2007-03-08 Thread Ciaran McCreesh
On Thu, 8 Mar 2007 11:19:20 -0600 Jim Ramsay [EMAIL PROTECTED] wrote: I have attached my first draft of the eclass. As you can see, there are 3 main important benefits to using this eclass: You shouldn't dodoc COPYING. You don't need to set ECLASS manually any more. -- Ciaran McCreesh Mail

Re: [gentoo-dev] New eclass: gkrellm-plugin

2007-03-08 Thread Petteri Räty
Jim Ramsay wrote: ECLASS=gkrellm-plugin INHERITED=$INHERITED $ECLASS No need to set INHERITED yourself any more either. Ciaran already pointed out ECLASS. gkrellm-plugin_pkg_setup() { if ! built_with_use app-admin/gkrellm X \ ! has X ${IUSE}; then

Re: [gentoo-dev] New eclass: gkrellm-plugin

2007-03-08 Thread Ioannis Aslanidis
On 3/8/07, Ciaran McCreesh [EMAIL PROTECTED] wrote: On Thu, 8 Mar 2007 11:19:20 -0600 Jim Ramsay [EMAIL PROTECTED] wrote: I have attached my first draft of the eclass. As you can see, there are 3 main important benefits to using this eclass: You shouldn't dodoc COPYING. How is it that it

Re: [gentoo-dev] New eclass: gkrellm-plugin

2007-03-08 Thread Petteri Räty
Ioannis Aslanidis wrote: On 3/8/07, Ciaran McCreesh [EMAIL PROTECTED] wrote: On Thu, 8 Mar 2007 11:19:20 -0600 Jim Ramsay [EMAIL PROTECTED] wrote: I have attached my first draft of the eclass. As you can see, there are 3 main important benefits to using this eclass: You shouldn't dodoc

Re: [gentoo-dev] New eclass: gkrellm-plugin

2007-03-08 Thread Stephen Bennett
On Thu, 8 Mar 2007 19:04:20 +0100 Ioannis Aslanidis [EMAIL PROTECTED] wrote: How is it that it should not be done? Is it because the file is usually a symlink? Or because there is simply no need to do it? Because it's the package's licence. Guess where we already store licence information.

Re: [gentoo-dev] New eclass: gkrellm-plugin

2007-03-08 Thread Ciaran McCreesh
On Thu, 8 Mar 2007 19:04:20 +0100 Ioannis Aslanidis [EMAIL PROTECTED] wrote: On 3/8/07, Ciaran McCreesh [EMAIL PROTECTED] wrote: On Thu, 8 Mar 2007 11:19:20 -0600 Jim Ramsay [EMAIL PROTECTED] wrote: I have attached my first draft of the eclass. As you can see, there are 3 main

Re: [gentoo-dev] New eclass: gkrellm-plugin

2007-03-08 Thread Ioannis Aslanidis
You shouldn't dodoc COPYING. How is it that it should not be done? Is it because the file is usually a symlink? Or because there is simply no need to do it? It's generally agreed that installing licence files should only be done if legally required. Otherwise, we already have a copy in the

Re: [gentoo-dev] New eclass: gkrellm-plugin

2007-03-08 Thread Seemant Kulleen
On Thu, 2007-03-08 at 20:02 +0200, Petteri Räty wrote: How useful is the X use flag in gkrellm? Just thinking if it would be better to just remove the use flag and always build that code. Regards, Petteri Back in the day, when gkrellm2 first came out, they had this option of building

Re: [gentoo-dev] New eclass: gkrellm-plugin

2007-03-08 Thread Jim Ramsay
Ciaran McCreesh wrote: On Thu, 8 Mar 2007 11:19:20 -0600 Jim Ramsay [EMAIL PROTECTED] wrote: I have attached my first draft of the eclass. As you can see, there are 3 main important benefits to using this eclass: You shouldn't dodoc COPYING. You don't need to set ECLASS manually any

Re: [gentoo-dev] New eclass: gkrellm-plugin

2007-03-08 Thread Andrej Kacian
On Thu, 08 Mar 2007 20:02:50 +0200 Petteri Räty [EMAIL PROTECTED] wrote: How useful is the X use flag in gkrellm? Just thinking if it would be better to just remove the use flag and always build that code. There is a possibility for headless servers to run gkrellmd, which runs in background,

Re: [gentoo-dev] New eclass: gkrellm-plugin

2007-03-08 Thread Jim Ramsay
Petteri Räty wrote: Jim Ramsay wrote: ECLASS=gkrellm-plugin INHERITED=$INHERITED $ECLASS No need to set INHERITED yourself any more either. Ciaran already pointed out ECLASS. Indeed, thanks for that! They just appeared automagically when I did 'vim foo.eclass' I wonder where that

Re: [gentoo-dev] New eclass: gkrellm-plugin

2007-03-08 Thread Marien Zwart
On Thu, Mar 08, 2007 at 11:19:20AM -0600, Jim Ramsay wrote: gkrellm-plugin_pkg_setup() { if ! built_with_use app-admin/gkrellm X \ ! has X ${IUSE}; then eerror This plugin requires the X frontend of gkrellm. eerror Please re-emerge

Re: [gentoo-dev] New eclass: gkrellm-plugin

2007-03-08 Thread Jim Ramsay
Marien Zwart wrote: On Thu, Mar 08, 2007 at 11:19:20AM -0600, Jim Ramsay wrote: gkrellm-plugin_pkg_setup() { if ! built_with_use app-admin/gkrellm X \ ! has X ${IUSE}; then eerror This plugin requires the X frontend of gkrellm. eerror Please re-emerge

Re: [gentoo-dev] New eclass: gkrellm-plugin

2007-03-08 Thread Jim Ramsay
Attached is version 2 of my draft eclass. I have incorporated the excellent changes suggested here, and it seems to be working great on my local overlay. -- Jim Ramsay Gentoo/Linux Developer (rox,gkrellm) # Copyright 1999-2007 Gentoo Foundation # Distributed under the terms of the GNU General

Re: [gentoo-dev] New eclass: gkrellm-plugin

2007-03-08 Thread Marien Zwart
On Thu, Mar 08, 2007 at 03:51:42PM -0600, Jim Ramsay wrote: gkrellm-plugin_pkg_setup() { if [[ -z ${PLUGIN_NO_XCHECK} ]] ! built_with_use app-admin/gkrellm X; then eerror This plugin requires the X frontend of gkrellm. eerror Please re-emerge