Re: [gentoo-dev] New eclass: scons.eclass

2010-10-07 Thread Donnie Berkholz
On 20:26 Wed 06 Oct , Michał Górny wrote: On Wed, 6 Oct 2010 12:52:33 -0500 Donnie Berkholz dberkh...@gentoo.org wrote: local flag=${1} local varname=${2:-${flag#!}} Could you explain how this works to me, please? It seems like you're reversing the logic when people use

Re: [gentoo-dev] New eclass: scons.eclass

2010-10-07 Thread Michał Górny
On Thu, 7 Oct 2010 22:08:30 -0500 Donnie Berkholz dberkh...@gentoo.org wrote: So what happens if I want the !use syntax and say `use_scons !ssl nossl`? ${2} is set then, and ${flag#!} isn't even evaluated. BTW I've changed that already to make $(use_scons !ssl) output nossl. This should be

Re: [gentoo-dev] New eclass: scons.eclass

2010-10-06 Thread Donnie Berkholz
On 20:57 Tue 05 Oct , Michał Górny wrote: # @FUNCTION: use_scons # @USAGE: use-flag [var-name] [var-opt-true] [var-opt-false] # @DESCRIPTION: # Output an SCons parameter with value depending on the USE flag state. # If the USE flag is set, output var-name=var-opt-true; otherwise #

Re: [gentoo-dev] New eclass: scons.eclass

2010-10-06 Thread Michał Górny
On Wed, 6 Oct 2010 12:52:33 -0500 Donnie Berkholz dberkh...@gentoo.org wrote: local flag=${1} local varname=${2:-${flag#!}} Could you explain how this works to me, please? It seems like you're reversing the logic when people use the !flag syntax. It's just the variable (macro)

Re: [gentoo-dev] New eclass: scons.eclass

2010-08-24 Thread Michał Górny
On Mon, 23 Aug 2010 19:27:22 -0400 Mike Frysinger vap...@gentoo.org wrote: then keep it simple and separate: escons() { debug-print-function ${FUNCNAME} $...@} set -- scons $(scons_clean_makeopts) ${SCONSOPTS} ${EXTRA_ESCONS} $...@} echo $...@} 2 $...@} } now you

Re: [gentoo-dev] New eclass: scons.eclass

2010-08-24 Thread Michał Górny
On Mon, 23 Aug 2010 19:36:50 +0200 Maciej Mrozowski reave...@gmail.com wrote: If SCons is unpredictable, then don't provide *any* phases and only functions and rename it to scons-utils to match its purpose. It is as predictable as the buildsystem meeting the default phase functions

Re: [gentoo-dev] New eclass: scons.eclass

2010-08-24 Thread Maciej Mrozowski
On Tuesday 24 of August 2010 10:30:12 Michał Górny wrote: On Mon, 23 Aug 2010 19:36:50 +0200 Maciej Mrozowski reave...@gmail.com wrote: If SCons is unpredictable, then don't provide *any* phases and only functions and rename it to scons-utils to match its purpose. It is as predictable

Re: [gentoo-dev] New eclass: scons.eclass

2010-08-24 Thread Michał Górny
r4, ChangeLog: 3e30e1f Rename to scons-utils.eclass. 6477004 Remove exported phase functions. 41784fc Implement a cache in scons_clean_makeopts(). 9b3ce5d Clarify doc on SCONSOPTS. ac9f7ed Call scons_clean_makeopts() inline instead of exporting SCONSOPTS. ae6afd9 Fix SCONSOPTS check in

Re: [gentoo-dev] New eclass: scons.eclass

2010-08-24 Thread Mike Frysinger
On Tuesday, August 24, 2010 14:40:56 Michał Górny wrote: 3e30e1f Rename to scons-utils.eclass. funny, i thought scons.eclass was appropriate. but whatever. -mike signature.asc Description: This is a digitally signed message part.

Re: [gentoo-dev] New eclass: scons.eclass

2010-08-24 Thread Michał Górny
On Tue, 24 Aug 2010 17:30:32 -0400 Mike Frysinger vap...@gentoo.org wrote: On Tuesday, August 24, 2010 14:40:56 Michał Górny wrote: 3e30e1f Rename to scons-utils.eclass. funny, i thought scons.eclass was appropriate. but whatever. Maciej complained about not exporting all ever possible

Re: [gentoo-dev] New eclass: scons.eclass

2010-08-23 Thread Michał Górny
On Sun, 22 Aug 2010 20:39:23 +0200 Michał Górny gen...@mgorny.alt.pl wrote: The third revision, almost all suggestions applied. The ChangeLog: 151ddf2 Support passing a flag list to scons_clean_makeopts(). 82a3ee7 Output the resulting flag list in scons_clean_makeopts() instead of

Re: [gentoo-dev] New eclass: scons.eclass

2010-08-23 Thread Mike Frysinger
On Monday, August 23, 2010 12:24:54 Michał Górny wrote: The third revision, almost all suggestions applied. The ChangeLog: if there are suggestions you've actively ignored, those should be noted 44188e0 escons(): set SCONSOPTS implicitly if they are unset. ccf1ef9 Introduce SCONSOPTS and use

Re: [gentoo-dev] New eclass: scons.eclass

2010-08-23 Thread Michał Górny
On Mon, 23 Aug 2010 12:39:50 -0400 Mike Frysinger vap...@gentoo.org wrote: On Monday, August 23, 2010 12:24:54 Michał Górny wrote: The third revision, almost all suggestions applied. The ChangeLog: if there are suggestions you've actively ignored, those should be noted I've replied to the

Re: [gentoo-dev] New eclass: scons.eclass

2010-08-23 Thread Mike Frysinger
On Monday, August 23, 2010 13:16:38 Michał Górny wrote: On Mon, 23 Aug 2010 12:39:50 -0400 Mike Frysinger wrote: i'm not sure caching the value and using it in between runs is a good idea. unless you also cache the thing you're caching and compare it to make sure your cache is no longer

Re: [gentoo-dev] New eclass: scons.eclass

2010-08-23 Thread Michał Górny
On Mon, 23 Aug 2010 16:22:35 -0400 Mike Frysinger vap...@gentoo.org wrote: On Monday, August 23, 2010 13:16:38 Michał Górny wrote: On Mon, 23 Aug 2010 12:39:50 -0400 Mike Frysinger wrote: i'm not sure caching the value and using it in between runs is a good idea. unless you also cache

Re: [gentoo-dev] New eclass: scons.eclass

2010-08-23 Thread Mike Frysinger
On Monday, August 23, 2010 19:02:21 Michał Górny wrote: On Mon, 23 Aug 2010 16:22:35 -0400 Mike Frysinger wrote: On Monday, August 23, 2010 13:16:38 Michał Górny wrote: On Mon, 23 Aug 2010 12:39:50 -0400 Mike Frysinger wrote: i'm not sure caching the value and using it in between runs is

[gentoo-dev] New eclass: scons.eclass

2010-08-22 Thread Michał Górny
Hello, As per bug #333911, I'm working on a new eclass, providing some basic functions common to most of the ebuilds using the SCons build system. The basic reason for the new eclass is that a growing number of ebuilds is calling SCons directly, and reimplementing the same ideas. This is

Re: [gentoo-dev] New eclass: scons.eclass

2010-08-22 Thread Alex Alexander
On Sun, Aug 22, 2010 at 12:04:52PM +0200, Michał Górny wrote: Hello, As per bug #333911, I'm working on a new eclass, providing some basic functions common to most of the ebuilds using the SCons build system. [...] I'm attaching the eclass draft (the same which is attached to bug

Re: [gentoo-dev] New eclass: scons.eclass

2010-08-22 Thread David Leverton
2010/8/22 Michał Górny gen...@mgorny.alt.pl: src_compile() {        scons \                $(scons-use unicode) \                $(scons-use gnutls ssl gnutls openssl) \                ${MAKEOPTS} || die        # expands into:        # scons unicode={1|0} ssl={gnutls|openssl} -jN || die }

Re: [gentoo-dev] New eclass: scons.eclass

2010-08-22 Thread Michał Górny
On Sun, 22 Aug 2010 13:26:18 +0300 Alex Alexander wi...@gentoo.org wrote: You could avoid having to define pkg_setup in every ebuild by defining a default one in your eclass: Yeah, I am considering that. I am considering adding a default src_compile() too. -- Best regards, Michał Górny

Re: [gentoo-dev] New eclass: scons.eclass

2010-08-22 Thread Michał Górny
On Sun, 22 Aug 2010 12:03:10 +0100 David Leverton levert...@googlemail.com wrote: 2010/8/22 Michał Górny gen...@mgorny.alt.pl: src_compile() {        scons \                $(scons-use unicode) \                $(scons-use gnutls ssl gnutls openssl) \                ${MAKEOPTS} || die