Re: [gentoo-dev] RFC: Moving gnome2_icon_cache_update functionality to xdg-utils.eclass
On Fri, 2018-02-16 at 06:38 +0100, Michał Górny wrote: > W dniu pią, 16.02.2018 o godzinie 02∶17 +0200, użytkownik Mart > Raudsepp > napisał: > > Hello, > > > > Before writing the obvious patches, would anyone terribly object to > > moving gnome2_icon_cache_update into xdg-utils.eclass instead and > > hooking it up via savelist guard in xdg.eclass (only running in > > postinst/postrm when really needed)? > > > > The gtk icon cache format isn't used by gtk+ only - it's used by Qt > > as > > well these days; and either way if anything installs things per the > > icon specs, the caches should be updated for gtk/qt to see it (even > > if > > the program itself is written in motif or something). > > Maybe it'd be reasonable to rename it while at it, to gtk_icon_cache* > or xdg_gtk_icon_cache*. It would really suck to have xdg* provide > a function named gnome2*, especially when it's not specific to GNOME. Yes, of course. That's an obvious thing to do, didn't even think to mention it explicitly. Afterall, we'll need the old name still in gnome2-utils for compatibility for a while too. I'm unsure about the name though, I like gtk_update_icon_cache, but not having it prefixed with xdg or xdg-utils sounds a bit wrong; though I think it makes a good argument to make an exception here. The tool that provides the helper is split into a gtk-update-icon-cache named packge as well. Do you have any opinions on my dilemmas? > > > > Open dilemmas: > > > > * To DEPEND on gtk-update-icon-cache, or to rely on the toolkits to > > pull it in and only run the updates if the helper is present. We > > have > > it split out from gtk+ codebase, so it only has glib/gdk-pixbuf > > deps > > right now. > > > > * If it's worth trying to avoid double calls in postint and postrm > > for > > ebuilds that inherit xdg and call gnome2_icon_cache_update manually > > right now on top (due to xdg.eclass not doing it for them). > > > > > > If these changes are agreeable, then they could also be batched > > into a > > single push with the documentation update patches pending from > > mgorny > > for a single metadata cache invalidation of gnome2-utils.eclass > > using > > ebuilds. > > > > If this looks good, I can write patches soon, though there's always > > other things to do too (like work on integrating a gnome- > > meson.eclass > > or meson-desktop.eclass on top of this), so help with patches > > welcome > > as well. > > > > > > Mart > > > >
Re: [gentoo-dev] RFC: Moving gnome2_icon_cache_update functionality to xdg-utils.eclass
W dniu pią, 16.02.2018 o godzinie 02∶17 +0200, użytkownik Mart Raudsepp napisał: > Hello, > > Before writing the obvious patches, would anyone terribly object to > moving gnome2_icon_cache_update into xdg-utils.eclass instead and > hooking it up via savelist guard in xdg.eclass (only running in > postinst/postrm when really needed)? > > The gtk icon cache format isn't used by gtk+ only - it's used by Qt as > well these days; and either way if anything installs things per the > icon specs, the caches should be updated for gtk/qt to see it (even if > the program itself is written in motif or something). Maybe it'd be reasonable to rename it while at it, to gtk_icon_cache* or xdg_gtk_icon_cache*. It would really suck to have xdg* provide a function named gnome2*, especially when it's not specific to GNOME. > > Open dilemmas: > > * To DEPEND on gtk-update-icon-cache, or to rely on the toolkits to > pull it in and only run the updates if the helper is present. We have > it split out from gtk+ codebase, so it only has glib/gdk-pixbuf deps > right now. > > * If it's worth trying to avoid double calls in postint and postrm for > ebuilds that inherit xdg and call gnome2_icon_cache_update manually > right now on top (due to xdg.eclass not doing it for them). > > > If these changes are agreeable, then they could also be batched into a > single push with the documentation update patches pending from mgorny > for a single metadata cache invalidation of gnome2-utils.eclass using > ebuilds. > > If this looks good, I can write patches soon, though there's always > other things to do too (like work on integrating a gnome-meson.eclass > or meson-desktop.eclass on top of this), so help with patches welcome > as well. > > > Mart > -- Best regards, Michał Górny
[gentoo-dev] RFC: Moving gnome2_icon_cache_update functionality to xdg-utils.eclass
Hello, Before writing the obvious patches, would anyone terribly object to moving gnome2_icon_cache_update into xdg-utils.eclass instead and hooking it up via savelist guard in xdg.eclass (only running in postinst/postrm when really needed)? The gtk icon cache format isn't used by gtk+ only - it's used by Qt as well these days; and either way if anything installs things per the icon specs, the caches should be updated for gtk/qt to see it (even if the program itself is written in motif or something). Open dilemmas: * To DEPEND on gtk-update-icon-cache, or to rely on the toolkits to pull it in and only run the updates if the helper is present. We have it split out from gtk+ codebase, so it only has glib/gdk-pixbuf deps right now. * If it's worth trying to avoid double calls in postint and postrm for ebuilds that inherit xdg and call gnome2_icon_cache_update manually right now on top (due to xdg.eclass not doing it for them). If these changes are agreeable, then they could also be batched into a single push with the documentation update patches pending from mgorny for a single metadata cache invalidation of gnome2-utils.eclass using ebuilds. If this looks good, I can write patches soon, though there's always other things to do too (like work on integrating a gnome-meson.eclass or meson-desktop.eclass on top of this), so help with patches welcome as well. Mart
