[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-text/ghostscript-gpl: metadata.xml ChangeLog ghostscript-gpl-9.04-r4.ebuild

2011-11-12 Thread Samuli Suominen
On 11/12/2011 12:21 PM, Justin Lecher (jlec) wrote:
 jlec11/11/12 10:21:37
 
   Modified: metadata.xml ChangeLog
 ghostscript-gpl-9.04-r4.ebuild
   Log:
   Fixed slotting for media-libs/tiff
   
   (Portage version: 2.2.0_alpha73/cvs/Linux x86_64)
 
 Revision  ChangesPath
 1.3  app-text/ghostscript-gpl/metadata.xml
 
 file : 
 http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-text/ghostscript-gpl/metadata.xml?rev=1.3view=markup
 plain: 
 http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-text/ghostscript-gpl/metadata.xml?rev=1.3content-type=text/plain
 diff : 
 http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-text/ghostscript-gpl/metadata.xml?r1=1.2r2=1.3
 
 Index: metadata.xml
 ===
 RCS file: /var/cvsroot/gentoo-x86/app-text/ghostscript-gpl/metadata.xml,v
 retrieving revision 1.2
 retrieving revision 1.3
 diff -u -r1.2 -r1.3
 --- metadata.xml  2 Jun 2011 09:59:25 -   1.2
 +++ metadata.xml  12 Nov 2011 10:21:37 -  1.3
 @@ -1,8 +1,8 @@
  ?xml version=1.0 encoding=UTF-8?
  !DOCTYPE pkgmetadata SYSTEM http://www.gentoo.org/dtd/metadata.dtd;
  pkgmetadata
 -herdprinting/herd
 -  use
 -flag name=bindistDisable dejavu support for binary distribution 
 because of licensing issue/flag
 -  /use
 + herdprinting/herd
 + use
 + flag name=bindistDisable dejavu support for binary 
 distribution because of licensing issue/flag
 + /use
  /pkgmetadata

I wonder what that has to do with Fixed slotting for media-libs/tiff?

Do we have a guideline or policy on using 2 spaces vs. tabs in .xml
files and gentoo-x86? Just asking because I prefer 2 spaces over tabs.



[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-text/ghostscript-gpl: metadata.xml ChangeLog ghostscript-gpl-9.04-r4.ebuild

2011-11-12 Thread justin
On 11/12/11 11:25 AM, Samuli Suominen wrote:
 On 11/12/2011 12:21 PM, Justin Lecher (jlec) wrote:
 jlec11/11/12 10:21:37

   Modified: metadata.xml ChangeLog
 ghostscript-gpl-9.04-r4.ebuild
   Log:
   Fixed slotting for media-libs/tiff
   
   (Portage version: 2.2.0_alpha73/cvs/Linux x86_64)

 Revision  ChangesPath
 1.3  app-text/ghostscript-gpl/metadata.xml

 file : 
 http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-text/ghostscript-gpl/metadata.xml?rev=1.3view=markup
 plain: 
 http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-text/ghostscript-gpl/metadata.xml?rev=1.3content-type=text/plain
 diff : 
 http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-text/ghostscript-gpl/metadata.xml?r1=1.2r2=1.3

 Index: metadata.xml
 ===
 RCS file: /var/cvsroot/gentoo-x86/app-text/ghostscript-gpl/metadata.xml,v
 retrieving revision 1.2
 retrieving revision 1.3
 diff -u -r1.2 -r1.3
 --- metadata.xml 2 Jun 2011 09:59:25 -   1.2
 +++ metadata.xml 12 Nov 2011 10:21:37 -  1.3
 @@ -1,8 +1,8 @@
  ?xml version=1.0 encoding=UTF-8?
  !DOCTYPE pkgmetadata SYSTEM http://www.gentoo.org/dtd/metadata.dtd;
  pkgmetadata
 -herdprinting/herd
 -  use
 -flag name=bindistDisable dejavu support for binary distribution 
 because of licensing issue/flag
 -  /use
 +herdprinting/herd
 +use
 +flag name=bindistDisable dejavu support for binary 
 distribution because of licensing issue/flag
 +/use
  /pkgmetadata
 
 I wonder what that has to do with Fixed slotting for media-libs/tiff?
 

This means, we better should use media-libs/tiff:0 to avoid problem if
tkimg is installed. I added :0 to the tiff dep.

 Do we have a guideline or policy on using 2 spaces vs. tabs in .xml
 files and gentoo-x86? Just asking because I prefer 2 spaces over tabs.

I asked and as far as I can remember, there was a do what you like
answer. Especially older devs didn't like to be forced to anything here.
Why I changed it? Not directly by purpose. I am trying to fix formating
using xmlstartlet prior to commit, as I found that many metadata.xml do
not follow a clear rule. And xml formatting is a quite straight thing,
so I didn't thought people don't like it.

justin



signature.asc
Description: OpenPGP digital signature


[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-text/ghostscript-gpl: metadata.xml ChangeLog ghostscript-gpl-9.04-r4.ebuild

2011-11-12 Thread justin
On 11/12/11 12:56 PM, justin wrote:
 On 11/12/11 11:25 AM, Samuli Suominen wrote:
 On 11/12/2011 12:21 PM, Justin Lecher (jlec) wrote:
 jlec11/11/12 10:21:37

   Modified: metadata.xml ChangeLog
 ghostscript-gpl-9.04-r4.ebuild
   Log:
   Fixed slotting for media-libs/tiff
   
   (Portage version: 2.2.0_alpha73/cvs/Linux x86_64)

 Revision  ChangesPath
 1.3  app-text/ghostscript-gpl/metadata.xml

 file : 
 http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-text/ghostscript-gpl/metadata.xml?rev=1.3view=markup
 plain: 
 http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-text/ghostscript-gpl/metadata.xml?rev=1.3content-type=text/plain
 diff : 
 http://sources.gentoo.org/viewvc.cgi/gentoo-x86/app-text/ghostscript-gpl/metadata.xml?r1=1.2r2=1.3

 Index: metadata.xml
 ===
 RCS file: /var/cvsroot/gentoo-x86/app-text/ghostscript-gpl/metadata.xml,v
 retrieving revision 1.2
 retrieving revision 1.3
 diff -u -r1.2 -r1.3
 --- metadata.xml2 Jun 2011 09:59:25 -   1.2
 +++ metadata.xml12 Nov 2011 10:21:37 -  1.3
 @@ -1,8 +1,8 @@
  ?xml version=1.0 encoding=UTF-8?
  !DOCTYPE pkgmetadata SYSTEM http://www.gentoo.org/dtd/metadata.dtd;
  pkgmetadata
 -herdprinting/herd
 -  use
 -flag name=bindistDisable dejavu support for binary distribution 
 because of licensing issue/flag
 -  /use
 +   herdprinting/herd
 +   use
 +   flag name=bindistDisable dejavu support for binary 
 distribution because of licensing issue/flag
 +   /use
  /pkgmetadata

 I wonder what that has to do with Fixed slotting for media-libs/tiff?

 
I missread your question. This has nothing to do with slotting, but I
don't think this needs an extra entry in the Changelog. Or am I wrong here?



signature.asc
Description: OpenPGP digital signature


Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in app-text/ghostscript-gpl: metadata.xml ChangeLog ghostscript-gpl-9.04-r4.ebuild

2011-11-12 Thread Jorge Manuel B. S. Vicetto
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

On 12-11-2011 09:25, Samuli Suominen wrote:
 
 I wonder what that has to do with Fixed slotting for
 media-libs/tiff?
 
 Do we have a guideline or policy on using 2 spaces vs. tabs in
 .xml files and gentoo-x86? Just asking because I prefer 2 spaces
 over tabs.

Sometime ago when I did a few updates to metadata.xml related to
retirements, I've asked around and there was no policy on whether to
use 2 spaces or tabs. Back then the GDP preferred one over the other,
but that only applied to GDP documents.

On 12-11-2011 11:01, justin wrote:
 On 11/12/11 12:56 PM, justin wrote:
 
 I wonder what that has to do with Fixed slotting for
 media-libs/tiff?
 
 
 I missread your question. This has nothing to do with slotting, but
 I don't think this needs an extra entry in the Changelog. Or am I
 wrong here?

Changing style on a package or supporting files is imho something
that should be left for package maintainers. If some maintainers /
herds agree with the change, one should probably add a note in the
commit mentioning that.

- -- 
Regards,

Jorge Vicetto (jmbsvicetto) - jmbsvicetto at gentoo dot org
Gentoo- forums / Userrel / Devrel / KDE / Elections / RelEng
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.18 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOvo3zAAoJEC8ZTXQF1qEPa5UQAJ758RZlZGw7baix3oA19kw7
Cr9nRXFFlnXAq+8yws5kNi01N8Azhug+MH7lwTJyqnJADYHl8gti15iegW5iZW0r
qxpwHE5XWjCKdST65kM1F3aDtaqvRQK/gd2mmQ9dgAzLWzwiy1tfI9aYxSUq7ufR
KUbEuDoyATmddoAONMQIEgokTLWewESJ+3a8q1i87Yd+O2iii/JXo0GgcnWIsROU
lwiEmK0G1iCIqzELik1ceeQ8BJanpPXuX06/fSAVmWNUKkKqATFiV1Q1qrNrIR1o
akkpDTKNUPFXlVUl5IjohxpJ58ybIaBsklK7v8ceFF4I8mJgwjQLmjaruFB/yHuy
t6g4FaS1BiIyQ6aiHxm62LVG8UTOKtxqHjke6JobRskIm/hsaG09R2G7d4Nzs3gU
uycyBbu0QkmuC7emsZZw+cb89E3/TMQavMO/QWaCHpiBXEH0II/uXsl7LR8ZpdiB
FXLxZNcN9mRPX7n1Q0FKNqwJH4cm4gZRto4PwbeTQ1Ls9aX26r5eBMlFBSzcI5f1
zKaS3GqXTvErSGKsDQxWB7RihH1fNbXEUm/GvXKG4dVRzYPT+VKTZBDW26gnBaWR
C8zwXuuy3aOdUl1KKy4cDZRHVySojZarDXnxiiwtpImPq46nCZq8TCtxX1GgZxs4
Vx6I0sGNFJwVDK8jTZa6
=Y/gm
-END PGP SIGNATURE-