Re: [gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-misc/boinc: boinc-5.8.15.ebuild ChangeLog boinc-5.10.28.ebuild boinc-5.5.6.ebuild boinc-5.2.14.ebuild boinc-4.72.20050813-r3.ebuild boinc
On Thursday 17 January 2008, Donnie Berkholz wrote: > On 03:21 Thu 17 Jan , Joshua Jackson (tsunam) wrote: > > 1.1 sci-misc/boinc/boinc-5.10.28.ebuild > > > > file : > > http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-misc/boinc/boinc-5.10 > >.28.ebuild?rev=1.1&view=markup plain: > > http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-misc/boinc/boinc-5.10 > >.28.ebuild?rev=1.1&content-type=text/plain > > > > src_compile() { > > append-flags -O3 -funroll-loops -fforce-addr -ffast-math /me cries > Something this wacky could really use a comment. Presumably upstream > highly recommends these flags. Perhaps a custom-cflags USE flag could > disable them. yes to all points > > mkdir "${D}"/var "${D}"/var/lib "${D}"/var/lib/boinc/ > > `mkdir -p` isn't portable? it is portable (any system not supporting it is not supported by Gentoo and should be recycled). even then, `dodir` should always (*) be used for dir creation in $D. -mike signature.asc Description: This is a digitally signed message part.
[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in sci-misc/boinc: boinc-5.8.15.ebuild ChangeLog boinc-5.10.28.ebuild boinc-5.5.6.ebuild boinc-5.2.14.ebuild boinc-4.72.20050813-r3.ebuild boinc-5.4
On 03:21 Thu 17 Jan , Joshua Jackson (tsunam) wrote: > 1.1 sci-misc/boinc/boinc-5.10.28.ebuild > > file : > http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-misc/boinc/boinc-5.10.28.ebuild?rev=1.1&view=markup > plain: > http://sources.gentoo.org/viewcvs.py/gentoo-x86/sci-misc/boinc/boinc-5.10.28.ebuild?rev=1.1&content-type=text/plain > src_compile() { > append-flags -O3 -funroll-loops -fforce-addr -ffast-math Something this wacky could really use a comment. Presumably upstream highly recommends these flags. Perhaps a custom-cflags USE flag could disable them. > src_install() { > make install DESTDIR=""${D}"" || die "make install failed" Please use emake, if it works. If not, add a comment. > mkdir "${D}"/var "${D}"/var/lib "${D}"/var/lib/boinc/ `mkdir -p` isn't portable? > cp "${S}"/ca-bundle.crt "${D}"/var/lib/boinc > chown boinc:boinc "${D}"/var/lib/boinc Could use fowners here. > newinitd "${FILESDIR}"/boinc.init boinc > newconfd "${FILESDIR}"/boinc.conf boinc > > make_desktop_entry boinc_gui BOINC boinc Science /var/lib/boinc > } Thanks, Donnie -- gentoo-dev@lists.gentoo.org mailing list