[gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: dev-ros/compressed_image_transport/

[hasufell]

On 10/09/2015 06:37 PM, Alexis Ballier wrote:
> commit: 4440cc9d950795eaae8f8b049bbf37c073ef5ea0
> Author: Alexis Ballier  gentoo  org>
> AuthorDate: Fri Oct  9 16:37:18 2015 +
> Commit: Alexis Ballier  gentoo  org>
> CommitDate: Fri Oct  9 16:37:18 2015 +
> URL:https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4440cc9d
> 
> dev-ros/compressed_image_transport: Add PYTHON_COMPAT and PYTHON_USEDEP on 
> dynamic_reconfigure. Bug #562664.
> 
> Package-Manager: portage-2.2.23
> 

[...]

> --- 
> a/dev-ros/compressed_image_transport/compressed_image_transport-1.9.2.ebuild
> +++ 
> b/dev-ros/compressed_image_transport/compressed_image_transport-1.9.2-r1.ebuild
> @@ -6,6 +6,7 @@ EAPI=5
>  ROS_REPO_URI="https://github.com/ros-perception/image_transport_plugins;
>  KEYWORDS="~amd64 ~arm"
>  ROS_SUBDIR=${PN}
> +PYTHON_COMPAT=( python2_7 )
>  
>  inherit ros-catkin
>  
> @@ -16,7 +17,7 @@ IUSE=""
>  
>  RDEPEND="
>   dev-ros/cv_bridge
> - dev-ros/dynamic_reconfigure
> + dev-ros/dynamic_reconfigure[${PYTHON_USEDEP}]
>   dev-ros/image_transport
>   dev-ros/tf
>   media-libs/opencv
> 
> diff --git 
> a/dev-ros/compressed_image_transport/compressed_image_transport-.ebuild 
> b/dev-ros/compressed_image_transport/compressed_image_transport-.ebuild
> index f7a387a..144fac9 100644
> --- 
> a/dev-ros/compressed_image_transport/compressed_image_transport-.ebuild
> +++ 
> b/dev-ros/compressed_image_transport/compressed_image_transport-.ebuild
> @@ -6,6 +6,7 @@ EAPI=5
>  ROS_REPO_URI="https://github.com/ros-perception/image_transport_plugins;
>  KEYWORDS="~amd64 ~arm"
>  ROS_SUBDIR=${PN}
> +PYTHON_COMPAT=( python2_7 )
>  
>  inherit ros-catkin
>  
> @@ -16,7 +17,7 @@ IUSE=""
>  
>  RDEPEND="
>   dev-ros/cv_bridge
> - dev-ros/dynamic_reconfigure
> + dev-ros/dynamic_reconfigure[${PYTHON_USEDEP}]
>   dev-ros/image_transport
>   dev-ros/tf
>   media-libs/opencv
> 

Maybe I am missing something, but ${PYTHON_DEPS} seems missing here and
I cannot find it in ros-catkin.eclass either. It's only an indirect dep
which is inappropriate.

Maybe other ros packages are affected as well.

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: dev-ros/compressed_image_transport/

[Alexis Ballier]

On Fri, 9 Oct 2015 19:28:32 +0200
hasufell  wrote:

> On 10/09/2015 07:22 PM, Alexis Ballier wrote:
> > Doesn't python-r1 add this ? It seems not...
> > It should be added to ros-catkin.eclass when PYTHON_COMPAT is set.
> > Any hint on how to proceed ?
> > 
> 
> distutils-r1 adds it, python-r1 is a "low-level" eclass and not
> supposed to do a lot of magic.
> 
> Technically, you would have to revbump all packages, but since the
> indirect dep-graph will pull in python anyway, I guess we can skip
> that.

yeah, fortunately dev-python/empy[] is mandatory

> I guess you can add it with a if-PYTHON_COMPAT-conditional somewhere
> around line 68 where you already modify python related deps
> (python-exec).

done that, thanks

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: dev-ros/compressed_image_transport/

[hasufell]

On 10/09/2015 07:22 PM, Alexis Ballier wrote:
> Doesn't python-r1 add this ? It seems not...
> It should be added to ros-catkin.eclass when PYTHON_COMPAT is set. Any
> hint on how to proceed ?
> 

distutils-r1 adds it, python-r1 is a "low-level" eclass and not supposed
to do a lot of magic.

Technically, you would have to revbump all packages, but since the
indirect dep-graph will pull in python anyway, I guess we can skip that.

I guess you can add it with a if-PYTHON_COMPAT-conditional somewhere
around line 68 where you already modify python related deps (python-exec).

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: dev-ros/compressed_image_transport/

[Alexis Ballier]

On Fri, 9 Oct 2015 19:18:49 +0200
hasufell  wrote:

> On 10/09/2015 06:37 PM, Alexis Ballier wrote:
> > commit: 4440cc9d950795eaae8f8b049bbf37c073ef5ea0
> > Author: Alexis Ballier  gentoo  org>
> > AuthorDate: Fri Oct  9 16:37:18 2015 +
> > Commit: Alexis Ballier  gentoo  org>
> > CommitDate: Fri Oct  9 16:37:18 2015 +
> > URL:
> > https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=4440cc9d
> > 
> > dev-ros/compressed_image_transport: Add PYTHON_COMPAT and
> > PYTHON_USEDEP on dynamic_reconfigure. Bug #562664.
> > 
> > Package-Manager: portage-2.2.23
> > 
> 
> [...]
> 
> > ---
> > a/dev-ros/compressed_image_transport/compressed_image_transport-1.9.2.ebuild
> > +++
> > b/dev-ros/compressed_image_transport/compressed_image_transport-1.9.2-r1.ebuild
> > @@ -6,6 +6,7 @@ EAPI=5
> > ROS_REPO_URI="https://github.com/ros-perception/image_transport_plugins;
> > KEYWORDS="~amd64 ~arm" ROS_SUBDIR=${PN} +PYTHON_COMPAT=( python2_7 )
> >  
> >  inherit ros-catkin
> >  
> > @@ -16,7 +17,7 @@ IUSE=""
> >  
> >  RDEPEND="
> > dev-ros/cv_bridge
> > -   dev-ros/dynamic_reconfigure
> > +   dev-ros/dynamic_reconfigure[${PYTHON_USEDEP}]
> > dev-ros/image_transport
> > dev-ros/tf
> > media-libs/opencv
> > 
> > diff --git
> > a/dev-ros/compressed_image_transport/compressed_image_transport-.ebuild
> > b/dev-ros/compressed_image_transport/compressed_image_transport-.ebuild
> > index f7a387a..144fac9 100644 ---
> > a/dev-ros/compressed_image_transport/compressed_image_transport-.ebuild
> > +++
> > b/dev-ros/compressed_image_transport/compressed_image_transport-.ebuild
> > @@ -6,6 +6,7 @@ EAPI=5
> > ROS_REPO_URI="https://github.com/ros-perception/image_transport_plugins;
> > KEYWORDS="~amd64 ~arm" ROS_SUBDIR=${PN} +PYTHON_COMPAT=( python2_7
> > ) inherit ros-catkin
> >  
> > @@ -16,7 +17,7 @@ IUSE=""
> >  
> >  RDEPEND="
> > dev-ros/cv_bridge
> > -   dev-ros/dynamic_reconfigure
> > +   dev-ros/dynamic_reconfigure[${PYTHON_USEDEP}]
> > dev-ros/image_transport
> > dev-ros/tf
> > media-libs/opencv
> > 
> 
> Maybe I am missing something, but ${PYTHON_DEPS} seems missing here
> and I cannot find it in ros-catkin.eclass either. It's only an
> indirect dep which is inappropriate.


Doesn't python-r1 add this ? It seems not...
It should be added to ros-catkin.eclass when PYTHON_COMPAT is set. Any
hint on how to proceed ?