Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: net-analyzer/metasploit/

2015-10-09 Thread hasufell 
On 10/09/2015 05:42 PM, hasufell wrote:
>> +
>> +QA_PREBUILT="
>> +usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_x86_linux.bin
>> +usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_armle_linux.bin
>> +usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_x86_solaris.bin
>> +usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_x64_linux.bin
>> +usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_x64_linux_dll.bin
>> +usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_x86_bsd.bin
>> +usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_x64_bsd.bin
>> +usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_mipsbe_linux.bin
>> +usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_mipsle_linux.bin
>> +usr/$(get_libdir)/${PN}${SLOT}/data/meterpreter/msflinker_linux_x86.bin
>> +usr/$(get_libdir)/${PN}${SLOT}/data/meterpreter/ext_server_sniffer.lso
>> +
>> usr/$(get_libdir)/${PN}${SLOT}/data/meterpreter/ext_server_networkpug.lso
>> +usr/$(get_libdir)/${PN}${SLOT}/data/meterpreter/ext_server_stdapi.lso
>> +usr/$(get_libdir)/${PN}${SLOT}/data/exploits/CVE-2013-2171.bin
>> +usr/$(get_libdir)/${PN}${SLOT}/data/exploits/CVE-2014-3153.elf
>> +usr/$(get_libdir)/${PN}${SLOT}/data/android/libs/x86/libndkstager.so
>> +usr/$(get_libdir)/${PN}${SLOT}/data/android/libs/mips/libndkstager.so
>> +usr/$(get_libdir)/${PN}${SLOT}/data/android/libs/armeabi/libndkstager.so
>> +"
>> +
> 
> I think $(get_libdir) is not allowed in global scope and breaks metadata.
> 
> You can use probably 'usr/lib*/...'
> 
> [...]
> 

And this is the same in dev-ruby/metasploit-payloads ebuild

[gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: net-analyzer/metasploit/

2015-10-09 Thread hasufell 
On 10/08/2015 11:04 PM, Richard Farina wrote:
> commit: 408bb337f1207a7c844d99b70a0f5a164f0b990d
> Author: Zero_Chaos  gentoo  org>
> AuthorDate: Thu Oct  8 21:04:12 2015 +
> Commit: Richard Farina  gentoo  org>
> CommitDate: Thu Oct  8 21:04:48 2015 +
> URL:https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=408bb337
> 
> net-analyzer/metasploit: I thought keeping the live ebuild in my overlay 
> would decrease the work but it looks like the ruby team and I are duplicating 
> each other and causing more work so moving it back into gentoo
> 

Commit message is over-long, please give a short summary and a more
detailed description after a newline.

>  net-analyzer/metasploit/metasploit-.ebuild | 298 
> +
>  1 file changed, 298 insertions(+)
> 
> diff --git a/net-analyzer/metasploit/metasploit-.ebuild 
> b/net-analyzer/metasploit/metasploit-.ebuild
> new file mode 100644
> index 000..d07ff32
> --- /dev/null
> +++ b/net-analyzer/metasploit/metasploit-.ebuild
> @@ -0,0 +1,298 @@
> +# Copyright 1999-2015 Gentoo Foundation
> +# Distributed under the terms of the GNU General Public License v2
> +# $Header: $
> +

Incorrect header

[...]

> +
> +QA_PREBUILT="
> + usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_x86_linux.bin
> + usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_armle_linux.bin
> + usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_x86_solaris.bin
> + usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_x64_linux.bin
> + usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_x64_linux_dll.bin
> + usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_x86_bsd.bin
> + usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_x64_bsd.bin
> + usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_mipsbe_linux.bin
> + usr/$(get_libdir)/${PN}${SLOT}/data/templates/template_mipsle_linux.bin
> + usr/$(get_libdir)/${PN}${SLOT}/data/meterpreter/msflinker_linux_x86.bin
> + usr/$(get_libdir)/${PN}${SLOT}/data/meterpreter/ext_server_sniffer.lso
> + 
> usr/$(get_libdir)/${PN}${SLOT}/data/meterpreter/ext_server_networkpug.lso
> + usr/$(get_libdir)/${PN}${SLOT}/data/meterpreter/ext_server_stdapi.lso
> + usr/$(get_libdir)/${PN}${SLOT}/data/exploits/CVE-2013-2171.bin
> + usr/$(get_libdir)/${PN}${SLOT}/data/exploits/CVE-2014-3153.elf
> + usr/$(get_libdir)/${PN}${SLOT}/data/android/libs/x86/libndkstager.so
> + usr/$(get_libdir)/${PN}${SLOT}/data/android/libs/mips/libndkstager.so
> + usr/$(get_libdir)/${PN}${SLOT}/data/android/libs/armeabi/libndkstager.so
> + "
> +

I think $(get_libdir) is not allowed in global scope and breaks metadata.

You can use probably 'usr/lib*/...'

[...]

Re: [gentoo-dev] Re: [gentoo-commits] repo/gentoo:master commit in: net-analyzer/metasploit/

2015-10-09 Thread Alexis Ballier 
On Fri, 9 Oct 2015 17:42:23 +0200
hasufell  wrote:


> > +
> > +QA_PREBUILT="
[...]
> I think $(get_libdir) is not allowed in global scope and breaks
> metadata.

I don't think QA_PREBUILT is part of metadata.

> You can use probably 'usr/lib*/...'

But this is probably better, e.g. if these are x86 binaries installed
on amd64, I don't think the above (snipped) QA_PREBUILT will match.