Re: [gentoo-dev] Re: New eclass osgi.eclass

2007-12-20 Thread Jean-Noël Rivasseau
Hello all, I have a new version of the eclass ready, with much of the remarks addressed. It now goes by the name java-osgi and in the new form, should be ready to enter the tree. I fixed the performance problem I mentionned earlier, cleaned up the eclass API, and simplified the code almost

Re: [gentoo-dev] Re: New eclass osgi.eclass

2007-12-07 Thread Jean-Noël Rivasseau
Thanks all for this feedback. I think this is sufficient to warrant some modifications as suggested, and I propose to postpone the inclusion in tree a little bit. Regarding performance, there is an important point to note as IMHO it is much more penalizing than using basename or such. The fact

Re: [gentoo-dev] Re: New eclass osgi.eclass

2007-12-07 Thread Petteri Räty
Jean-Noël Rivasseau kirjoitti: The fact that I use the jar utility to unzip a file, combined with the fact that jar does not have an option to specify a destination directory, is troublesome. I have to copy the .jar file to the destination directory and then remove it. This .jar file can be

Re: [gentoo-dev] Re: New eclass osgi.eclass

2007-12-06 Thread Petteri Räty
Steve Long kirjoitti: Alistair Bush wrote: Im sure Elvanor can't wait for you constructive feedback on his eclass and depending on your feedback the eclass will enter the tree this weekend. A couple of very minor performance points, which I think are more significant in eclasses. Firstly

[gentoo-dev] Re: New eclass osgi.eclass

2007-12-05 Thread Steve Long
Alistair Bush wrote: Im sure Elvanor can't wait for you constructive feedback on his eclass and depending on your feedback the eclass will enter the tree this weekend. A couple of very minor performance points, which I think are more significant in eclasses. Firstly the basename thing Donnie