Re: [gentoo-dev] Re: Patch applying function for EAPI 6

2013-08-23 Thread Ulrich Mueller
> On Fri, 23 Aug 2013, Michał Górny wrote: >> Yes, it will be an array. But I guess we will support a space >> separated list in addition, for consistency with DOCS. > This would be very bad since most patches use ${FILESDIR}. > Putting that in a plain string sounds like final bullet in > whi

Re: [gentoo-dev] Re: Patch applying function for EAPI 6

2013-08-23 Thread Michał Górny
Dnia 2013-08-23, o godz. 13:35:11 Ulrich Mueller napisał(a): > > I take it PATCHES variable will be a bash array, or space separated > > list? > > Yes, it will be an array. But I guess we will support a space > separated list in addition, for consistency with DOCS. This would be very bad since

Re: [gentoo-dev] Re: Patch applying function for EAPI 6

2013-08-23 Thread Ulrich Mueller
> On Fri, 23 Aug 2013, Brian Dolbec wrote: >> Only suggestion so far is "dopatch". I don't really like it because >> other do* functions are called from src_install. But if nobody >> comes up with a better name, then it will be dopatch. > What about: > srcpatch() Hm, that looks like a phase

Re: [gentoo-dev] Re: Patch applying function for EAPI 6

2013-08-23 Thread Brian Dolbec
On Fri, 2013-08-23 at 11:45 +0200, Ulrich Mueller wrote: > > On Sun, 18 Aug 2013, Ulrich Mueller wrote: > > For EAPI 6, introduction of a patch applying function to the package > manager itself is being discussed. This would serve two purposes: > - support for PATCHES variable in a default src

Re: [gentoo-dev] Re: Patch applying function for EAPI 6

2013-08-23 Thread Michał Górny
Dnia 2013-08-23, o godz. 11:45:57 Ulrich Mueller napisał(a): > > 2. Should the function do automatic -p* detection, or should it > >default to -p1? Both would be overridable by an explicit -p* > >option. There are good arguments for either variant > >(see the above-mentioned bug). >

[gentoo-dev] Re: Patch applying function for EAPI 6

2013-08-23 Thread Ulrich Mueller
> On Sun, 18 Aug 2013, Ulrich Mueller wrote: > For EAPI 6, introduction of a patch applying function to the package > manager itself is being discussed. This would serve two purposes: > - support for PATCHES variable in a default src_install phase > - a function to apply user patches > In bug