Re: [gentoo-dev] Re: Re: [gentoo-commits] gentoo-x86 commit in net-analyzer/wireshark: wireshark-1.6.2.ebuild ChangeLog wireshark-1.4.9.ebuild wireshark-1.4.7.ebuild wireshark-1.6.0_rc1.ebuild wiresha

2011-10-10 Thread Peter Volkov
В Втр, 13/09/2011 в 11:53 +0200, Diego Elio Pettenò пишет:
> Il giorno mar, 13/09/2011 alle 10.28 +0100, Ciaran McCreesh ha scritto:
> > In that case blocking just old versions is wrong, since if your
> > installed version is broken and you try to reinstall, you'll need to
> > uninstall first too.

wireshark relinks against system wsutil library during 'make DESTDIR=
${D} install', so once wireshark-1.6 is installed we have
libwsutil.so.1.0.0. There is nothing bad linking with correct library
version (even though binary came from previous version).

> It doesn't matter as much when it's the same version because then it
> would have the same soversion and thus it wouldn't cause _visible_
> trouble.
> 
> It might be interesting to note that it seems like rc4->final also
> causes the same problem.

Well, I can just drop _rc part in blocker. _rc versions were hardmasked
anyway.

> Just for completeness sake, this can usually be fixed/worked around by
> making sure to list just-built .la files _before_ the /usr libraries. I
> had to work that around on opensc before. PAM also suffers from the same
> issue _if_ the .la files are kept around.

Hm interesting. Actually I've tried to strace libtool and it have not
touched system .la files but since we drop .la anyway I'll recheck.

--
Peter.




Re: [gentoo-dev] Re: Re: [gentoo-commits] gentoo-x86 commit in net-analyzer/wireshark: wireshark-1.6.2.ebuild ChangeLog wireshark-1.4.9.ebuild wireshark-1.4.7.ebuild wireshark-1.6.0_rc1.ebuild wiresha

2011-09-13 Thread Ciaran McCreesh
On Tue, 13 Sep 2011 09:58:58 -0400
Mike Frysinger  wrote:
> > It would if the version on / is broken and you're reinstalling to
> > try to fix it.
> 
> a largely irrelevant edge case that cases little to no harm

But getting it right is easier than getting it wrong: just DEPEND block
the entire package, not a version range. There's no excuse not to do it
properly here.

-- 
Ciaran McCreesh


signature.asc
Description: PGP signature


Re: [gentoo-dev] Re: Re: [gentoo-commits] gentoo-x86 commit in net-analyzer/wireshark: wireshark-1.6.2.ebuild ChangeLog wireshark-1.4.9.ebuild wireshark-1.4.7.ebuild wireshark-1.6.0_rc1.ebuild wiresha

2011-09-13 Thread Mike Frysinger
On Tuesday, September 13, 2011 05:53:28 Diego Elio Pettenò wrote:
> Il giorno mar, 13/09/2011 alle 10.28 +0100, Ciaran McCreesh ha scritto:
> > (Incidentally, there's a bug in libtool that causes it to randomly link
> > to stuff on / if you try to create an executable that links to both a
> > built library and an installed library. It's probably fairly common,
> > but people won't necessarily notice.)
> 
> Just for completeness sake, this can usually be fixed/worked around by
> making sure to list just-built .la files _before_ the /usr libraries. I
> had to work that around on opensc before. PAM also suffers from the same
> issue _if_ the .la files are kept around.

that's part of the issue.  the fix-relink patch that we carry in ELT-patches 
for ~8 years now is the other part.
-mike


signature.asc
Description: This is a digitally signed message part.


Re: [gentoo-dev] Re: Re: [gentoo-commits] gentoo-x86 commit in net-analyzer/wireshark: wireshark-1.6.2.ebuild ChangeLog wireshark-1.4.9.ebuild wireshark-1.4.7.ebuild wireshark-1.6.0_rc1.ebuild wiresha

2011-09-13 Thread Mike Frysinger
On Tuesday, September 13, 2011 06:24:51 Ciaran McCreesh wrote:
> On Tue, 13 Sep 2011 11:53:28 +0200 Diego Elio Pettenò wrote:
> > Il giorno mar, 13/09/2011 alle 10.28 +0100, Ciaran McCreesh ha scritto:
> > > In that case blocking just old versions is wrong, since if your
> > > installed version is broken and you try to reinstall, you'll need to
> > > uninstall first too.
> > 
> > It doesn't matter as much when it's the same version because then it
> > would have the same soversion and thus it wouldn't cause _visible_
> > trouble.
> 
> It would if the version on / is broken and you're reinstalling to try
> to fix it.

a largely irrelevant edge case that cases little to no harm
-mike


signature.asc
Description: This is a digitally signed message part.


Re: [gentoo-dev] Re: Re: [gentoo-commits] gentoo-x86 commit in net-analyzer/wireshark: wireshark-1.6.2.ebuild ChangeLog wireshark-1.4.9.ebuild wireshark-1.4.7.ebuild wireshark-1.6.0_rc1.ebuild wiresha

2011-09-13 Thread Ciaran McCreesh
On Tue, 13 Sep 2011 11:53:28 +0200
Diego Elio Pettenò  wrote:
> Il giorno mar, 13/09/2011 alle 10.28 +0100, Ciaran McCreesh ha
> scritto:
> > In that case blocking just old versions is wrong, since if your
> > installed version is broken and you try to reinstall, you'll need to
> > uninstall first too.
> 
> It doesn't matter as much when it's the same version because then it
> would have the same soversion and thus it wouldn't cause _visible_
> trouble.

It would if the version on / is broken and you're reinstalling to try
to fix it.

-- 
Ciaran McCreesh


signature.asc
Description: PGP signature