Re: [gentoo-dev] Should we allow picture files in the Portage tree?

2014-02-16 Thread Ulrich Mueller
> On Sun, 16 Feb 2014, Samuli Suominen wrote: > wasn't the whole argument for not allowing binary files in tree the > problems it causes w/ version control history, web interface, and > such? then, what problems does .xpm or .svg cause? none, far as I > know, so why disallow them? That seems

Re: [gentoo-dev] Should we allow picture files in the Portage tree?

2014-02-16 Thread Samuli Suominen
On 13/02/14 17:12, Ulrich Mueller wrote: > When rewriting the script scanning for binary files in the Portage > tree [1], I noticed that there are some 25 XPM and SVG image files, > with sizes up to 13 kB. > > For the time being, I've added exceptions for MIME types image/svg+xml > and image/x-xpm

Re: [gentoo-dev] Should we allow picture files in the Portage tree?

2014-02-15 Thread Alexander Berntsen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 On 13/02/14 16:12, Ulrich Mueller wrote: > Should we allow pictures if the image file format is a text file? Rather than having a hard rule for allowing or disallowing image files, we should evaluate the intention of a file. If it make sense to edit

Re: [gentoo-dev] Should we allow picture files in the Portage tree?

2014-02-15 Thread James Cloos
> "JAD" == Jason A Donenfeld writes: UM>> Should we allow pictures if the image file format is a text file? JAD> I think we should not. Even if you can open it in a text editor, JAD> you can't "read" it or interact with it in the same way that you JAD> can a text-based patch. That's not tru

Re: [gentoo-dev] Should we allow picture files in the Portage tree?

2014-02-13 Thread Rich Freeman
On Thu, Feb 13, 2014 at 10:30 AM, Kent Fredric wrote: > > On 14 February 2014 04:28, Anthony G. Basile wrote: >> >> 2) You want your vcs to show the diff in that file and you can make sense >> of that diff. > > > Though how many of them are "well formatted" SVGs, and how many of them are > singl

Re: [gentoo-dev] Should we allow picture files in the Portage tree?

2014-02-13 Thread Kent Fredric
On 14 February 2014 04:28, Anthony G. Basile wrote: > 2) You want your vcs to show the diff in that file and you can make sense > of that diff. > Though how many of them are "well formatted" SVGs, and how many of them are single-line SVG files without whitespace, such as linefeeds and appropria

Re: [gentoo-dev] Should we allow picture files in the Portage tree?

2014-02-13 Thread Anthony G. Basile
On 02/13/2014 10:24 AM, Jason A. Donenfeld wrote: On Thu, Feb 13, 2014 at 4:12 PM, Ulrich Mueller wrote: Should we allow pictures if the image file format is a text file? I think we should not. Even if you can open it in a text editor, you can't "read" it or interact with it in the same way th

Re: [gentoo-dev] Should we allow picture files in the Portage tree?

2014-02-13 Thread Jason A. Donenfeld
On Thu, Feb 13, 2014 at 4:12 PM, Ulrich Mueller wrote: > Should we allow pictures if the image file format is a text file? I think we should not. Even if you can open it in a text editor, you can't "read" it or interact with it in the same way that you can a text-based patch. For that reason, big

Re: [gentoo-dev] Should we allow picture files in the Portage tree?

2014-02-13 Thread Anthony G. Basile
On 02/13/2014 10:12 AM, Ulrich Mueller wrote: When rewriting the script scanning for binary files in the Portage tree [1], I noticed that there are some 25 XPM and SVG image files, with sizes up to 13 kB. For the time being, I've added exceptions for MIME types image/svg+xml and image/x-xpmi [2]

[gentoo-dev] Should we allow picture files in the Portage tree?

2014-02-13 Thread Ulrich Mueller
When rewriting the script scanning for binary files in the Portage tree [1], I noticed that there are some 25 XPM and SVG image files, with sizes up to 13 kB. For the time being, I've added exceptions for MIME types image/svg+xml and image/x-xpmi [2], but I think it would be better to clarify our