Re: [gentoo-dev] Usage of cp -i to prevent overwriting upstream files

2009-01-31 Thread Luca Barbato
Santiago M. Mola wrote: e) use a hook around unpack on your local system to detect new build.xml for a list of packages. AFAIK, checking changes is part of the bump process, so I think that's a check you can do either at hand, with a script (it's always a good thing to look for new files in

Re: [gentoo-dev] Usage of cp -i to prevent overwriting upstream files

2009-01-21 Thread Peter Volkov
В Втр, 20/01/2009 в 21:04 +0200, Petteri Räty пишет: So do you think: a) cp -i is fine No, interactivity is bad. b) this function should be added to eutils c) keep it restricted to java eclasses I don't remember/know any other cases where this function can be useful. So I think it's better

Re: [gentoo-dev] Usage of cp -i to prevent overwriting upstream files

2009-01-21 Thread Santiago M. Mola
El mar, 20-01-2009 a las 21:04 +0200, Petteri Räty escribió: d) something else e) use a hook around unpack on your local system to detect new build.xml for a list of packages. AFAIK, checking changes is part of the bump process, so I think that's a check you can do either at hand, with a

[gentoo-dev] Usage of cp -i to prevent overwriting upstream files

2009-01-20 Thread Petteri Räty
Many times upstream Java projects don't include build.xml files or proper build systems so we include build.xml files in $FILESDIR. In case upstream some day adds one we usually use cp -i to detect if upstream adds this file in new versions. If devs do their job properly, this will never show to

Re: [gentoo-dev] Usage of cp -i to prevent overwriting upstream files

2009-01-20 Thread Ferris McCormick
On Tue, 2009-01-20 at 21:04 +0200, Petteri Räty wrote: Many times upstream Java projects don't include build.xml files or proper build systems so we include build.xml files in $FILESDIR. In case upstream some day adds one we usually use cp -i to detect if upstream adds this file in new

Re: [gentoo-dev] Usage of cp -i to prevent overwriting upstream files

2009-01-20 Thread Petteri Räty
Ferris McCormick wrote: On Tue, 2009-01-20 at 21:04 +0200, Petteri Räty wrote: Many times upstream Java projects don't include build.xml files or proper build systems so we include build.xml files in $FILESDIR. In case upstream some day adds one we usually use cp -i to detect if upstream adds

Re: [gentoo-dev] Usage of cp -i to prevent overwriting upstream files

2009-01-20 Thread Ferris McCormick
On Tue, 2009-01-20 at 21:37 +0200, Petteri Räty wrote: Ferris McCormick wrote: On Tue, 2009-01-20 at 21:04 +0200, Petteri Räty wrote: Many times upstream Java projects don't include build.xml files or proper build systems so we include build.xml files in $FILESDIR. In case upstream some

Re: [gentoo-dev] Usage of cp -i to prevent overwriting upstream files

2009-01-20 Thread Jan Kundrát
Ferris McCormick wrote: 'cp -i' will at least ask a question, and I find that marginally better --- it's confusing, but at least it says something. But it seems to me that if we hit this case, no one (including the package owner) knows which .xml file to use, so stopping the build makes sense,

Re: [gentoo-dev] Usage of cp -i to prevent overwriting upstream files

2009-01-20 Thread Ferris McCormick
On Tue, 20 Jan 2009 23:50:47 +0100 Jan Kundrát j...@gentoo.org wrote: Ferris McCormick wrote: 'cp -i' will at least ask a question, and I find that marginally better --- it's confusing, but at least it says something. But it seems to me that if we hit this case, no one (including the

Re: [gentoo-dev] Usage of cp -i to prevent overwriting upstream files

2009-01-20 Thread Jeremy Olexa
On Tue, Jan 20, 2009 at 5:40 PM, Ferris McCormick fmc...@gentoo.org wrote: On Tue, 20 Jan 2009 23:50:47 +0100 Jan Kundrát j...@gentoo.org wrote: Ferris McCormick wrote: 'cp -i' will at least ask a question, and I find that marginally better --- it's confusing, but at least it says