Re: [gentoo-dev] linux-mod.eclass: Check for !TRIM_UNUSED_KSYMS

2016-11-30 Thread Mike Gilbert
On Wed, Nov 30, 2016 at 6:16 AM, Jeroen Roovers  wrote:
> On Tue, 29 Nov 2016 10:39:04 -0500
> Mike Gilbert  wrote:
>
>> On Tue, Nov 29, 2016 at 9:14 AM, Jeroen Roovers 
>> wrote:
>> > --- a/eclass/linux-mod.eclass
>> > +++ b/eclass/linux-mod.eclass
>> > @@ -566,6 +566,9 @@ linux-mod_pkg_setup() {
>> > return
>> > fi
>> >
>> > +   # External modules use kernel symbols (bug #591832)
>> > +   export CONFIG_CHECK+=" !TRIM_UNUSED_KSYMS"
>> > +
>> > linux-info_pkg_setup;
>> > require_configured_kernel
>> > check_kernel_built;
>> >
>>
>> There is no need to export CONFIG_CHECK to the environment here.
>
> Interesting. The same is done in linux-mod_pkg_setup_binary(), so which?

As far as I know, it's a bash variable used by functions defined in
linux-info.eclass. It does not need to be passed to any child
processes, and so it does not need to be defined in the environment.

The export in linux-mod_pkg_setup_binary is unnecessary as well.



Re: [gentoo-dev] linux-mod.eclass: Check for !TRIM_UNUSED_KSYMS

2016-11-30 Thread Jeroen Roovers
On Tue, 29 Nov 2016 10:39:04 -0500
Mike Gilbert  wrote:

> On Tue, Nov 29, 2016 at 9:14 AM, Jeroen Roovers 
> wrote:
> > --- a/eclass/linux-mod.eclass
> > +++ b/eclass/linux-mod.eclass
> > @@ -566,6 +566,9 @@ linux-mod_pkg_setup() {
> > return
> > fi
> >
> > +   # External modules use kernel symbols (bug #591832)
> > +   export CONFIG_CHECK+=" !TRIM_UNUSED_KSYMS"
> > +
> > linux-info_pkg_setup;
> > require_configured_kernel
> > check_kernel_built;
> >  
> 
> There is no need to export CONFIG_CHECK to the environment here.

Interesting. The same is done in linux-mod_pkg_setup_binary(), so which?


 jer



Re: [gentoo-dev] linux-mod.eclass: Check for !TRIM_UNUSED_KSYMS

2016-11-29 Thread Mike Gilbert
On Tue, Nov 29, 2016 at 9:14 AM, Jeroen Roovers  wrote:
> --- a/eclass/linux-mod.eclass
> +++ b/eclass/linux-mod.eclass
> @@ -566,6 +566,9 @@ linux-mod_pkg_setup() {
> return
> fi
>
> +   # External modules use kernel symbols (bug #591832)
> +   export CONFIG_CHECK+=" !TRIM_UNUSED_KSYMS"
> +
> linux-info_pkg_setup;
> require_configured_kernel
> check_kernel_built;
>

There is no need to export CONFIG_CHECK to the environment here.



[gentoo-dev] linux-mod.eclass: Check for !TRIM_UNUSED_KSYMS

2016-11-29 Thread Jeroen Roovers
--- a/eclass/linux-mod.eclass
+++ b/eclass/linux-mod.eclass
@@ -566,6 +566,9 @@ linux-mod_pkg_setup() {
return
fi

+   # External modules use kernel symbols (bug #591832)
+   export CONFIG_CHECK+=" !TRIM_UNUSED_KSYMS"
+
linux-info_pkg_setup;
require_configured_kernel
check_kernel_built;