Re: [gentoo-dev] new eclass: tmpfiles.eclass round 4

2016-11-30 Thread konsolebox
On Wed, Nov 30, 2016 at 8:35 PM, Mike Gilbert wrote: > On Wed, Nov 30, 2016 at 7:11 AM, konsolebox wrote: I also prefer some things this way: - Indent the contents of the first `if` block for consistency's sake, and less confusion.

Re: [gentoo-dev] new eclass: tmpfiles.eclass round 4

2016-11-30 Thread Mike Gilbert
On Wed, Nov 30, 2016 at 7:11 AM, konsolebox wrote: >>> I also prefer some things this way: >>> >>> - Indent the contents of the first `if` block for consistency's sake, >>> and less confusion. >> >> I disagree; indenting the entire eclass is silly and does not really >>

Re: [gentoo-dev] new eclass: tmpfiles.eclass round 4

2016-11-30 Thread konsolebox
On 11/30/16, Mike Gilbert wrote: > On Wed, Nov 30, 2016 at 3:38 AM, konsolebox wrote: >> - `[[ ${ROOT} == / ]] || return 0` seems to present a harmless false >> condition, and it doesn't show an error message. I would be helpful >> to have a comment

Re: [gentoo-dev] new eclass: tmpfiles.eclass round 4

2016-11-30 Thread Mike Gilbert
On Wed, Nov 30, 2016 at 3:38 AM, konsolebox wrote: > There are some things I noticed in the tmpfiles_process() function: > > - `type` currently also checks for functions, alias, and builtins, > besides executable files. If that's not intended, the `-P` option > should be

Re: [gentoo-dev] new eclass: tmpfiles.eclass round 4

2016-11-30 Thread konsolebox
There are some things I noticed in the tmpfiles_process() function: - `type` currently also checks for functions, alias, and builtins, besides executable files. If that's not intended, the `-P` option should be added. - What happens if neither systemd-tmpfiles nor opentmpfiles is found? -

[gentoo-dev] new eclass: tmpfiles.eclass round 4

2016-11-28 Thread William Hubbs
# Copyright 1999-2016 Gentoo Foundation # Distributed under the terms of the GNU General Public License v2 # $Id$ # @ECLASS: tmpfiles.eclass # @MAINTAINER: # Gentoo systemd project # William Hubbs # @AUTHOR: # Mike Gilbert # William