[gentoo-dev] repoman and checking for correct quoting

2007-11-10 Thread Krzysiek Pawlik 

Consider following part of scite-1.74.ebuild:

sed -i makefile \
-e 's#usr/local#usr#g' \
-e 's#/gnome/apps/Applications#/applications#' \
-e s#^CXXFLAGS=#CXXFLAGS=${CXXFLAGS} # \
-e s#^\(CXXFLAGS=.*\)-Os#\1# \
-e s#^CC =\(.*\)#CC = $(tc-getCXX)# \
-e 's#${D}##' \
-e 's#-g root#-g 0#' \
|| die error patching makefile

`repoman full' catches line -e 's#${D}##' \:

   app-editors/scite/scite-1.74.ebuild: Unquoted Variable on line: 41

It's purpose is to remove the ${D} from makefile, additionally ${D} is in single
quotes, so it will not be expanded - is it a bug in repoman check?

-- 
Krzysiek Pawlik   nelchael at gentoo.org   key id: 0xBC51
desktop-misc, desktop-dock, x86, java, apache, ppc...



signature.asc
Description: OpenPGP digital signature

Re: [gentoo-dev] repoman and checking for correct quoting

2007-11-10 Thread Zac Medico 
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Krzysiek Pawlik wrote:
 Consider following part of scite-1.74.ebuild:
 
   sed -i makefile \
   -e 's#usr/local#usr#g' \
   -e 's#/gnome/apps/Applications#/applications#' \
   -e s#^CXXFLAGS=#CXXFLAGS=${CXXFLAGS} # \
   -e s#^\(CXXFLAGS=.*\)-Os#\1# \
   -e s#^CC =\(.*\)#CC = $(tc-getCXX)# \
   -e 's#${D}##' \
   -e 's#-g root#-g 0#' \
   || die error patching makefile
 
 `repoman full' catches line -e 's#${D}##' \:
 
app-editors/scite/scite-1.74.ebuild: Unquoted Variable on line: 41
 
 It's purpose is to remove the ${D} from makefile, additionally ${D} is in 
 single
 quotes, so it will not be expanded - is it a bug in repoman check?

Yes, it seems like we need to add an exemption for variables inside
single quotes like that.

Zac
-BEGIN PGP SIGNATURE-
Version: GnuPG v2.0.7 (GNU/Linux)

iD8DBQFHNeYL/ejvha5XGaMRAkpqAJ4tQzDDhcRbfFFqbYhGM3jm+iO6ZACfdovW
+1DwScsWViapX7BJnD10lAM=
=BBQu
-END PGP SIGNATURE-
-- 
[EMAIL PROTECTED] mailing list

Re: [gentoo-dev] repoman and checking for correct quoting

2007-11-10 Thread Bo Ørsted Andresen 
On Sat, Nov 10, 2007 at 11:51:37AM +0100, Krzysiek Pawlik wrote:
 It's purpose is to remove the ${D} from makefile, additionally ${D} is in 
 single
 quotes, so it will not be expanded - is it a bug in repoman check?

What ${D} ? I see none in that makefile. Which is why I think a patch would be 
better in this case. A patch would actually tell you when half of the
substitutions don't match anything... I think this is a point worth making even
if it doesn't change your point.

-- 
Bo Andresen
-- 
[EMAIL PROTECTED] mailing list