Re: [gentoo-dev] Re: [PATCH] eclass/kernel-2.eclass: Remove use of tr in global scope

2017-08-31 Thread Ulrich Mueller
> On Thu, 31 Aug 2017, Michał Górny wrote: >> > @@ -1425,9 +1426,10 @@ detect_arch() { >> > COMPAT_URI="${!COMPAT_URI}" >> > >> > [[ -n ${COMPAT_URI} ]] && \ >> > - ARCH_URI="${ARCH_URI} $(echo ${LOOP_ARCH} | tr '[:upper:]' >> > '[:lower:]')? ( ${COMPAT_URI} )" >>

Re: [gentoo-portage-dev] [PATCH] ebuild.sh: Explicitly ban get_libdir in global scope

2017-08-31 Thread Michał Górny
W dniu śro, 30.08.2017 o godzinie 23∶36 -0700, użytkownik Zac Medico napisał: > On 08/30/2017 01:45 PM, Michał Górny wrote: > > W dniu śro, 30.08.2017 o godzinie 13∶35 -0700, użytkownik Zac Medico > > napisał: > > > On 08/30/2017 01:31 PM, Michał Górny wrote: > > > > W dniu śro, 30.08.2017 o

[gentoo-portage-dev] [PATCH] ebuild.sh: Fail on command-not-found in global scope

2017-08-31 Thread Michał Górny
The PMS specifies that ebuilds must not call external commands in global scope. We can not prevent that from happening at the moment since a few ebuilds in Gentoo are still doing that. Instead, start increasing strictness by explicitly failing if ebuilds call external commands that are not found.

[gentoo-dev] [PATCH v2] eclass/kernel-2.eclass: Remove use of tr in global scope

2017-08-31 Thread Mike Pagano
As per PMS remove calls to external command 'tr' in global scope See bug #629106. Signed-off-by: Mike Pagano --- eclass/kernel-2.eclass | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass index

Re: [gentoo-dev] [PATCH v2] eclass/kernel-2.eclass: Remove use of tr in global scope

2017-08-31 Thread Walter Dnes
On Thu, Aug 31, 2017 at 02:11:30PM -0400, Mike Pagano wrote > On Thu, Aug 31, 2017 at 07:27:10PM +0200, Micha?? Górny wrote: > > W dniu czw, 31.08.2017 o godzinie 12???33???-0400, u??ytkownik Mike Pagano > > napisa??: > > > As per PMS remove calls to external command 'tr' in global scope See bug

Re: [gentoo-dev] [PATCH v2] eclass/kernel-2.eclass: Remove use of tr in global scope

2017-08-31 Thread Michał Górny
W dniu czw, 31.08.2017 o godzinie 12∶33 -0400, użytkownik Mike Pagano napisał: > As per PMS remove calls to external command 'tr' in global scope See bug > #629106. Closes: https://bugs.gentoo.org/629106 (assuming you want the bug closed) > > Signed-off-by: Mike Pagano >

Re: [gentoo-portage-dev] [PATCH] ebuild.sh: Fail on command-not-found in global scope

2017-08-31 Thread Zac Medico
On 08/31/2017 07:56 AM, Michał Górny wrote: > The PMS specifies that ebuilds must not call external commands in global > scope. We can not prevent that from happening at the moment since a few > ebuilds in Gentoo are still doing that. > > Instead, start increasing strictness by explicitly failing

Re: [gentoo-dev] [PATCH v2] eclass/kernel-2.eclass: Remove use of tr in global scope

2017-08-31 Thread Ulrich Mueller
> On Thu, 31 Aug 2017, Mike Pagano wrote: > + declare -l LOOP_ARCH_L=${LOOP_ARCH} > [...] > + declare -u TC_ARCH_KERNEL=$(tc-arch-kernel); This is not legal in EAPI 5 or earlier, because the -l and -u options of declare did not exist in bash 3.2. So it is no

Re: [gentoo-portage-dev] [PATCH] ebuild.sh: Fail on command-not-found in global scope

2017-08-31 Thread Michał Górny
W dniu czw, 31.08.2017 o godzinie 10∶42 -0700, użytkownik Zac Medico napisał: > On 08/31/2017 07:56 AM, Michał Górny wrote: > > The PMS specifies that ebuilds must not call external commands in global > > scope. We can not prevent that from happening at the moment since a few > > ebuilds in Gentoo

Re: [gentoo-dev] [PATCH v2] eclass/kernel-2.eclass: Remove use of tr in global scope

2017-08-31 Thread Mike Pagano
On Thu, Aug 31, 2017 at 07:27:10PM +0200, Michał Górny wrote: > W dniu czw, 31.08.2017 o godzinie 12∶33 -0400, użytkownik Mike Pagano > napisał: > > As per PMS remove calls to external command 'tr' in global scope See bug > > #629106. > > Closes: https://bugs.gentoo.org/629106 > > (assuming you

Re: [gentoo-dev] [PATCH v2] eclass/kernel-2.eclass: Remove use of tr in global scope

2017-08-31 Thread Mike Gilbert
On Thu, Aug 31, 2017 at 2:53 PM, Walter Dnes wrote: > On Thu, Aug 31, 2017 at 02:11:30PM -0400, Mike Pagano wrote >> On Thu, Aug 31, 2017 at 07:27:10PM +0200, Micha?? Górny wrote: >> > W dniu czw, 31.08.2017 o godzinie 12???33???-0400, u??ytkownik Mike Pagano >> > napisa??:

[gentoo-portage-dev] [PATCH] ebuild.sh: Completely ban external commands in global scope

2017-08-31 Thread Michał Górny
Set PATH to /dev/null when sourcing the ebuild for dependency resolution in order to prevent shell from finding external commands via PATH lookup. While this does not prevent executing programs via full path, it should catch the majority of accidental uses. Closes:

Re: [gentoo-dev] Last-rites: app-arch/unrar-gpl

2017-08-31 Thread Alexander Berntsen
Just a note in case anyone is relying on this package for RAR files; check out unar. It's LGPL, and works for e.g. RARv3. -- Alexander berna...@gentoo.org https://secure.plaimi.net/~alexander signature.asc Description: OpenPGP digital signature

Re: [gentoo-dev] Last-rites: app-arch/unrar-gpl

2017-08-31 Thread Vladimir Romanov
> Give me a RAR5, and I can test it for you. I'm sorry, not RAR5, but RAR4. I've attached "old" rar_v3.rar and "new" rar_v4.rar. rar_v3.rar Description: application/rar rar_v4.rar Description: application/rar

Re: [gentoo-dev] Last-rites: app-arch/unrar-gpl

2017-08-31 Thread Alexander Berntsen
On 31/08/17 09:49, Vladimir Romanov wrote: > I've attached "old" rar_v3.rar and "new" rar_v4.rar. Works fine. :) -- Alexander berna...@gentoo.org https://secure.plaimi.net/~alexander signature.asc Description: OpenPGP digital signature

Re: [gentoo-portage-dev] [PATCH] ebuild.sh: Explicitly ban get_libdir in global scope

2017-08-31 Thread Zac Medico
On 08/30/2017 01:45 PM, Michał Górny wrote: > W dniu śro, 30.08.2017 o godzinie 13∶35 -0700, użytkownik Zac Medico > napisał: >> On 08/30/2017 01:31 PM, Michał Górny wrote: >>> W dniu śro, 30.08.2017 o godzinie 10∶48 -0700, użytkownik Zac Medico >>> napisał: On 08/30/2017 02:06 AM, Michał

Re: [gentoo-dev] Last-rites: app-arch/unrar-gpl

2017-08-31 Thread Alexander Berntsen
On 31/08/17 09:37, Vladimir Romanov wrote: > But does it work for RAR5? Give me a RAR5, and I can test it for you. -- Alexander berna...@gentoo.org https://secure.plaimi.net/~alexander signature.asc Description: OpenPGP digital signature

Re: [gentoo-dev] Last-rites: app-arch/unrar-gpl

2017-08-31 Thread Vladimir Romanov
But does it work for RAR5? 31 авг. 2017 г. 10:05 пользователь "Alexander Berntsen" написал: > Just a note in case anyone is relying on this package for RAR files; > check out unar. It's LGPL, and works for e.g. RARv3. > -- > Alexander > berna...@gentoo.org >

Re: [gentoo-dev] Last-rites: app-arch/unrar-gpl

2017-08-31 Thread Vladimir Romanov
> Works fine. :) Well, it's good :)