Re: [gentoo-dev] [PATCH 4/6] kernel-install.eclass: Improve failed install error messages

2021-01-13 Thread Michał Górny
On Wed, 2021-01-13 at 15:49 +0100, Ulrich Mueller wrote: > > > > > > On Wed, 13 Jan 2021, Michał Górny wrote: > > + local success= > > + while :; do > > + mount-boot_pkg_preinst > > + > > + local image_path=$(dist-kernel_get_image_path) > > + if use initramfs;

Re: [gentoo-dev] [PATCH 5/6] dist-kernel-utils.eclass: Support dracut's uefi=yes option

2021-01-13 Thread Michał Górny
On Wed, 2021-01-13 at 11:47 -0600, Matthew Thode wrote: > On 21-01-13 15:35:15, Michał Górny wrote: > > Support dracut's uefi=yes configuration option that creates a combined > > UEFI stub, kernel and initramfs in a single UEFI executable. If such > > an output is detected, install it in place of

Re: [gentoo-dev] [PATCH 5/6] dist-kernel-utils.eclass: Support dracut's uefi=yes option

2021-01-13 Thread Matthew Thode
On 21-01-13 15:35:15, Michał Górny wrote: > Support dracut's uefi=yes configuration option that creates a combined > UEFI stub, kernel and initramfs in a single UEFI executable. If such > an output is detected, install it in place of the actual kernel image > and stub out the duplicate initrd to

Re: [gentoo-dev] [PATCH 4/6] kernel-install.eclass: Improve failed install error messages

2021-01-13 Thread Michał Górny
On Wed, 2021-01-13 at 21:53 +0100, Ulrich Mueller wrote: > > > > > > On Wed, 13 Jan 2021, Michał Górny wrote: > > > > Looks like this loop can run only once, so it is redundant? > > > It's the old C trick for convenient error handling. > > Newfangled contraptions. What's wrong with goto? :) >

Re: [gentoo-dev] [PATCH 5/6] dist-kernel-utils.eclass: Support dracut's uefi=yes option

2021-01-13 Thread Emily Rowlands
On 13/01/2021 14:35, Michał Górny wrote: > @@ -85,6 +97,23 @@ dist-kernel_install_kernel() { > local image=${2} > local map=${3} > > + # if dracut is used in eufi=yes mode, initrd will actually Minor typo: this should be "uefi=yes", rather than eufi. Emily Rowlands

Re: [gentoo-dev] [PATCH 4/6] kernel-install.eclass: Improve failed install error messages

2021-01-13 Thread Ulrich Mueller
> On Wed, 13 Jan 2021, Michał Górny wrote: >> Looks like this loop can run only once, so it is redundant? > It's the old C trick for convenient error handling. Newfangled contraptions. What's wrong with goto? :) > Do you have any other suggestion? I suppose we could use a nested >

Re: [gentoo-dev] ml project created

2021-01-13 Thread Sam James
> On 12 Jan 2021, at 19:24, Alfredo Tupone wrote: > > As I have interest on lot of ebuild on dev-ml, and most of them are not > managed by any project, I have created a project to handle them. > Thanks Alfredo, I’m in and I joined #gentoo-ml too. > I have build

Re: [gentoo-dev] [PATCH] eclass/lua-utils.eclass: remove EPREFIX from exported module paths

2021-01-13 Thread James Le Cuirot
On Mon, 11 Jan 2021 11:01:33 -0600 William Hubbs wrote: > Bug: https://bugs.gentoo.org/762769 > Signed-off-by: William Hubbs > --- > eclass/lua-utils.eclass | 23 ++- > 1 file changed, 18 insertions(+), 5 deletions(-) > > diff --git a/eclass/lua-utils.eclass

Re: [gentoo-dev] [PATCH 5/6] dist-kernel-utils.eclass: Support dracut's uefi=yes option

2021-01-13 Thread Michał Górny
On Wed, 2021-01-13 at 19:01 +, Emily Rowlands wrote: > On 13/01/2021 14:35, Michał Górny wrote: > > @@ -85,6 +97,23 @@ dist-kernel_install_kernel() { > >   local image=${2} > >   local map=${3} > >   > > > > + # if dracut is used in eufi=yes mode, initrd will actually > > Minor typo:

Re: [gentoo-dev] ml project created

2021-01-13 Thread Alexey Sokolov
Hi, that wiki page says it just got deleted, by you вт, 12 янв. 2021 г. в 19:24, Alfredo Tupone : > > As I have interest on lot of ebuild on dev-ml, and most of them are not > managed by any project, I have created a project to handle them. > > I have build https://wiki.gentoo.org/wiki/Project:Ml

Re: [gentoo-dev] ml project created

2021-01-13 Thread Francesco Turco
On Wed, Jan 13, 2021, at 09:49, Alexey Sokolov wrote: > Hi, that wiki page says it just got deleted, by you Please see: https://wiki.gentoo.org/wiki/Project:ML

[gentoo-dev] [PATCH 2/6] kernel-install.eclass: Update symlink before installing

2021-01-13 Thread Michał Górny
Update symlink before actually installing the kernel. This primarily ensures that module rebuilds triggered by the upgrade will work correctly even if postinst fails. Besides, pkg_config() retries installing the kernel but does not update the symlink. Signed-off-by: Michał Górny ---

[gentoo-dev] [PATCH 0/6] kernel-install.eclass: dracut uefi=yes support + improved error handling

2021-01-13 Thread Michał Górny
Hi, Here's another set of patches to dist-kernel eclasses. This includes: 1. Improving postinst/config error handling to clearly indicate how to retry via 'emerge --config'. The message now includes SLOT as well. 2. Adding support for uefi=yes in dracut, i.e. creating combined kernel

[gentoo-dev] [PATCH 4/6] kernel-install.eclass: Improve failed install error messages

2021-01-13 Thread Michał Górny
Support and use nonfatal to provide a detailed error message when kernel postinst fails, in particular the correct 'emerge --config' command. Signed-off-by: Michał Górny --- eclass/dist-kernel-utils.eclass | 4 ++-- eclass/kernel-install.eclass| 42 +++-- 2

[gentoo-dev] [PATCH 3/6] kernel-install.eclass: Include SLOT in --config suggestion

2021-01-13 Thread Michał Górny
Signed-off-by: Michał Górny --- eclass/kernel-install.eclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eclass/kernel-install.eclass b/eclass/kernel-install.eclass index 33ff69fc2528..cfd8ec0b7c58 100644 --- a/eclass/kernel-install.eclass +++

[gentoo-dev] [PATCH 1/6] kernel-install.eclass: Move common to kernel-install_install_all

2021-01-13 Thread Michał Górny
Move the code shared by pkg_postinst() and pkg_config() to a new kernel-install_install_all() function. After all, the purpose of pkg_config() is to repeat what pkg_postinst() does normally. Keeping it in a common function improves maintainability. Signed-off-by: Michał Górny ---

[gentoo-dev] [PATCH 5/6] dist-kernel-utils.eclass: Support dracut's uefi=yes option

2021-01-13 Thread Michał Górny
Support dracut's uefi=yes configuration option that creates a combined UEFI stub, kernel and initramfs in a single UEFI executable. If such an output is detected, install it in place of the actual kernel image and stub out the duplicate initrd to save space. Signed-off-by: Michał Górny ---

[gentoo-dev] [PATCH 6/6] kernel-install.eclass: Improve error message on /boot problems

2021-01-13 Thread Michał Górny
Use the newly-introduced mount-boot.eclass nonfatal support to amend the error message with the instruction to run 'emerge --config' rather than rebuild the whole kernel. Signed-off-by: Michał Górny --- eclass/kernel-install.eclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [gentoo-dev] [PATCH 4/6] kernel-install.eclass: Improve failed install error messages

2021-01-13 Thread Ulrich Mueller
> On Wed, 13 Jan 2021, Michał Górny wrote: > + local success= > + while :; do > + mount-boot_pkg_preinst > + > + local image_path=$(dist-kernel_get_image_path) > + if use initramfs; then > + # putting it alongside kernel image as