Re: [gentoo-dev] [PATCH 2/2] kernel-2.eclass: fix spelling

2022-04-15 Thread Mike Pagano
On 4/15/22 10:06, David Seifert wrote: Signed-off-by: David Seifert --- eclass/kernel-2.eclass | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass index 51dabc4562d..02c70422ee0 100644 --- a/eclass/kernel-2.eclass +++

Re: [gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60libtool-la (check for unnecessary .la files)

2022-04-15 Thread Michael Orlitzky
On Fri, 2022-04-15 at 09:40 +0100, Sam James wrote: > + > +   if grep -q "dev-libs/libltdl" <<<${RDEPEND}; then > +   # Nothing to do here > +   return > +   fi We should probably have delimiters around that atom to future-proof it against (say) dev-libs/libltdl2.

[gentoo-dev] [PATCH] java-utils-2.eclass: remove ebegin calls that lack eend calls

2022-04-15 Thread Mike Gilbert
Instead, echo the command we are about to run. Closes: https://bugs.gentoo.org/838475 Closes: https://bugs.gentoo.org/838478 Closes: https://bugs.gentoo.org/838481 Closes: https://bugs.gentoo.org/838487 Closes: https://bugs.gentoo.org/838490 Closes: https://bugs.gentoo.org/838493 Signed-off-by:

Re: [gentoo-dev] [PATCH v2] linux-info.eclass: Call ebegin, properly close with eend

2022-04-15 Thread Mike Pagano
On 4/15/22 06:29, Thomas Bracht Laumann Jespersen wrote: On 14/04 19:15, Mike wrote: On 4/13/22 06:05, Thomas Bracht Laumann Jespersen wrote: A recent QA check added to portage informs of eend being called without a preceding call to ebegin. This warning was emitted during pkg_setup for

[gentoo-dev] [PATCH 1/2] kernel-2.eclass: remove EAPI 6

2022-04-15 Thread David Seifert
Signed-off-by: David Seifert --- eclass/kernel-2.eclass | 26 -- 1 file changed, 12 insertions(+), 14 deletions(-) diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass index bd982d3a52c..51dabc4562d 100644 --- a/eclass/kernel-2.eclass +++ b/eclass/kernel-2.eclass

[gentoo-dev] [PATCH 2/2] kernel-2.eclass: fix spelling

2022-04-15 Thread David Seifert
Signed-off-by: David Seifert --- eclass/kernel-2.eclass | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass index 51dabc4562d..02c70422ee0 100644 --- a/eclass/kernel-2.eclass +++ b/eclass/kernel-2.eclass @@ -670,7 +670,7 @@ if

Re: [gentoo-dev] [PATCH] java-utils-2.eclass: remove ebegin calls that lack eend calls

2022-04-15 Thread David Seifert
On Fri, 2022-04-15 at 10:11 -0400, Mike Gilbert wrote: > Instead, echo the command we are about to run. > > Closes: https://bugs.gentoo.org/838475 > Closes: https://bugs.gentoo.org/838478 > Closes: https://bugs.gentoo.org/838481 > Closes: https://bugs.gentoo.org/838487 > Closes:

Re: [gentoo-dev] [PATCH] java-utils-2.eclass: remove ebegin calls that lack eend calls

2022-04-15 Thread Florian Schmaus
On 15/04/2022 17.43, Yuan Liao (Leo) wrote: noting is, unlike compilation of a C/C++ program, where each compiler […] a single invocation of javac usually involves putting _all_ Java source files' names into the command-line arguments. We do use javac's @argfiles, e.g., @sources.lst, some

Re: [gentoo-dev] [PATCH] java-utils-2.eclass: remove ebegin calls that lack eend calls

2022-04-15 Thread Yuan Liao (Leo)
> Instead, echo the command we are about to run. > > Closes: https://bugs.gentoo.org/838475 > Closes: https://bugs.gentoo.org/838478 > Closes: https://bugs.gentoo.org/838481 > Closes: https://bugs.gentoo.org/838487 > Closes: https://bugs.gentoo.org/838490 > Closes: https://bugs.gentoo.org/838493 >

[gentoo-dev] [PATCH] metadata/install-qa-check.d: add 60libtool-la (check for unnecessary .la files)

2022-04-15 Thread Sam James
Signed-off-by: Sam James --- metadata/install-qa-check.d/60libtool-la | 45 1 file changed, 45 insertions(+) create mode 100644 metadata/install-qa-check.d/60libtool-la diff --git a/metadata/install-qa-check.d/60libtool-la b/metadata/install-qa-check.d/60libtool-la