Re: [gentoo-dev] [PATCH 09/11] net-wireless/blueman: Invoke eautomake to fix py-compile script

[Ulrich Mueller]

> On Fri, 29 Jul 2022, Michał Górny wrote:

> --- a/net-wireless/blueman/blueman-2.3.1.ebuild
> +++ b/net-wireless/blueman/blueman-2.3.1.ebuild
> @@ -97,7 +97,7 @@ pkg_setup() {
>  }
>  
>  src_prepare() {
> - [[ ${PV} ==  ]] && eautoreconf
> + [[ ${PV} ==  ]] && eautoreconf || eautomake

So if eautoreconf returns with nonzero status, eautomake will be called?
Or does eautoreconf always return zero (I believe it does)?

However, I don't want to think about that when reading the code, so
could you make it an if-then-else statement instead?

Same for the live ebuild.

Ulrich


signature.asc
Description: PGP signature

[gentoo-dev] [PATCH 09/11] net-wireless/blueman: Invoke eautomake to fix py-compile script

[Michał Górny]

Signed-off-by: Michał Górny 
---
 net-wireless/blueman/blueman-2.3.1.ebuild | 2 +-
 net-wireless/blueman/blueman-.ebuild  | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/net-wireless/blueman/blueman-2.3.1.ebuild 
b/net-wireless/blueman/blueman-2.3.1.ebuild
index dbedcfc7eae6..997963609ec2 100644
--- a/net-wireless/blueman/blueman-2.3.1.ebuild
+++ b/net-wireless/blueman/blueman-2.3.1.ebuild
@@ -97,7 +97,7 @@ pkg_setup() {
 }
 
 src_prepare() {
-   [[ ${PV} ==  ]] && eautoreconf
+   [[ ${PV} ==  ]] && eautoreconf || eautomake
distutils-r1_src_prepare
 }
 
diff --git a/net-wireless/blueman/blueman-.ebuild 
b/net-wireless/blueman/blueman-.ebuild
index dbedcfc7eae6..997963609ec2 100644
--- a/net-wireless/blueman/blueman-.ebuild
+++ b/net-wireless/blueman/blueman-.ebuild
@@ -97,7 +97,7 @@ pkg_setup() {
 }
 
 src_prepare() {
-   [[ ${PV} ==  ]] && eautoreconf
+   [[ ${PV} ==  ]] && eautoreconf || eautomake
distutils-r1_src_prepare
 }
 
-- 
2.35.1