Re: [gentoo-dev] [PATCHES] multilib-build & multilib-minimal EAPI 6 patchset

[Doug Goldstein]

On 12/6/15 12:57 PM, Michał Górny wrote:
> Hi, everyone.
> 
> Here's a patchset for review. Changes:
> 
> 1. eclass-generated variables are read-only,
> 2. missing error checks (||die) added,
> 3. 'unset -f' used to wipe local and temporary functions from the env,
> 4. deprecated function QA warnings turned into bans for EAPI 6,
> 5. eutils inherit fixes/updates.
> 
> Please review. I've tested it on a set of randomly selected packages.
> 
> 

Its worth noting that you should probably be utilizing --cover-letter to
git format-patch to generate this.

-- 
Doug Goldstein



signature.asc
Description: OpenPGP digital signature

Re: [gentoo-dev] [PATCHES] multilib-build & multilib-minimal EAPI 6 patchset

[Michał Górny]

On Sun,  6 Dec 2015 19:57:45 +0100
Michał Górny  wrote:

> Hi, everyone.
> 
> Here's a patchset for review. Changes:
> 
> 1. eclass-generated variables are read-only,
> 2. missing error checks (||die) added,
> 3. 'unset -f' used to wipe local and temporary functions from the env,
> 4. deprecated function QA warnings turned into bans for EAPI 6,
> 5. eutils inherit fixes/updates.
> 
> Please review. I've tested it on a set of randomly selected packages.

Applied after following ulm's suggestions.

-- 
Best regards,
Michał Górny



pgpWvj6IYuFDF.pgp
Description: OpenPGP digital signature

[gentoo-dev] [PATCHES] multilib-build & multilib-minimal EAPI 6 patchset

[Michał Górny]

Hi, everyone.

Here's a patchset for review. Changes:

1. eclass-generated variables are read-only,
2. missing error checks (||die) added,
3. 'unset -f' used to wipe local and temporary functions from the env,
4. deprecated function QA warnings turned into bans for EAPI 6,
5. eutils inherit fixes/updates.

Please review. I've tested it on a set of randomly selected packages.