[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: vim.eclass

[Samuli Suominen]

eclass has ChangeLog file now.   any particular reason why you skipped it?

or is it not meant to be used yet / not mandatory to use yet? since most
people seem to skip it.

- Samuli

On 11/28/2011 08:13 PM, Jim Ramsay (lack) wrote:
 lack11/11/28 18:13:42
 
   Modified: vim.eclass
   Log:
   Migrating vim.eclass from bash-completion.eclass to 
 bash-completion-r1.eclass
   
   Also removing old blocker on 'app-vim/vimspell' which is no longer in the 
 tree.
 
 Revision  ChangesPath
 1.201eclass/vim.eclass
 
 file : 
 http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/vim.eclass?rev=1.201view=markup
 plain: 
 http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/vim.eclass?rev=1.201content-type=text/plain
 diff : 
 http://sources.gentoo.org/viewvc.cgi/gentoo-x86/eclass/vim.eclass?r1=1.200r2=1.201
 
 Index: vim.eclass
 ===
 RCS file: /var/cvsroot/gentoo-x86/eclass/vim.eclass,v
 retrieving revision 1.200
 retrieving revision 1.201
 diff -u -r1.200 -r1.201
 --- vim.eclass20 Aug 2011 15:46:21 -  1.200
 +++ vim.eclass28 Nov 2011 18:13:42 -  1.201
 @@ -1,6 +1,6 @@
  # Copyright 1999-2011 Gentoo Foundation
  # Distributed under the terms of the GNU General Public License v2
 -# $Header: /var/cvsroot/gentoo-x86/eclass/vim.eclass,v 1.200 2011/08/20 
 15:46:21 lack Exp $
 +# $Header: /var/cvsroot/gentoo-x86/eclass/vim.eclass,v 1.201 2011/11/28 
 18:13:42 lack Exp $
  
  # Authors:
  #Jim Ramsay l...@gentoo.org
 @@ -31,7 +31,7 @@
   PYTHON_USE_WITH_OPT=python
   PYTHON_USE_WITH=threads
  fi
 -inherit eutils vim-doc flag-o-matic versionator fdo-mime bash-completion 
 prefix python
 +inherit eutils vim-doc flag-o-matic versionator fdo-mime bash-completion-r1 
 prefix python
  
  HOMEPAGE=http://www.vim.org/;
  SLOT=0
 @@ -95,7 +95,6 @@
   acl? ( kernel_linux? ( sys-apps/acl ) )
   ruby?( =dev-lang/ruby-1.8* )
   !app-vim/align-30-r1
 - !app-vim/vimspell
   !app-vim/vimbuddy-0.9.1-r1
   !app-vim/autoalign-11
   !app-vim/supertab-0.41
 @@ -625,9 +624,9 @@
  
   # bash completion script, bug #79018.
   if [[ ${MY_PN} == vim-core ]] ; then
 - dobashcompletion ${FILESDIR}/xxd-completion xxd
 + newbashcomp ${FILESDIR}/xxd-completion xxd
   else
 - dobashcompletion ${FILESDIR}/${MY_PN}-completion ${MY_PN}
 + newbashcomp ${FILESDIR}/${MY_PN}-completion ${MY_PN}
   fi
   # We shouldn't be installing the ex or view man page symlinks, as they
   # are managed by eselect-vi
 @@ -723,12 +722,6 @@
  
   echo
  
 - # Display bash-completion message
 - if [[ ${MY_PN} == vim-core ]] ; then
 - export BASHCOMPLETION_NAME=xxd
 - fi
 - bash-completion_pkg_postinst
 -
   # Make convenience symlinks
   if [[ ${MY_PN} != vim-core ]] ; then
   # But only for vim/gvim, bug #252724
 
 
 
 

[gentoo-dev] Re: [gentoo-commits] gentoo-x86 commit in eclass: vim.eclass

[Jim Ramsay]

Samuli Suominen wrote:
 eclass has ChangeLog file now.   any particular reason why you skipped it?

Completely oblivious to its existence, that's all :)  I'll
(hopefully) remember it next time.

 or is it not meant to be used yet / not mandatory to use yet? since most
 people seem to skip it.

In my case it was entirely ignorance, and with no statistical
evidence to base my assertion I'll say that most other omissions
come from the same cause.

Though on the other hand you could argue that a Changelog for all
eclasses may be a bit overkill.  Most eclasses are not related to
one another, so reading the CVS history of the changes to a
single file is much more useful than having a big list of
unrelated changes.  A changelog becomes much more useful when
you need to make related commits to multiple files with a
non-atomic-commit system like CVS.

-- 
Jim Ramsay
Gentoo/Linux Developer (rox/fluxbox/gkrellm)