Re: [gentoo-dev] rdp vs rdesktop vs freerdp USE flags

2016-12-11 Thread Daniel Campbell
On 12/08/2016 06:10 AM, Doug Freed wrote:
> On Thu, Dec 8, 2016 at 7:38 AM, Andrew Savchenko  wrote:
>> Hi,
>>
>> On Thu, 08 Dec 2016 11:29:51 +0100 Pacho Ramos wrote:
>>> When looking at freerdp reverse deps I noticed we are using three different
>>> names for USE flags enabling freerdp support: rdp, rdesktop and freerdp
>>>
>>> rdesktop is the only one that is a global USE flag, even if it's used only 
>>> by
>>> two packages, the others are local USE flags that are enabling similar
>>> supports.
>>>
>>> What should we do? Move all to rdesktop?
>>
>> Move everything to rdp, since this one is most common; add it to
>> global flags and remove rdesktop from the list.
> 
> +1; RDP is the protocol, whereas freerdp/rdesktop is the
> implementation.  This allows one to later replace the dependency with
> an any-of or virtual, without needing to change the useflag.
> 
> -Doug
> dwfreed
> 
+1 here.

-- 
Daniel Campbell - Gentoo Developer
OpenPGP Key: 0x1EA055D6 @ hkp://keys.gnupg.net
fpr: AE03 9064 AE00 053C 270C  1DE4 6F7A 9091 1EA0 55D6



signature.asc
Description: OpenPGP digital signature


Re: [gentoo-dev] rdp vs rdesktop vs freerdp USE flags

2016-12-08 Thread Mike Gilbert
On Thu, Dec 8, 2016 at 9:10 AM, Doug Freed  wrote:
> On Thu, Dec 8, 2016 at 7:38 AM, Andrew Savchenko  wrote:
>> Hi,
>>
>> On Thu, 08 Dec 2016 11:29:51 +0100 Pacho Ramos wrote:
>>> When looking at freerdp reverse deps I noticed we are using three different
>>> names for USE flags enabling freerdp support: rdp, rdesktop and freerdp
>>>
>>> rdesktop is the only one that is a global USE flag, even if it's used only 
>>> by
>>> two packages, the others are local USE flags that are enabling similar
>>> supports.
>>>
>>> What should we do? Move all to rdesktop?
>>
>> Move everything to rdp, since this one is most common; add it to
>> global flags and remove rdesktop from the list.
>
> +1; RDP is the protocol, whereas freerdp/rdesktop is the
> implementation.  This allows one to later replace the dependency with
> an any-of or virtual, without needing to change the useflag.

"rdp" makes the most sense to me as well. That eliminates any
confusion over whether "rdesktop" means "remote desktop support", or
refers to net-misc/rdesktop.



Re: [gentoo-dev] rdp vs rdesktop vs freerdp USE flags

2016-12-08 Thread Doug Freed
On Thu, Dec 8, 2016 at 7:38 AM, Andrew Savchenko  wrote:
> Hi,
>
> On Thu, 08 Dec 2016 11:29:51 +0100 Pacho Ramos wrote:
>> When looking at freerdp reverse deps I noticed we are using three different
>> names for USE flags enabling freerdp support: rdp, rdesktop and freerdp
>>
>> rdesktop is the only one that is a global USE flag, even if it's used only by
>> two packages, the others are local USE flags that are enabling similar
>> supports.
>>
>> What should we do? Move all to rdesktop?
>
> Move everything to rdp, since this one is most common; add it to
> global flags and remove rdesktop from the list.

+1; RDP is the protocol, whereas freerdp/rdesktop is the
implementation.  This allows one to later replace the dependency with
an any-of or virtual, without needing to change the useflag.

-Doug
dwfreed



Re: [gentoo-dev] rdp vs rdesktop vs freerdp USE flags

2016-12-08 Thread Andrew Savchenko
Hi,

On Thu, 08 Dec 2016 11:29:51 +0100 Pacho Ramos wrote:
> When looking at freerdp reverse deps I noticed we are using three different
> names for USE flags enabling freerdp support: rdp, rdesktop and freerdp
> 
> rdesktop is the only one that is a global USE flag, even if it's used only by
> two packages, the others are local USE flags that are enabling similar
> supports. 
> 
> What should we do? Move all to rdesktop?

Move everything to rdp, since this one is most common; add it to
global flags and remove rdesktop from the list.
 
> Thanks
> 
>  $ grep -r net-misc/freerdp */*/*.ebuild
> dev-libs/weston/weston-1.11.0.ebuild: rdp? ( >=net-misc/freerdp-
> 1.1.0_beta1_p20130710 )
> dev-libs/weston/weston-1.9.0.ebuild:  rdp? ( >=net-misc/freerdp-
> 1.1.0_beta1_p20130710 )
> dev-libs/weston/weston-.ebuild:   rdp? ( >=net-misc/freerdp-
> 1.1.0_beta1_p20130710 )
> kde-apps/krdc/krdc-16.04.3.ebuild:rdesktop? ( >=net-misc/freerdp-
> 1.1.0_beta1[X] )
> kde-apps/krdc/krdc-16.08.3.ebuild:rdesktop? ( >=net-misc/freerdp-
> 1.1.0_beta1[X] )
> media-video/vlc/vlc-2.2.1-r1.ebuild:  rdp? ( >=net-misc/freerdp-
> 1.0.1:0=[client]  media-video/vlc/vlc-2.2.4.ebuild: rdp? ( >=net-misc/freerdp-
> 1.0.1:0=[client]  media-video/vlc/vlc-2.2..ebuild:  rdp? ( >=net-misc/freerdp-1.0.1:0= )
> media-video/vlc/vlc-.ebuild:  rdp? ( >=net-misc/freerdp-1.0.1:0= )
> net-misc/guacamole-server/guacamole-server-0.9.9.ebuild:  rdesktop? (
>  net-misc/remmina/remmina-1.2.0_rc15.ebuild:   freerdp? ( >=net-
> misc/freerdp-2 )
> net-misc/remmina/remmina-1.2.0_rc16.ebuild:   freerdp? ( >=net-
> misc/freerdp-2 )
> net-misc/remmina/remmina-1.2.0_rc3-r1.ebuild: >=net-misc/freerdp-
> 1.2
> net-misc/remmina/remmina-1.2.0_rc3-r1.ebuild:  net-misc/remmina/remmina-.ebuild: >=net-misc/freerdp-
> 1.1.0_beta1_p20130710
> net-misc/remmina/remmina-.ebuild:  net-misc/vinagre/vinagre-3.20.2.ebuild:   rdp? (  net-misc/vinagre/vinagre-3.22.0.ebuild:   rdp? (  net-misc/xrdp/xrdp-0.8.0-r1.ebuild:#  neutrinordp? ( net-misc/freerdp:0= )
> 


Best regards,
Andrew Savchenko


pgp6TJGtt8nPH.pgp
Description: PGP signature


[gentoo-dev] rdp vs rdesktop vs freerdp USE flags

2016-12-08 Thread Pacho Ramos
When looking at freerdp reverse deps I noticed we are using three different
names for USE flags enabling freerdp support: rdp, rdesktop and freerdp

rdesktop is the only one that is a global USE flag, even if it's used only by
two packages, the others are local USE flags that are enabling similar
supports. 

What should we do? Move all to rdesktop?

Thanks

 $ grep -r net-misc/freerdp */*/*.ebuild
dev-libs/weston/weston-1.11.0.ebuild:   rdp? ( >=net-misc/freerdp-
1.1.0_beta1_p20130710 )
dev-libs/weston/weston-1.9.0.ebuild:rdp? ( >=net-misc/freerdp-
1.1.0_beta1_p20130710 )
dev-libs/weston/weston-.ebuild: rdp? ( >=net-misc/freerdp-
1.1.0_beta1_p20130710 )
kde-apps/krdc/krdc-16.04.3.ebuild:  rdesktop? ( >=net-misc/freerdp-
1.1.0_beta1[X] )
kde-apps/krdc/krdc-16.08.3.ebuild:  rdesktop? ( >=net-misc/freerdp-
1.1.0_beta1[X] )
media-video/vlc/vlc-2.2.1-r1.ebuild:rdp? ( >=net-misc/freerdp-
1.0.1:0=[client] =net-misc/freerdp-
1.0.1:0=[client] =net-misc/freerdp-1.0.1:0= )
media-video/vlc/vlc-.ebuild:rdp? ( >=net-misc/freerdp-1.0.1:0= )
net-misc/guacamole-server/guacamole-server-0.9.9.ebuild:rdesktop? (
=net-
misc/freerdp-2 )
net-misc/remmina/remmina-1.2.0_rc16.ebuild: freerdp? ( >=net-
misc/freerdp-2 )
net-misc/remmina/remmina-1.2.0_rc3-r1.ebuild:   >=net-misc/freerdp-
1.2
net-misc/remmina/remmina-1.2.0_rc3-r1.ebuild:   =net-misc/freerdp-
1.1.0_beta1_p20130710
net-misc/remmina/remmina-.ebuild: