Re: [gentoo-dev] [PATCH] cvs.eclass: Fix CVS_RSH for app-shells/mksh

2021-07-05 Thread Ulrich Mueller
> On Mon, 05 Jul 2021, Haelwenn (lanodan) Monnier wrote: > [2021-07-05 13:43:27+0200] Ulrich Mueller: >> Also, the eclass should set PROPERTIES+=" interactive" in the "ext" >> case, because IIUC it will interactively call SSH_ASKPASS. > Well sure but wouldn't it be better to not have

Re: [gentoo-dev] [PATCH] cvs.eclass: Fix CVS_RSH for app-shells/mksh

2021-07-05 Thread Haelwenn (lanodan) Monnier
[2021-07-05 13:43:27+0200] Ulrich Mueller: > > On Mon, 05 Jul 2021, Haelwenn (lanodan) Monnier wrote: > > > if [[ ${ECVS_AUTH} == "ext" ]] ; then > > - #default to ssh > > - [[ -z ${CVS_RSH} ]] && export CVS_RSH="ssh" > > - if [[ ${CVS_RSH} != "ssh" ]] ; then > > - die

Re: [gentoo-dev] [PATCH] cvs.eclass: Fix CVS_RSH for app-shells/mksh

2021-07-05 Thread Ulrich Mueller
> On Mon, 05 Jul 2021, Haelwenn (lanodan) Monnier wrote: > if [[ ${ECVS_AUTH} == "ext" ]] ; then > - #default to ssh > - [[ -z ${CVS_RSH} ]] && export CVS_RSH="ssh" > - if [[ ${CVS_RSH} != "ssh" ]] ; then > - die "Support for ext auth with clients other than ssh has

Re: [gentoo-dev] [PATCH] cvs.eclass: Fix CVS_RSH for app-shells/mksh

2021-07-05 Thread Ulrich Mueller
> On Mon, 05 Jul 2021, Haelwenn (lanodan) Monnier wrote: > -# @SUPPORTED_EAPIS: 4 5 6 7 > +# @SUPPORTED_EAPIS: 5 6 7 Support EAPI 8 while at it? AFAICS it's a trivial update. > case ${EAPI:-0} in Just ${EAPI} here. > - 4|5|6) ;; > + 5|6) ;; > 7) BDEPEND="${DEPEND}";