Re: [gentoo-dev] [PATCH] cvs.eclass: Fix CVS_RSH for app-shells/mksh
> On Mon, 05 Jul 2021, Haelwenn (lanodan) Monnier wrote: > [2021-07-05 13:43:27+0200] Ulrich Mueller: >> Also, the eclass should set PROPERTIES+=" interactive" in the "ext" >> case, because IIUC it will interactively call SSH_ASKPASS. > Well sure but wouldn't it be better to not have SSH_ASKPASS? Sure, if it works without. signature.asc Description: PGP signature
Re: [gentoo-dev] [PATCH] cvs.eclass: Fix CVS_RSH for app-shells/mksh
[2021-07-05 13:43:27+0200] Ulrich Mueller:
> > On Mon, 05 Jul 2021, Haelwenn (lanodan) Monnier wrote:
>
> > if [[ ${ECVS_AUTH} == "ext" ]] ; then
> > - #default to ssh
> > - [[ -z ${CVS_RSH} ]] && export CVS_RSH="ssh"
> > - if [[ ${CVS_RSH} != "ssh" ]] ; then
> > - die "Support for ext auth with clients other than ssh has not
> > been implemented yet"
> > - fi
> > DEPEND+=" net-misc/openssh"
> > fi
>
> Also, the eclass should set PROPERTIES+=" interactive" in the "ext"
> case, because IIUC it will interactively call SSH_ASKPASS.
Well sure but wouldn't it be better to not have SSH_ASKPASS?
Re: [gentoo-dev] [PATCH] cvs.eclass: Fix CVS_RSH for app-shells/mksh
> On Mon, 05 Jul 2021, Haelwenn (lanodan) Monnier wrote:
> if [[ ${ECVS_AUTH} == "ext" ]] ; then
> - #default to ssh
> - [[ -z ${CVS_RSH} ]] && export CVS_RSH="ssh"
> - if [[ ${CVS_RSH} != "ssh" ]] ; then
> - die "Support for ext auth with clients other than ssh has not
> been implemented yet"
> - fi
> DEPEND+=" net-misc/openssh"
> fi
Also, the eclass should set PROPERTIES+=" interactive" in the "ext"
case, because IIUC it will interactively call SSH_ASKPASS.
signature.asc
Description: PGP signature
Re: [gentoo-dev] [PATCH] cvs.eclass: Fix CVS_RSH for app-shells/mksh
> On Mon, 05 Jul 2021, Haelwenn (lanodan) Monnier wrote:
> -# @SUPPORTED_EAPIS: 4 5 6 7
> +# @SUPPORTED_EAPIS: 5 6 7
Support EAPI 8 while at it? AFAICS it's a trivial update.
> case ${EAPI:-0} in
Just ${EAPI} here.
> - 4|5|6) ;;
> + 5|6) ;;
> 7) BDEPEND="${DEPEND}"; DEPEND="" ;;
> *) die "${ECLASS}: EAPI ${EAPI:-0} is not supported" ;;
> esac
> @@ -483,6 +478,12 @@ cvs_src_unpack() {
>
> [[ -z ${ECVS_MODULE} ]] && die "ERROR: CVS module not set, cannot
> continue."
>
> + #default to ssh
> + [[ -z ${CVS_RSH} ]] && export CVS_RSH="ssh"
> + if [[ ${CVS_RSH} != "ssh" ]] ; then
> + die "Support for ext auth with clients other than ssh has not
> been implemented yet"
> + fi
That's a strange logic (not your fault, it was like this before).
So CVS_RSH is taken from the user's environment? Why would one do that?
Also, if the user has (e.g.) CVS_RSH="/usr/bin/ssh" then the eclass will
fail?
Can we kill this with fire, please? :) Just use ssh always.
Ulrich
signature.asc
Description: PGP signature
