Re: [gentoo-dev] [PATCH] java-pkg-simple.eclass: respect SLOT="0" in JAVA_LAUNCHER_FILENAME

2023-05-29 Thread Ulrich Mueller 
> On Mon, 29 May 2023, Volkmar W Pogatzki wrote:

>> > -: "${JAVA_LAUNCHER_FILENAME:=${PN}-${SLOT}}"
>> > +if [[ ${SLOT} = 0 ]]; then
>> > +  JAVA_LAUNCHER_FILENAME="${PN}"
>> > +else
>> > +  JAVA_LAUNCHER_FILENAME="${PN}-${SLOT}"
>> > +fi
>> 
>> This will no longer allow overriding the variable in the ebuild
>> (at least not pre-inherit). Is this intentional?

> It exactly does what it's supposed to do.
> No clue about "not pre-inherit".

With the above, JAVA_LAUNCHER_FILENAME="foo" in the ebuild will work if
comes after the inherit line, but not if it is before it.

> How to sanitize?

As in your v2. :)


signature.asc
Description: PGP signature

Re: [gentoo-dev] [PATCH] java-pkg-simple.eclass: respect SLOT="0" in JAVA_LAUNCHER_FILENAME

2023-05-29 Thread Volkmar W. Pogatzki 
> Ulrich Mueller  hat am 26.05.2023 10:44 CEST geschrieben:
> 
>  
> > On Fri, 26 May 2023, Volkmar W Pogatzki wrote:
> 
> > -: "${JAVA_LAUNCHER_FILENAME:=${PN}-${SLOT}}"
> > +if [[ ${SLOT} = 0 ]]; then
> > +   JAVA_LAUNCHER_FILENAME="${PN}"
> > +else
> > +   JAVA_LAUNCHER_FILENAME="${PN}-${SLOT}"
> > +fi
> 
> This will no longer allow overriding the variable in the ebuild
> (at least not pre-inherit). Is this intentional?
> 
> Ulrich

It exactly does what it's supposed to do.
No clue about "not pre-inherit". How to sanitize?
--
Volkmar W. Pogatzki

Re: [gentoo-dev] [PATCH] java-pkg-simple.eclass: respect SLOT="0" in JAVA_LAUNCHER_FILENAME

2023-05-26 Thread Ulrich Mueller 
> On Fri, 26 May 2023, Volkmar W Pogatzki wrote:

> -: "${JAVA_LAUNCHER_FILENAME:=${PN}-${SLOT}}"
> +if [[ ${SLOT} = 0 ]]; then
> + JAVA_LAUNCHER_FILENAME="${PN}"
> +else
> + JAVA_LAUNCHER_FILENAME="${PN}-${SLOT}"
> +fi

This will no longer allow overriding the variable in the ebuild
(at least not pre-inherit). Is this intentional?

Ulrich


signature.asc
Description: PGP signature