Re: [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace
On Fri, Oct 11, 2019 at 11:28:48AM -0700, Alec Warner wrote: >On Thu, Oct 10, 2019 at 3:04 AM Mike Pagano <[1]mpag...@gentoo.org> >wrote: > > On Wed, Oct 09, 2019 at 06:23:06PM -0700, Alec Warner wrote: > >  On Wed, Oct 9, 2019 at 10:01 AM Mike Pagano > <[1][2]mpag...@gentoo.org> > >  wrote: > > > >   This change will support moving the genpatches tarballs > from > >   /space/distfiles-local to > >   the devspace ~developer/public_html/dist/genpatches > > > >  I think it would help if you discussed why we were making > this change. > >  (I mean I can guess why, but it's not obvious.) > >  -A > >Â Â Ä > I was informed that use of /space/distfiles-local is deprecated in > favor > of devspace. > [3]https://devmanual.gentoo.org/general-concepts/mirrors/index.html > >That policy was made in 2011; so clearly it's not super urgent nor >stringently applied. Which is to say, I'm not sure it needs to be a >policy. >-A > Sounds like maybe a separate thread you can start to debate the policy. I was called out by infra on IRC to do this, so I did it. I have no horse in this race. > > > > >   Signed-off-by: Mike Pagano <[2][4]mpag...@gentoo.org> > >   --- > >Â Â Â Ä eclass/kernel-2.eclass | 4 +++- > >Â Â Â Ä 1 file changed, 3 insertions(+), 1 deletion(-) > >   diff --git a/eclass/kernel-2.eclass > b/eclass/kernel-2.eclass > >   index c5f35cd3e..0bc4f35de 100644 > >   --- a/eclass/kernel-2.eclass > >   +++ b/eclass/kernel-2.eclass > >   @@ -295,7 +295,9 @@ handle_genpatches() { > >   Ä Ä Ä Ä Ä Ä Ä Ä Ä Ä Ä Ä > UNIPATCH_LIST_GENPATCHES+=" > >   ${DISTDIR}/${tarball}" > >   Ä Ä Ä Ä Ä Ä Ä Ä Ä Ä Ä Ä > debug-print "genpatches tarball: > >   $tarball" > >   Ä Ä Ä Ä Ä Ä Ä Ä fi > >   -Ä Ä Ä Ä Ä Ä ÄÂ Ä GENPATCHES_URI+=" > >   > ${use_cond_start}mirror://gentoo/${tarball}${use_cond_end}" > >   +Ä Ä Ä Ä Ä Ä ÄÂ Ä GENPATCHES_URI+=" > >   > ${use_cond_start}[3][5]https://dev.gentoo.org/~mpagano/dist/genpatch > es/ > >   ${tarball}${use_cond_end} > >   +Ä Ä Ä Ä Ä Ä Ä Ä Ä ÄÂ Ä > >Â Â Â Ä > ${use_cond_start}[4][6]https://dev.gentoo.org/~whissi/dist/genpatche > s > >   /${tarball}${use_cond_end} > >   +Ä Ä Ä Ä Ä Ä Ä Ä Ä ÄÂ Ä > >Â Â Â Ä > ${use_cond_start}[5][7]https://dev.gentoo.org/~alicef/dist/genpatche > s > >   /${tarball}${use_cond_end}" > >   Ä Ä Ä Ä done > >Â Â Â Ä } > >   -- > >   2.21.0 > >   -- > >   Mike Pagano > >   Gentoo Developer - Kernel Project > >   Gentoo Sources - Member > >   E-MailÄ ÄÂ Ä : [6][8]mpag...@gentoo.org > >   GnuPG FPÄÂ Ä : EEE2 601D 0763 B60F 848CÄ 9E14 3C33 C650 > B576 E4E3 > >   Public Key : > >   > [7][9]http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index > > > > References > > > >  1. mailto:[10]mpag...@gentoo.org > >  2. mailto:[11]mpag...@gentoo.org > >  3. > [12]https://dev.gentoo.org/~mpagano/dist/genpatches/${tarball}${use_ > cond_end} > >  4. > [13]https://dev.gentoo.org/~whissi/dist/genpatches/${tarball}${use_c > ond_end} > >  5. > [14]https://dev.gentoo.org/~alicef/dist/genpatches/${tarball}${use_c > ond_end} > >  6. mailto:[15]mpag...@gentoo.org > >  7. > [16]http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index > -- > Mike Pagano > Gentoo Developer - Kernel Project > Gentoo Sources - Member > E-Mail   : [17]mpag...@gentoo.org > GnuPG FP  : EEE2 601D 0763 B60F 848C 9E14 3C33 C650 B576 E4E3 > Public Key : > [18]http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index > > References > >1. mailto:mpag...@gentoo.org >2. mailto:mpag...@gentoo.org >3. https://devmanual.gentoo.org/general-concepts/mirrors/index.html >4. mailto:mpag...@gentoo.org >5. https://dev.gentoo.org/~mpagano/dist/genpatches/ >6. https://dev.gentoo.org/~whissi/dist/genpatches >7. https://dev.gentoo.org/~alicef/dist/genpatches >8. mailto:mpag...@gentoo.org >9. http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index > 10. mailto:mpag...@gentoo.org > 11. mailto:mpag...@gentoo.org > 12. > https://dev.gentoo.org/~mpagano/dist/genpatches/${tarball}${use_cond_end} > 13. https://dev.gentoo.org/~whissi/dist/genpatches/${tarball}${use_cond_end} >
Re: [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace
On Thu, Oct 10, 2019 at 3:04 AM Mike Pagano wrote: > On Wed, Oct 09, 2019 at 06:23:06PM -0700, Alec Warner wrote: > >On Wed, Oct 9, 2019 at 10:01 AM Mike Pagano <[1]mpag...@gentoo.org> > >wrote: > > > > This change will support moving the genpatches tarballs from > > /space/distfiles-local to > > the devspace ~developer/public_html/dist/genpatches > > > >I think it would help if you discussed why we were making this change. > >(I mean I can guess why, but it's not obvious.) > >-A > >Ā > > I was informed that use of /space/distfiles-local is deprecated in favor > of devspace. > > https://devmanual.gentoo.org/general-concepts/mirrors/index.html That policy was made in 2011; so clearly it's not super urgent nor stringently applied. Which is to say, I'm not sure it needs to be a policy. -A > > > > > > > > > > Signed-off-by: Mike Pagano <[2]mpag...@gentoo.org> > > --- > > Ā eclass/kernel-2.eclass | 4 +++- > > Ā 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass > > index c5f35cd3e..0bc4f35de 100644 > > --- a/eclass/kernel-2.eclass > > +++ b/eclass/kernel-2.eclass > > @@ -295,7 +295,9 @@ handle_genpatches() { > > Ā Ā Ā Ā Ā Ā Ā Ā Ā Ā Ā Ā UNIPATCH_LIST_GENPATCHES+=" > > ${DISTDIR}/${tarball}" > > Ā Ā Ā Ā Ā Ā Ā Ā Ā Ā Ā Ā debug-print "genpatches tarball: > > $tarball" > > Ā Ā Ā Ā Ā Ā Ā Ā fi > > -Ā Ā Ā Ā Ā Ā Ā Ā GENPATCHES_URI+=" > > ${use_cond_start}mirror://gentoo/${tarball}${use_cond_end}" > > +Ā Ā Ā Ā Ā Ā Ā Ā GENPATCHES_URI+=" > > ${use_cond_start}[3] > https://dev.gentoo.org/~mpagano/dist/genpatches/ > > ${tarball}${use_cond_end} > > +Ā Ā Ā Ā Ā Ā Ā Ā Ā Ā Ā > > Ā ${use_cond_start}[4] > https://dev.gentoo.org/~whissi/dist/genpatches > > /${tarball}${use_cond_end} > > +Ā Ā Ā Ā Ā Ā Ā Ā Ā Ā Ā > > Ā ${use_cond_start}[5] > https://dev.gentoo.org/~alicef/dist/genpatches > > /${tarball}${use_cond_end}" > > Ā Ā Ā Ā done > > Ā } > > -- > > 2.21.0 > > -- > > Mike Pagano > > Gentoo Developer - Kernel Project > > Gentoo Sources - Member > > E-MailĀ Ā Ā : [6]mpag...@gentoo.org > > GnuPG FPĀ Ā : EEE2 601D 0763 B60F 848CĀ 9E14 3C33 C650 B576 E4E3 > > Public Key : > > [7]http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index > > > > References > > > >1. mailto:mpag...@gentoo.org > >2. mailto:mpag...@gentoo.org > >3. > https://dev.gentoo.org/~mpagano/dist/genpatches/${tarball}${use_cond_end} > >4. > https://dev.gentoo.org/~whissi/dist/genpatches/${tarball}${use_cond_end} > >5. > https://dev.gentoo.org/~alicef/dist/genpatches/${tarball}${use_cond_end} > >6. mailto:mpag...@gentoo.org > >7. http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index > > -- > Mike Pagano > Gentoo Developer - Kernel Project > Gentoo Sources - Member > E-Mail : mpag...@gentoo.org > GnuPG FP : EEE2 601D 0763 B60F 848C 9E14 3C33 C650 B576 E4E3 > Public Key : > http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index > >
Re: [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace
On 10.10.2019 13:04, Mike Pagano wrote: > On Wed, Oct 09, 2019 at 06:23:06PM -0700, Alec Warner wrote: >>On Wed, Oct 9, 2019 at 10:01 AM Mike Pagano <[1]mpag...@gentoo.org> >>wrote: >> >> This change will support moving the genpatches tarballs from >> /space/distfiles-local to >> the devspace ~developer/public_html/dist/genpatches >> >>I think it would help if you discussed why we were making this change. >>(I mean I can guess why, but it's not obvious.) >>-A >>Â > I was informed that use of /space/distfiles-local is deprecated in favor > of devspace. > > > https://devmanual.gentoo.org/general-concepts/mirrors/index.html > > This is not really true, (otherwise we would have to upload literally 8500 tarballs for texlive to my devspace). I'd say narrowing an eclass' URIs to the selected group of people is even worse for long-term usage. signature.asc Description: OpenPGP digital signature
Re: [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace
On Wed, Oct 09, 2019 at 06:23:06PM -0700, Alec Warner wrote: >On Wed, Oct 9, 2019 at 10:01 AM Mike Pagano <[1]mpag...@gentoo.org> >wrote: > > This change will support moving the genpatches tarballs from > /space/distfiles-local to > the devspace ~developer/public_html/dist/genpatches > >I think it would help if you discussed why we were making this change. >(I mean I can guess why, but it's not obvious.) >-A > I was informed that use of /space/distfiles-local is deprecated in favor of devspace. https://devmanual.gentoo.org/general-concepts/mirrors/index.html > > Signed-off-by: Mike Pagano <[2]mpag...@gentoo.org> > --- >  eclass/kernel-2.eclass | 4 +++- >  1 file changed, 3 insertions(+), 1 deletion(-) > diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass > index c5f35cd3e..0bc4f35de 100644 > --- a/eclass/kernel-2.eclass > +++ b/eclass/kernel-2.eclass > @@ -295,7 +295,9 @@ handle_genpatches() { >             UNIPATCH_LIST_GENPATCHES+=" > ${DISTDIR}/${tarball}" >             debug-print "genpatches tarball: > $tarball" >         fi > -        GENPATCHES_URI+=" > ${use_cond_start}mirror://gentoo/${tarball}${use_cond_end}" > +        GENPATCHES_URI+=" > ${use_cond_start}[3]https://dev.gentoo.org/~mpagano/dist/genpatches/ > ${tarball}${use_cond_end} > +           >  ${use_cond_start}[4]https://dev.gentoo.org/~whissi/dist/genpatches > /${tarball}${use_cond_end} > +           >  ${use_cond_start}[5]https://dev.gentoo.org/~alicef/dist/genpatches > /${tarball}${use_cond_end}" >     done >  } > -- > 2.21.0 > -- > Mike Pagano > Gentoo Developer - Kernel Project > Gentoo Sources - Member > E-Mail   : [6]mpag...@gentoo.org > GnuPG FP  : EEE2 601D 0763 B60F 848C 9E14 3C33 C650 B576 E4E3 > Public Key : > [7]http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index > > References > >1. mailto:mpag...@gentoo.org >2. mailto:mpag...@gentoo.org >3. > https://dev.gentoo.org/~mpagano/dist/genpatches/${tarball}${use_cond_end} >4. https://dev.gentoo.org/~whissi/dist/genpatches/${tarball}${use_cond_end} >5. https://dev.gentoo.org/~alicef/dist/genpatches/${tarball}${use_cond_end} >6. mailto:mpag...@gentoo.org >7. http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index -- Mike Pagano Gentoo Developer - Kernel Project Gentoo Sources - Member E-Mail : mpag...@gentoo.org GnuPG FP : EEE2 601D 0763 B60F 848C 9E14 3C33 C650 B576 E4E3 Public Key : http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index
Re: [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace
On Wed, Oct 9, 2019 at 10:01 AM Mike Pagano wrote: > This change will support moving the genpatches tarballs from > /space/distfiles-local to > the devspace ~developer/public_html/dist/genpatches > I think it would help if you discussed why we were making this change. (I mean I can guess why, but it's not obvious.) -A > > Signed-off-by: Mike Pagano > --- > eclass/kernel-2.eclass | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/eclass/kernel-2.eclass b/eclass/kernel-2.eclass > index c5f35cd3e..0bc4f35de 100644 > --- a/eclass/kernel-2.eclass > +++ b/eclass/kernel-2.eclass > @@ -295,7 +295,9 @@ handle_genpatches() { > UNIPATCH_LIST_GENPATCHES+=" ${DISTDIR}/${tarball}" > debug-print "genpatches tarball: $tarball" > fi > - GENPATCHES_URI+=" > ${use_cond_start}mirror://gentoo/${tarball}${use_cond_end}" > + GENPATCHES_URI+=" ${use_cond_start} > https://dev.gentoo.org/~mpagano/dist/genpatches/${tarball}${use_cond_end} > + ${use_cond_start} > https://dev.gentoo.org/~whissi/dist/genpatches/${tarball}${use_cond_end} > + ${use_cond_start} > https://dev.gentoo.org/~alicef/dist/genpatches/${tarball}${use_cond_end}"; > done > } > > -- > 2.21.0 > > -- > Mike Pagano > Gentoo Developer - Kernel Project > Gentoo Sources - Member > E-Mail : mpag...@gentoo.org > GnuPG FP : EEE2 601D 0763 B60F 848C 9E14 3C33 C650 B576 E4E3 > Public Key : > http://pgp.mit.edu:11371/pks/lookup?search=0xB576E4E3&op=index > >
Re: [gentoo-dev] [PATCH 1/1] kernel-2.eclass: Support move of genpatches tarballs from /space/distfiles-local to devspace
> On Wed, 09 Oct 2019, Mike Pagano wrote: > - GENPATCHES_URI+=" > ${use_cond_start}mirror://gentoo/${tarball}${use_cond_end}" > + GENPATCHES_URI+=" > ${use_cond_start}https://dev.gentoo.org/~mpagano/dist/genpatches/${tarball}${use_cond_end} > > + > ${use_cond_start}https://dev.gentoo.org/~whissi/dist/genpatches/${tarball}${use_cond_end} > > + > ${use_cond_start}https://dev.gentoo.org/~alicef/dist/genpatches/${tarball}${use_cond_end}"; Why is the USE conditional repeated three times? These URLs could all be inside the same block. Ulrich signature.asc Description: PGP signature