Re: [gentoo-dev] [PATCH 1/2] bzr.eclass: Reinstate eclass

2021-09-27 Thread Michał Górny
On Mon, 2021-09-27 at 20:01 +0200, Ulrich Mueller wrote: > > > > > > On Mon, 27 Sep 2021, Michał Górny wrote: > > > You seem to be missing the fact that all of them hardcode "bzr". > > Yes, and it is updated to "brz" in a followup commit. Would you prefer > leaving them as "bzr"? I guess that

Re: [gentoo-dev] [PATCH 1/2] bzr.eclass: Reinstate eclass

2021-09-27 Thread Ulrich Mueller
> On Mon, 27 Sep 2021, Michał Górny wrote: > You seem to be missing the fact that all of them hardcode "bzr". Yes, and it is updated to "brz" in a followup commit. Would you prefer leaving them as "bzr"? I guess that backwards compatibility link will stay there for a long time.

Re: [gentoo-dev] [PATCH 1/2] bzr.eclass: Reinstate eclass

2021-09-27 Thread Michał Górny
On Mon, 2021-09-27 at 19:25 +0200, Ulrich Mueller wrote: > > > > > > On Sat, 25 Sep 2021, Michał Górny wrote: > > > > +EBZR="bzr.eclass" > > > Why do we need this? It seems as if someone is reinventing > > ${ECLASS}. > > Replaced by ${ECLASS}. > > > > +# @ECLASS-VARIABLE: EBZR_STORE_DIR > >

Re: [gentoo-dev] [PATCH 1/2] bzr.eclass: Reinstate eclass

2021-09-27 Thread Ulrich Mueller
> On Sat, 25 Sep 2021, Michał Górny wrote: >> +EBZR="bzr.eclass" > Why do we need this? It seems as if someone is reinventing ${ECLASS}. Replaced by ${ECLASS}. >> +# @ECLASS-VARIABLE: EBZR_STORE_DIR > @USER_VARIABLE? Added. >> +# @DESCRIPTION: >> +# The directory to store all fetched

Re: [gentoo-dev] [PATCH 1/2] bzr.eclass: Reinstate eclass

2021-09-25 Thread Ulrich Mueller
> On Sat, 25 Sep 2021, Arthur Zamarin wrote: > On 25/09/2021 12:36, Ulrich Müller wrote: >> +if [[ -z ${EBZR_INITIAL_URI} ]]; then >> +bzr_initial_fetch "${EBZR_REPO_URI}" "${branch_dir}" >> +else >> +# Workaround for faster

Re: [gentoo-dev] [PATCH 1/2] bzr.eclass: Reinstate eclass

2021-09-25 Thread Arthur Zamarin
On 25/09/2021 12:36, Ulrich Müller wrote: Taken from commit 320fcf034f5e860454e0d2a28ed405c5b843c60c. Signed-off-by: Ulrich Müller --- eclass/bzr.eclass | 289 ++ 1 file changed, 289 insertions(+) create mode 100644 eclass/bzr.eclass diff --git

Re: [gentoo-dev] [PATCH 1/2] bzr.eclass: Reinstate eclass

2021-09-25 Thread Michał Górny
On Sat, 2021-09-25 at 11:36 +0200, Ulrich Müller wrote: > Taken from commit 320fcf034f5e860454e0d2a28ed405c5b843c60c. I suppose you'll want to apply my comments as followup changes. > > Signed-off-by: Ulrich Müller > --- > eclass/bzr.eclass | 289 ++