Re: [gentoo-dev] [PATCH 1/3] autotools.eclass: Downgrade eqawarn for renaming configure.in
El dom, 28-05-2023 a las 15:16 +0200, Ulrich Müller escribió:
> At this point, almost all upstreams will have switched to
> configure.ac.
> Therefore, configure.in is most likely an indication of an inactive
> upstream, and there is no useful way for the ebuild maintainer to
> silence the warning (other than the ebuild renaming the file).
>
> Keep the message as einfo, so there is still an indication that the
> file
> was renamed.
>
> Bug: https://bugs.gentoo.org/426262
> Signed-off-by: Ulrich Müller
> ---
> eclass/autotools.eclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/eclass/autotools.eclass b/eclass/autotools.eclass
> index 91046b9f82f3..3a040b863eea 100644
> --- a/eclass/autotools.eclass
> +++ b/eclass/autotools.eclass
> @@ -400,7 +400,7 @@ eautoconf() {
> *)
> # Move configure file to the new
> location only on newer EAPIs to ensure
> # checks are done rather than
> retroactively breaking ebuilds.
> - eqawarn "Moving configure.in to
> configure.ac (bug #426262)"
> + einfo "Moving configure.in to
> configure.ac (bug #426262)"
> mv configure.{in,ac} || die
> ;;
> esac
LGTM
Thanks!
signature.asc
Description: This is a digitally signed message part
Re: [gentoo-dev] [PATCH 1/3] autotools.eclass: Downgrade eqawarn for renaming configure.in
Ulrich Müller writes:
> At this point, almost all upstreams will have switched to configure.ac.
> Therefore, configure.in is most likely an indication of an inactive
> upstream, and there is no useful way for the ebuild maintainer to
> silence the warning (other than the ebuild renaming the file).
Ionen's point was that such packages therefore regularly get updates
so a QA warning when rarely revbumping it isn't necessarily a problem either.
But I also don't think it's likely that upstream will ever actually
enforce this, so OK.
>
> Keep the message as einfo, so there is still an indication that the file
> was renamed.
>
> Bug: https://bugs.gentoo.org/426262
> Signed-off-by: Ulrich Müller
> ---
> eclass/autotools.eclass | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/eclass/autotools.eclass b/eclass/autotools.eclass
> index 91046b9f82f3..3a040b863eea 100644
> --- a/eclass/autotools.eclass
> +++ b/eclass/autotools.eclass
> @@ -400,7 +400,7 @@ eautoconf() {
> *)
> # Move configure file to the new location only
> on newer EAPIs to ensure
> # checks are done rather than retroactively
> breaking ebuilds.
> - eqawarn "Moving configure.in to configure.ac
> (bug #426262)"
> + einfo "Moving configure.in to configure.ac (bug
> #426262)"
> mv configure.{in,ac} || die
> ;;
> esac
signature.asc
Description: PGP signature
