Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules

2019-09-13 Thread Kent Fredric
On Thu, 12 Sep 2019 23:12:52 +0200 Michał Górny wrote: > Since when it is a bug that when you strip debug info, you don't have > debug info? I thought that's precisely what stripping debug info means > but maybe in the special Go world it is different, and debug info is > expected to remain

Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules

2019-09-12 Thread Alec Warner
On Thu, Sep 12, 2019 at 2:13 PM Michał Górny wrote: > On Thu, 2019-09-12 at 13:38 -0700, Alec Warner wrote: > > On Thu, Sep 12, 2019 at 1:20 PM Kent Fredric wrote: > > > > > On Wed, 11 Sep 2019 17:28:22 -0700 > > > Alec Warner wrote: > > > > > > > I don't care if you strip or not (I'm not even

Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules

2019-09-12 Thread Michał Górny
On Thu, 2019-09-12 at 13:38 -0700, Alec Warner wrote: > On Thu, Sep 12, 2019 at 1:20 PM Kent Fredric wrote: > > > On Wed, 11 Sep 2019 17:28:22 -0700 > > Alec Warner wrote: > > > > > I don't care if you strip or not (I'm not even sure portage knows how to > > do > > > it for go binaries) but

Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules

2019-09-12 Thread Michał Górny
On Fri, 2019-09-13 at 08:16 +1200, Kent Fredric wrote: > On Thu, 12 Sep 2019 19:03:02 +0200 > Michał Górny wrote: > > > ebuild spire-0.8.1.ebuild fetch > > tar -xf ${DISTDIR}/spire-0.8.1.tar.gz > > cd spire-0.8.1/ > > go mod vendor > > cd ../ > > tar -cf spire-0.8.1-vendor.tar spire-0.8.1/vendor

Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules

2019-09-12 Thread Alec Warner
On Thu, Sep 12, 2019 at 1:20 PM Kent Fredric wrote: > On Wed, 11 Sep 2019 17:28:22 -0700 > Alec Warner wrote: > > > I don't care if you strip or not (I'm not even sure portage knows how to > do > > it for go binaries) but I'm fairly sure the reason isn't because > "upstream > > does not support

Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules

2019-09-12 Thread Kent Fredric
On Wed, 11 Sep 2019 17:28:22 -0700 Alec Warner wrote: > I don't care if you strip or not (I'm not even sure portage knows how to do > it for go binaries) but I'm fairly sure the reason isn't because "upstream > does not support stripping go binaries" because they clearly do...unless > upstream

Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules

2019-09-12 Thread Kent Fredric
On Thu, 12 Sep 2019 19:03:02 +0200 Michał Górny wrote: > ebuild spire-0.8.1.ebuild fetch > tar -xf ${DISTDIR}/spire-0.8.1.tar.gz > cd spire-0.8.1/ > go mod vendor > cd ../ > tar -cf spire-0.8.1-vendor.tar spire-0.8.1/vendor > > Now you don't need special src_prepare() to unpack it. Of course,

Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules

2019-09-12 Thread Michał Górny
On Thu, 2019-09-12 at 11:39 -0500, William Hubbs wrote: > On Thu, Sep 12, 2019 at 05:39:42AM +, Michał Górny wrote: > > Dnia September 11, 2019 11:11:15 PM UTC, William Hubbs > > napisał(a): > > > You are right, and currently I quietly ignore your vendor tarball if > > > upstream > > >

Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules

2019-09-12 Thread William Hubbs
On Thu, Sep 12, 2019 at 05:39:42AM +, Michał Górny wrote: > Dnia September 11, 2019 11:11:15 PM UTC, William Hubbs > napisał(a): > >On Wed, Sep 11, 2019 at 07:47:04PM +, Michał Górny wrote: > >> Dnia September 11, 2019 7:40:41 PM UTC, William Hubbs > > napisał(a): > >> >On Wed, Sep 11,

Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules

2019-09-12 Thread William Hubbs
On Wed, Sep 11, 2019 at 05:28:22PM -0700, Alec Warner wrote: > On Wed, Sep 11, 2019 at 5:05 PM William Hubbs wrote: > > > On Wed, Sep 11, 2019 at 04:31:00PM -0700, Alec Warner wrote: > > > On Wed, Sep 11, 2019 at 10:28 AM William Hubbs > > wrote: > > > > > > > Copyright: Sony Interactive

Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules

2019-09-11 Thread Michał Górny
Dnia September 11, 2019 11:11:15 PM UTC, William Hubbs napisał(a): >On Wed, Sep 11, 2019 at 07:47:04PM +, Michał Górny wrote: >> Dnia September 11, 2019 7:40:41 PM UTC, William Hubbs > napisał(a): >> >On Wed, Sep 11, 2019 at 08:31:16PM +0200, Michał Górny wrote: >> >> On Wed, 2019-09-11 at

Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules

2019-09-11 Thread Alec Warner
On Wed, Sep 11, 2019 at 5:05 PM William Hubbs wrote: > On Wed, Sep 11, 2019 at 04:31:00PM -0700, Alec Warner wrote: > > On Wed, Sep 11, 2019 at 10:28 AM William Hubbs > wrote: > > > > > Copyright: Sony Interactive Entertainment Inc. > > > Signed-off-by: William Hubbs > > > --- > > >

Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules

2019-09-11 Thread William Hubbs
On Wed, Sep 11, 2019 at 04:31:00PM -0700, Alec Warner wrote: > On Wed, Sep 11, 2019 at 10:28 AM William Hubbs wrote: > > > Copyright: Sony Interactive Entertainment Inc. > > Signed-off-by: William Hubbs > > --- > > eclass/go-module.eclass | 76 + > > 1

Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules

2019-09-11 Thread Alec Warner
On Wed, Sep 11, 2019 at 10:28 AM William Hubbs wrote: > Copyright: Sony Interactive Entertainment Inc. > Signed-off-by: William Hubbs > --- > eclass/go-module.eclass | 76 + > 1 file changed, 76 insertions(+) > create mode 100644 eclass/go-module.eclass

Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules

2019-09-11 Thread William Hubbs
On Wed, Sep 11, 2019 at 07:47:04PM +, Michał Górny wrote: > Dnia September 11, 2019 7:40:41 PM UTC, William Hubbs > napisał(a): > >On Wed, Sep 11, 2019 at 08:31:16PM +0200, Michał Górny wrote: > >> On Wed, 2019-09-11 at 13:22 -0500, William Hubbs wrote: > >> > On Wed, Sep 11, 2019 at

Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules

2019-09-11 Thread Michał Górny
Dnia September 11, 2019 7:40:41 PM UTC, William Hubbs napisał(a): >On Wed, Sep 11, 2019 at 08:31:16PM +0200, Michał Górny wrote: >> On Wed, 2019-09-11 at 13:22 -0500, William Hubbs wrote: >> > On Wed, Sep 11, 2019 at 07:38:17PM +0200, Michał Górny wrote: >> > > On Wed, 2019-09-11 at 12:21 -0500,

Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules

2019-09-11 Thread William Hubbs
On Wed, Sep 11, 2019 at 08:31:16PM +0200, Michał Górny wrote: > On Wed, 2019-09-11 at 13:22 -0500, William Hubbs wrote: > > On Wed, Sep 11, 2019 at 07:38:17PM +0200, Michał Górny wrote: > > > On Wed, 2019-09-11 at 12:21 -0500, William Hubbs wrote: > > > > Copyright: Sony Interactive Entertainment

Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules

2019-09-11 Thread Michał Górny
On Wed, 2019-09-11 at 13:22 -0500, William Hubbs wrote: > On Wed, Sep 11, 2019 at 07:38:17PM +0200, Michał Górny wrote: > > On Wed, 2019-09-11 at 12:21 -0500, William Hubbs wrote: > > > Copyright: Sony Interactive Entertainment Inc. > > > Signed-off-by: William Hubbs > > > --- > > >

Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules

2019-09-11 Thread William Hubbs
On Wed, Sep 11, 2019 at 07:38:17PM +0200, Michał Górny wrote: > On Wed, 2019-09-11 at 12:21 -0500, William Hubbs wrote: > > Copyright: Sony Interactive Entertainment Inc. > > Signed-off-by: William Hubbs > > --- > > eclass/go-module.eclass | 76 + > > 1

Re: [gentoo-dev] [PATCH 1/3] go-module.eclass: introduce new eclass to handle go modules

2019-09-11 Thread Michał Górny
On Wed, 2019-09-11 at 12:21 -0500, William Hubbs wrote: > Copyright: Sony Interactive Entertainment Inc. > Signed-off-by: William Hubbs > --- > eclass/go-module.eclass | 76 + > 1 file changed, 76 insertions(+) > create mode 100644 eclass/go-module.eclass