Re: [gentoo-dev] [PATCH 1/4] distutils-r1.eclass: Introduce install_for_testing --via-root

2020-11-29 Thread Michał Górny
On Sun, 2020-11-29 at 12:02 +0100, Ulrich Mueller wrote:
> > > > > > On Sun, 29 Nov 2020, Michał Górny wrote:
>  
> > +   case ${install_method} in
> > +   home)
> > +   local add_args=(
> > +   install
> > +   --home="${TEST_DIR}"
> > +   --install-lib="${libdir}"
> > +   --install-scripts="${bindir}"
> > +   )
> > +   mkdir -p "${libdir}" || die
> > +   ;;
> > +   root)
> > +   local add_args=(
> > +   install
> > +   --root="${TEST_DIR}"
> > +   --install-lib=lib
> > +   --install-scripts=scripts
> > +   )
> > +   ;;
> > +   esac
> 
> Having the same "local add_args" declaration twice looks strange and may
> be error prone. Can you move it outside of the case statement?
> 
> Also, why are the array elements at different indent levels?
> 

Because they are options passed to 'install' command.

-- 
Best regards,
Michał Górny



signature.asc
Description: This is a digitally signed message part


Re: [gentoo-dev] [PATCH 1/4] distutils-r1.eclass: Introduce install_for_testing --via-root

2020-11-29 Thread Ulrich Mueller
> On Sun, 29 Nov 2020, Michał Górny wrote:
 
> + case ${install_method} in
> + home)
> + local add_args=(
> + install
> + --home="${TEST_DIR}"
> + --install-lib="${libdir}"
> + --install-scripts="${bindir}"
> + )
> + mkdir -p "${libdir}" || die
> + ;;
> + root)
> + local add_args=(
> + install
> + --root="${TEST_DIR}"
> + --install-lib=lib
> + --install-scripts=scripts
> + )
> + ;;
> + esac

Having the same "local add_args" declaration twice looks strange and may
be error prone. Can you move it outside of the case statement?

Also, why are the array elements at different indent levels?

Ulrich


signature.asc
Description: PGP signature